bug#26386: [PATCH 0/1] Update the connection script of openconnect (and vpnc?)

bug#26386: [PATCH 0/1] Update the connection script of openconnect (and vpnc?)

[Ludovic Courtès]

Hello,

(Cc’ing Tobias who touched openconnect recently.)

With openconnect I was experiencing the problem described at
<http://blog.nowherelan.com/2011/10/10/vpnc-on-ubuntu-oneiric-error-either-to-is-duplicate-or-ipid-is-a-garbage/>.
Namely, openconnect eventually fails with:

  Error: either "to" is duplicate, or "ipid" is a garbage.

This patch updates openconnect to use a newer vpnc script, as advised
on the Web page above.  It fixes the problem for me.

If someone reading this uses openconnect, could you check that it also
works for you?

Also, I wonder if we should be fixing vpnc rather than openconnect.

Thoughts?

Ludo’.

Ludovic Courtès (1):
  gnu: openconnect: Use a newer vpnc script.

 gnu/packages/vpn.scm | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

-- 
2.12.2

bug#26386: [PATCH 1/1] gnu: openconnect: Use a newer vpnc script.

[Ludovic Courtès]

* gnu/packages/vpn.scm (openconnect)[native-inputs]: Add "vpnc-script".
[arguments]: Add 'copy-vpnc-script' phase.
---
 gnu/packages/vpn.scm | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index efb46f73d..a46c1e25f 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
-;;; Copyright © 2013, 2016 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2013, 2016, 2017 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2015 Jeff Mickey <j@codemac.net>
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
@@ -135,12 +135,36 @@ Only \"Universal TUN/TAP device driver support\" is needed in the kernel.")
       ("zlib" ,zlib)))
    (native-inputs
     `(("gettext" ,gettext-minimal)
-      ("pkg-config" ,pkg-config)))
+      ("pkg-config" ,pkg-config)
+      ("vpnc-script" ,(origin
+                        (method url-fetch)
+                        (uri
+                         "http://git.infradead.org/users/dwmw2/vpnc-scripts.git/\
+blob_plain/6f87b0fe7b20d802a0747cc310217920047d58d3:/vpnc-script")
+                        (sha256
+                         (base32
+                          "0v22x0bjfdawma1dwnjczz3bqifh6r8ys0lv5nhnwsghs1imk7hn"))))))
    (arguments
     `(#:configure-flags
       `(,(string-append "--with-vpnc-script="
-                        (assoc-ref %build-inputs "vpnc")
-                        "/etc/vpnc/vpnc-script"))))
+                        (string-append %output "/etc/vpnc/vpnc-script")))
+      #:phases (modify-phases %standard-phases
+                 (add-after 'unpack 'copy-vpnc-script
+                   (lambda* (#:key inputs outputs #:allow-other-keys)
+                     ;; Override the script that comes with vpnc to work
+                     ;; around vpnc error:
+                     ;;
+                     ;;   Error: either "to" is duplicate, or "ipid" is a garbage.
+                     ;;
+                     ;; See <http://blog.nowherelan.com/2011/10/10/vpnc-on-ubuntu-oneiric-error-either-to-is-duplicate-or-ipid-is-a-garbage/>.
+                     (let* ((out    (assoc-ref outputs "out"))
+                            (script (string-append out
+                                                   "/etc/vpnc/vpnc-script")))
+                       (mkdir-p (dirname script))
+                       (copy-file (assoc-ref inputs "vpnc-script")
+                                  script)
+                       (chmod script #o755)
+                       #t))))))
    (synopsis "Client for Cisco VPN")
    (description
     "OpenConnect is a client for Cisco's AnyConnect SSL VPN, which is
-- 
2.12.2

bug#26386: [PATCH 0/1] Update the connection script of openconnect (and vpnc?)

[Ludovic Courtès]

Heya Tobias,

Ludovic Courtès <ludo@gnu.org> skribis:

> (Cc’ing Tobias who touched openconnect recently.)
>
> With openconnect I was experiencing the problem described at
> <http://blog.nowherelan.com/2011/10/10/vpnc-on-ubuntu-oneiric-error-either-to-is-duplicate-or-ipid-is-a-garbage/>.
> Namely, openconnect eventually fails with:
>
>   Error: either "to" is duplicate, or "ipid" is a garbage.
>
> This patch updates openconnect to use a newer vpnc script, as advised
> on the Web page above.  It fixes the problem for me.
>
> If someone reading this uses openconnect, could you check that it also
> works for you?
>
> Also, I wonder if we should be fixing vpnc rather than openconnect.

So, what do you think?  :-)

  https://bugs.gnu.org/26386

TIA,
Ludo’.

bug#26386: [PATCH 0/1] Update the connection script of openconnect (and vpnc?)

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 1386 bytes --]

Ludo'!

On 21/04/17 11:04, Ludovic Courtès wrote:
> So, what do you think?  :-)

Argh. I'm wading through an e-mail back-log, sorry. Feel free to ping me
like this when needed.

>> If someone reading this uses openconnect, could you check that it also
>> works for you?

I used it for a limited time (job) and no longer have or want access to
such a VPN.

>> This patch updates openconnect to use a newer vpnc script, as advised
>> on the Web page above.  It fixes the problem for me.

>> Also, I wonder if we should be fixing vpnc rather than openconnect.

I was going to suggest a crazy third option: why not add all of
vpnc-scripts[0] as a new package, since that's basically what it is?
openconnect would default to vnpc-scripts' ‘vpnc-script’, but people
could try out other interesting-looking hacks like ‘vpnc-script-sshd’.

Turns out that this is exactly what Debian already does.[1] Heh.

I doubt very much the author can — or wants to be — bothered to do
releases[3]. If that's not a problem, I'll gladly write a new patch.

Kind regards,

T G-R

[0]: http://git.infradead.org/users/dwmw2/vpnc-scripts.git
[1]: https://packages.debian.org/jessie/all/vpnc-scripts
[2]: Which is arguably better than having releases and never finishing
     them;
http://lists.unix-ag.uni-kl.de/pipermail/vpnc-devel/2013-December/004000.html


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

bug#26386: [PATCH 0/1] Update the connection script of openconnect (and vpnc?)

[Ludovic Courtès]

Hi Tobias!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 21/04/17 11:04, Ludovic Courtès wrote:
>> So, what do you think?  :-)
>
> Argh. I'm wading through an e-mail back-log, sorry. Feel free to ping me
> like this when needed.

OK, no problem!

> I was going to suggest a crazy third option: why not add all of
> vpnc-scripts[0] as a new package, since that's basically what it is?
> openconnect would default to vnpc-scripts' ‘vpnc-script’, but people
> could try out other interesting-looking hacks like ‘vpnc-script-sshd’.
>
> Turns out that this is exactly what Debian already does.[1] Heh.

Sounds like a good plan, surely better than my initial patch.

> I doubt very much the author can — or wants to be — bothered to do
> releases[3]. If that's not a problem, I'll gladly write a new patch.

That would be awesome!

Thank you,
Ludo’.