From: Pjotr Prins <pjotr.public12@thebird.nl>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v2 1/2] gnu: Add dub.
Date: Sat, 28 Jan 2017 06:19:20 +0000 [thread overview]
Message-ID: <20170128061920.GB22634@mail.thebird.nl> (raw)
In-Reply-To: <87inp5l7i6.fsf@gnu.org>
Great work!
On Mon, Jan 23, 2017 at 11:46:25PM +0100, Ludovic Courtès wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
> > * gnu/packages/ldc.scm (dub): New variable.
>
> [...]
>
> > + (modify-phases %standard-phases
> > + (delete 'configure)
> > + (replace 'build
> > + (lambda _
> > + (zero? (system* "./build.sh"))))
> > + (replace 'install
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (outbin (string-append out "/bin")))
> > + (mkdir-p outbin)
> > + (install-file "bin/dub" outbin)))))))
>
> Please add #t at the end of this lambda, to denote success.
>
> Otherwise LGTM, thanks!
>
> Ludo’.
>
--
next prev parent reply other threads:[~2017-01-28 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 18:24 [PATCH v2 0/2] Add dub and dub-build-system Danny Milosavljevic
2017-01-23 18:24 ` [PATCH v2 1/2] gnu: Add dub Danny Milosavljevic
2017-01-23 22:46 ` Ludovic Courtès
2017-01-28 6:19 ` Pjotr Prins [this message]
2017-01-29 22:50 ` Danny Milosavljevic
2017-01-23 18:24 ` [PATCH v2 2/2] gnu: Add dub-build-system Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170128061920.GB22634@mail.thebird.nl \
--to=pjotr.public12@thebird.nl \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.