From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pjotr Prins <pjotr.public12@thebird.nl>
Subject: Re: [PATCH v2 1/2] gnu: Add dub.
Date: Sat, 28 Jan 2017 06:19:20 +0000
Message-ID: <20170128061920.GB22634@mail.thebird.nl>
References: <20170123182409.16427-1-dannym@scratchpost.org>
	<20170123182409.16427-2-dannym@scratchpost.org>
	<87inp5l7i6.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39972)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pjotr2017@thebird.nl>) id 1cXMP3-0003nO-Gg
	for guix-devel@gnu.org; Sat, 28 Jan 2017 01:22:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pjotr2017@thebird.nl>) id 1cXMP0-0000o4-By
	for guix-devel@gnu.org; Sat, 28 Jan 2017 01:22:25 -0500
Content-Disposition: inline
In-Reply-To: <87inp5l7i6.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Great work!

On Mon, Jan 23, 2017 at 11:46:25PM +0100, Ludovic Court=C3=A8s wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>=20
> > * gnu/packages/ldc.scm (dub): New variable.
>=20
> [...]
>=20
> > +       (modify-phases %standard-phases
> > +         (delete 'configure)
> > +         (replace 'build
> > +           (lambda _
> > +             (zero? (system* "./build.sh"))))
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out (assoc-ref outputs "out"))
> > +                    (outbin (string-append out "/bin")))
> > +               (mkdir-p outbin)
> > +               (install-file "bin/dub" outbin)))))))
>=20
> Please add #t at the end of this lambda, to denote success.
>=20
> Otherwise LGTM, thanks!
>=20
> Ludo=E2=80=99.
>=20

--=20