all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/5] gnu: Add libvirt.
Date: Sat, 6 Aug 2016 22:26:24 -0400	[thread overview]
Message-ID: <20160807022624.GA11896@jasmine> (raw)
In-Reply-To: <20160803154603.6939-2-rekado@elephly.net>

On Wed, Aug 03, 2016 at 05:45:59PM +0200, Ricardo Wurmus wrote:
> +         (add-after 'unpack 'fix-tests
> +           (lambda _
> +             (substitute* '("tests/commandtest.c"
> +                            "gnulib/tests/test-posix_spawn1.c"
> +                            "gnulib/tests/test-posix_spawn2.c")
> +               (("/bin/sh") (which "bash")))
> +             #t))

According to the man page, Bash changes its behavior to be more POSIX-y
when called as sh.  So, how about replacing these shebangs with (which
"sh"), since their names suggest they are testing some POSIX behavior
(at least the latter two tests).

  reply	other threads:[~2016-08-07  2:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03 15:45 [PATCH 0/5] Add virt-manager Ricardo Wurmus
2016-08-03 15:45 ` [PATCH 1/5] gnu: Add libvirt Ricardo Wurmus
2016-08-07  2:26   ` Leo Famulari [this message]
2016-08-10 14:13     ` Ricardo Wurmus
2016-08-03 15:46 ` [PATCH 2/5] gnu: Add libosinfo Ricardo Wurmus
2016-08-07  2:30   ` Leo Famulari
2016-08-11 16:41     ` Ricardo Wurmus
2016-08-12 18:17     ` Ricardo Wurmus
2016-08-03 15:46 ` [PATCH 3/5] gnu: Add libvirt-glib Ricardo Wurmus
2016-08-03 15:46 ` [PATCH 4/5] gnu: Add python-libvirt Ricardo Wurmus
2016-08-03 15:46 ` [PATCH 5/5] gnu: Add virt-manager Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160807022624.GA11896@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.