From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/5] gnu: Add libvirt. Date: Sat, 6 Aug 2016 22:26:24 -0400 Message-ID: <20160807022624.GA11896@jasmine> References: <20160803154603.6939-1-rekado@elephly.net> <20160803154603.6939-2-rekado@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWDnS-0005vY-Cr for guix-devel@gnu.org; Sat, 06 Aug 2016 22:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWDnO-0007iz-6S for guix-devel@gnu.org; Sat, 06 Aug 2016 22:26:37 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWDnN-0007iR-07 for guix-devel@gnu.org; Sat, 06 Aug 2016 22:26:34 -0400 Content-Disposition: inline In-Reply-To: <20160803154603.6939-2-rekado@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org On Wed, Aug 03, 2016 at 05:45:59PM +0200, Ricardo Wurmus wrote: > + (add-after 'unpack 'fix-tests > + (lambda _ > + (substitute* '("tests/commandtest.c" > + "gnulib/tests/test-posix_spawn1.c" > + "gnulib/tests/test-posix_spawn2.c") > + (("/bin/sh") (which "bash"))) > + #t)) According to the man page, Bash changes its behavior to be more POSIX-y when called as sh. So, how about replacing these shebangs with (which "sh"), since their names suggest they are testing some POSIX behavior (at least the latter two tests).