all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: 45991@debbugs.gnu.org
Subject: [bug#45991] [PATCH core-updates] Move 'mkdir-p/perms' to gnu/build/utils.scm
Date: Tue, 19 Jan 2021 19:52:07 +0100	[thread overview]
Message-ID: <1fb485e7e14e452c96673bebe60d8b14bb536e80.camel@telenet.be> (raw)
In-Reply-To: <8dda4413505b28fedb9588a4064812fe69c19a37.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

I forgot to mention some atomicity issues the
current mkdir-p/perms has. Excerpt from IRC:

(15:17:25) mdevos: I see ‘mkdir-p/perms’ doesn't create the directory
and set the permissions atomically; there's a tiny window where a
freshly-created directory has the permissions that would be expected
from the umask. Is this something to be concerned about (and to be
fixed in the patch)?
(15:40:46) civodul: mdevos: it's a good idea to be concerned about
this, yes :-)
(15:41:27) civodul: in general, given that changes in (guix build utils)
take time to trickle in, we should be extra cautious about interfaces and
implementation details

This patch doesn't address these potential issues.
Also, %dovecot-activation has an anomalous mkdir-p/perms.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2021-01-19 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 18:42 [bug#45991] [PATCH core-updates] Move 'mkdir-p/perms' to gnu/build/utils.scm Maxime Devos
2021-01-19 18:52 ` Maxime Devos [this message]
2021-04-22  8:56 ` Ludovic Courtès
2023-10-20  2:38   ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fb485e7e14e452c96673bebe60d8b14bb536e80.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=45991@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.