From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AKRbD7c5B2AVaQAA0tVLHw (envelope-from ) for ; Tue, 19 Jan 2021 19:57:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cKEkC7c5B2A0BgAAB5/wlQ (envelope-from ) for ; Tue, 19 Jan 2021 19:57:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD2279402C8 for ; Tue, 19 Jan 2021 19:57:42 +0000 (UTC) Received: from localhost ([::1]:33312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1x8H-0007jd-Ki for larch@yhetil.org; Tue, 19 Jan 2021 14:57:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1w7j-00056F-I1 for guix-patches@gnu.org; Tue, 19 Jan 2021 13:53:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1w7j-0003tZ-6S for guix-patches@gnu.org; Tue, 19 Jan 2021 13:53:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1w7i-0001ye-1o for guix-patches@gnu.org; Tue, 19 Jan 2021 13:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45991] [PATCH core-updates] Move 'mkdir-p/perms' to gnu/build/utils.scm Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Jan 2021 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45991@debbugs.gnu.org Received: via spool by 45991-submit@debbugs.gnu.org id=B45991.16110823487557 (code B ref 45991); Tue, 19 Jan 2021 18:53:02 +0000 Received: (at 45991) by debbugs.gnu.org; 19 Jan 2021 18:52:28 +0000 Received: from localhost ([127.0.0.1]:51758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1w79-0001xp-VP for submit@debbugs.gnu.org; Tue, 19 Jan 2021 13:52:28 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:52962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1w6t-0001xO-Lm for 45991@debbugs.gnu.org; Tue, 19 Jan 2021 13:52:26 -0500 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id Jis92400C0mfAB406is9hm; Tue, 19 Jan 2021 19:52:09 +0100 Message-ID: <1fb485e7e14e452c96673bebe60d8b14bb536e80.camel@telenet.be> From: Maxime Devos Date: Tue, 19 Jan 2021 19:52:07 +0100 In-Reply-To: <8dda4413505b28fedb9588a4064812fe69c19a37.camel@telenet.be> References: <8dda4413505b28fedb9588a4064812fe69c19a37.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-c65rmL81HQbl59GAY6o7" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 45991@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DD2279402C8 X-Spam-Score: -4.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: WiCTfXgateep --=-c65rmL81HQbl59GAY6o7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I forgot to mention some atomicity issues the current mkdir-p/perms has. Excerpt from IRC: (15:17:25) mdevos: I see =E2=80=98mkdir-p/perms=E2=80=99 doesn't create the= directory and set the permissions atomically; there's a tiny window where a freshly-created directory has the permissions that would be expected from the umask. Is this something to be concerned about (and to be fixed in the patch)? (15:40:46) civodul: mdevos: it's a good idea to be concerned about this, yes :-) (15:41:27) civodul: in general, given that changes in (guix build utils) take time to trickle in, we should be extra cautious about interfaces and implementation details This patch doesn't address these potential issues. Also, %dovecot-activation has an anomalous mkdir-p/perms. --=-c65rmL81HQbl59GAY6o7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYAcqWBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vnSAQCqYVBF6vm/ZeewRD8UKbL8jKGn zIhwKOaYD06kpp0usgEApjg0zx9C+lV55cc2WMUnOJHymEKxXc8ZlKU2KzfFtgs= =X7tY -----END PGP SIGNATURE----- --=-c65rmL81HQbl59GAY6o7--