all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Skyler Ferris via Guix-patches via <guix-patches@gnu.org>
To: "Wiktor Żelazny" <wz@freeshell.de>, 69251@debbugs.gnu.org
Cc: Ricardo Wurmus <rekado@elephly.net>
Subject: [bug#69251] [PATCH] gnu: Add r-abbreviate.
Date: Sun, 18 Feb 2024 23:05:46 +0000	[thread overview]
Message-ID: <1f1e5f47-7d6b-4feb-8f8c-3a3b511a6385@protonmail.com> (raw)
In-Reply-To: <ce6d33884c81110d3fe99ece4d3d32c443248875.1708281031.git.wz@freeshell.de>

Hi Wiktor,

Thanks for submitting this patch! I'm adding some review notes to this 
thread in hopes that whichever committer looks at this patch will be 
able to process it more efficiently. It looks clean to me overall. I did 
mark "Project is maintained" as "Attention" more as an indication to the 
committer than to you. I think this is fine but it seems abnormal to me, 
although I am new to reviewing patches so maybe it is more normal than I 
think. =) If you have any additional context to add I am sure it will be 
appreciated! I will send detailed notes about this and everything else I 
looked at in a separate email. I welcome any feedback you have about my 
review process.

Regards,
Skyler





  reply	other threads:[~2024-02-18 23:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18 18:31 [bug#69251] [PATCH] gnu: Add r-abbreviate Wiktor Żelazny
2024-02-18 23:05 ` Skyler Ferris via Guix-patches via [this message]
2024-02-18 23:06 ` Skyler Ferris via Guix-patches via
2024-02-19 12:57 ` bug#69251: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f1e5f47-7d6b-4feb-8f8c-3a3b511a6385@protonmail.com \
    --to=guix-patches@gnu.org \
    --cc=69251@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    --cc=skyvine@protonmail.com \
    --cc=wz@freeshell.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.