From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mDJ4CJqN0mVXWgEA62LTzQ:P1 (envelope-from ) for ; Mon, 19 Feb 2024 00:07:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mDJ4CJqN0mVXWgEA62LTzQ (envelope-from ) for ; Mon, 19 Feb 2024 00:07:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=TS7o6fhg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708297626; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7VOjlIfm2nuqkddd9tHfdSoycCCM8yUt5nseDEmvzKk=; b=XklTmS8RYqnuJzcayv0sjyrtsVvoPBA8EvJIZW6VrxeQW0d/jxVp9F+r+PrMZq95+Vh+p+ +hkq0aAvNtX9iUmtYhgjXF2ZzFBDiVZOYw8/rOAkVywrshzDN6lEueqdBJktiWfkZz1H9O 53bwkGM9RDP99wsMXS/v/RiHchk9vbLU30TeWwwSTIpeSOtYcUYk0YWw16QJYjl6DmIwz6 qsExJalACVggSqPTLc34N9cVg4j+adT5HPq1CPWKSZLJ+IFb5fgHBNNm/GT5YuNKakOvfF +rYjjbR+XXON4SIRxq7L10qHd6OKf1vqX0KH6y5jtv6h/hlIYOthZi+F7PMUaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=TS7o6fhg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708297626; a=rsa-sha256; cv=none; b=tcn3zczNHgj9pQC+SIoX5favC25olNqLEbo1rWXqsgSyhYya2K6Z7ZTccvygQIeQuqinPD V5UHHzIkG/oq2gbfStchk6ygNV5aAM+i6LzcrDLzh56Yk97QkSO5oCmYKTy25XbuNMM5OG p4+uejGSX81bPynxRqhmOIQw8EVHci/YTM+eCPounBK+cKcrK1EczChWRdjymqkB1srOdz 8WtSn6rTYXkH9vlbknCMBd5+vFjHJF3BIUQ9RZSkQ5QUTlEIx7cZ0LStwYm87Q7NTvqNnW AoLs1WCn0ZFo+exo4OnyozwYScZmC9dUfxaEi45E/q/t9FqZVXy+qBUqp+AsqA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D56C705E7 for ; Mon, 19 Feb 2024 00:07:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbqFJ-0005cT-Ni; Sun, 18 Feb 2024 18:06:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbqF8-0005Wg-MI for guix-patches@gnu.org; Sun, 18 Feb 2024 18:06:44 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbqF8-0001W1-0Q for guix-patches@gnu.org; Sun, 18 Feb 2024 18:06:42 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rbqFS-0001jN-CI for guix-patches@gnu.org; Sun, 18 Feb 2024 18:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69251] [PATCH] gnu: Add r-abbreviate. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Feb 2024 23:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69251 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Wiktor =?UTF-8?Q?=C5=BBelazny?= , 69251@debbugs.gnu.org Cc: Ricardo Wurmus Received: via spool by 69251-submit@debbugs.gnu.org id=B69251.17082975916612 (code B ref 69251); Sun, 18 Feb 2024 23:07:02 +0000 Received: (at 69251) by debbugs.gnu.org; 18 Feb 2024 23:06:31 +0000 Received: from localhost ([127.0.0.1]:39939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqEw-0001ia-VS for submit@debbugs.gnu.org; Sun, 18 Feb 2024 18:06:31 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:57939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqEu-0001iL-KK for 69251@debbugs.gnu.org; Sun, 18 Feb 2024 18:06:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1708297561; x=1708556761; bh=7VOjlIfm2nuqkddd9tHfdSoycCCM8yUt5nseDEmvzKk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=TS7o6fhgaB7v1BQthydNxX2bV1Wm4mEbQCZE9SzkIoQaBW9qKhbQ8wo+GuKzF2TCm 6xptZW3Kg7nr0LZzjobVB7dgj3K8y9eplI07xmfWPLuSRbpr8C9ANbDvOH9PTJgmnl 6MwiY+0o/lOO1DQYMlVknMxK059dYMw549Xg2TFkVeRWGD9WqtKOPBby3h7cPEcoi0 8tBc7MXSm1D86u/FbYIB8xKnsjUrqzUEtZtl82cfUyv7mB/p1+U+aT5HdDUnpVS5hp dgAFm7WmkLQllZoITxlrZtbLZ7KNFjBbWVfNIKHghKZUl/V2/Hv30P9LV/bHhhfzJG vQCSyNBak6uPw== Date: Sun, 18 Feb 2024 23:05:46 +0000 Message-ID: <1f1e5f47-7d6b-4feb-8f8c-3a3b511a6385@protonmail.com> In-Reply-To: References: Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -4.38 X-Spam-Score: -4.38 X-Migadu-Queue-Id: 3D56C705E7 X-TUID: BX6DV0Zg0pK7 Hi Wiktor, Thanks for submitting this patch! I'm adding some review notes to this=20 thread in hopes that whichever committer looks at this patch will be=20 able to process it more efficiently. It looks clean to me overall. I did=20 mark "Project is maintained" as "Attention" more as an indication to the=20 committer than to you. I think this is fine but it seems abnormal to me,=20 although I am new to reviewing patches so maybe it is more normal than I=20 think. =3D) If you have any additional context to add I am sure it will be= =20 appreciated! I will send detailed notes about this and everything else I=20 looked at in a separate email. I welcome any feedback you have about my=20 review process. Regards, Skyler