* bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode.
@ 2017-04-27 10:25 Arun Isaac
2017-04-29 14:10 ` Alex Kost
2017-05-01 14:08 ` bug#26678: [PATCH] gnu: Add emacs-gnuplot Arun Isaac
0 siblings, 2 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-27 10:25 UTC (permalink / raw)
To: 26678
* gnu/packages/emacs.scm (emacs-gnuplot-mode): New variable.
---
gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 14d851184..b5307f56a 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4519,3 +4519,33 @@ It should enable you to implement low-level X11 applications.")
(description "EXWM is a full-featured tiling X window manager for Emacs
built on top of XELB.")
(license license:gpl3+)))
+
+(define-public emacs-gnuplot-mode
+ (package
+ (name "emacs-gnuplot-mode")
+ (version "0.7.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/bruceravel/gnuplot-mode/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0glzymrn138lwig7p4cj17x4if5jisr6l4g6wcbxisqkqgc1h01i"))))
+ (build-system gnu-build-system)
+ (native-inputs `(("emacs" ,emacs-minimal)))
+ (arguments
+ `(#:configure-flags
+ (list (string-append "EMACS=" (assoc-ref %build-inputs "emacs")
+ "/bin/emacs")
+ (string-append "--with-lispdir="
+ (assoc-ref %outputs "out")
+ "/share/emacs/site-lisp/guix.d/gnuplot-mode-"
+ ,version))))
+ (home-page "https://github.com/bruceravel/gnuplot-mode")
+ (synopsis "Emacs major mode for interacting with gnuplot")
+ (description "@code{emacs-gnuplot-mode} is an emacs major mode for
+interacting with gnuplot.")
+ (license license:gpl2+)))
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode.
2017-04-27 10:25 bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode Arun Isaac
@ 2017-04-29 14:10 ` Alex Kost
2017-05-01 14:13 ` Arun Isaac
2017-05-01 14:08 ` bug#26678: [PATCH] gnu: Add emacs-gnuplot Arun Isaac
1 sibling, 1 reply; 6+ messages in thread
From: Alex Kost @ 2017-04-29 14:10 UTC (permalink / raw)
To: Arun Isaac; +Cc: 26678
Arun Isaac (2017-04-27 15:55 +0530) wrote:
> * gnu/packages/emacs.scm (emacs-gnuplot-mode): New variable.
> ---
> gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
Thanks! The patch looks good to me, the only thing: it would be good to
generate "…-autoloads.el" file (see below) to make "M-x gnuplot-mode"
available right away, otherwise a user has to adjust ".emacs" to
autoload it.
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 14d851184..b5307f56a 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -4519,3 +4519,33 @@ It should enable you to implement low-level X11 applications.")
> (description "EXWM is a full-featured tiling X window manager for Emacs
> built on top of XELB.")
> (license license:gpl3+)))
> +
> +(define-public emacs-gnuplot-mode
> + (package
> + (name "emacs-gnuplot-mode")
BTW this package is called "gnuplot" on MELPA, because there is another
"gnuplot-mode" (also available on MELPA):
https://github.com/mkmcc/gnuplot-mode
Perhaps we should stick to the MELPA names, otherwise it may be
confusing if we call this package "gnuplot-mode", WDYT?
> + (version "0.7.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/bruceravel/gnuplot-mode/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0glzymrn138lwig7p4cj17x4if5jisr6l4g6wcbxisqkqgc1h01i"))))
> + (build-system gnu-build-system)
> + (native-inputs `(("emacs" ,emacs-minimal)))
> + (arguments
> + `(#:configure-flags
> + (list (string-append "EMACS=" (assoc-ref %build-inputs "emacs")
> + "/bin/emacs")
> + (string-append "--with-lispdir="
> + (assoc-ref %outputs "out")
> + "/share/emacs/site-lisp/guix.d/gnuplot-mode-"
> + ,version))))
To generate "autoloads.el", the 'arguments' could be written like this:
(arguments
(let ((elisp-dir (string-append "/share/emacs/site-lisp/guix.d"
"/gnuplot-mode-" version)))
`(#:modules ((guix build gnu-build-system)
(guix build utils)
(guix build emacs-utils))
#:imported-modules (,@%gnu-build-system-modules
(guix build emacs-utils))
#:configure-flags
(list (string-append "EMACS=" (assoc-ref %build-inputs "emacs")
"/bin/emacs")
(string-append "--with-lispdir=" %output ,elisp-dir))
#:phases
(modify-phases %standard-phases
(add-after 'install 'generate-autoloads
(lambda* (#:key outputs #:allow-other-keys)
(emacs-generate-autoloads
"gnuplot"
(string-append (assoc-ref outputs "out") ,elisp-dir))
#t))))))
> + (home-page "https://github.com/bruceravel/gnuplot-mode")
> + (synopsis "Emacs major mode for interacting with gnuplot")
> + (description "@code{emacs-gnuplot-mode} is an emacs major mode for
> +interacting with gnuplot.")
> + (license license:gpl2+)))
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26678: [PATCH] gnu: Add emacs-gnuplot.
2017-04-27 10:25 bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode Arun Isaac
2017-04-29 14:10 ` Alex Kost
@ 2017-05-01 14:08 ` Arun Isaac
1 sibling, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-05-01 14:08 UTC (permalink / raw)
To: 26678
* gnu/packages/emacs.scm (emacs-gnuplot): New variable.
---
gnu/packages/emacs.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 4d524ece7..2484fac9c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4519,3 +4519,45 @@ It should enable you to implement low-level X11 applications.")
(description "EXWM is a full-featured tiling X window manager for Emacs
built on top of XELB.")
(license license:gpl3+)))
+
+(define-public emacs-gnuplot
+ (package
+ (name "emacs-gnuplot")
+ (version "0.7.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/bruceravel/gnuplot-mode/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0glzymrn138lwig7p4cj17x4if5jisr6l4g6wcbxisqkqgc1h01i"))))
+ (build-system gnu-build-system)
+ (native-inputs `(("emacs" ,emacs-minimal)))
+ (arguments
+ (let ((elisp-dir (string-append "/share/emacs/site-lisp/guix.d"
+ "/gnuplot-" version)))
+ `(#:modules ((guix build gnu-build-system)
+ (guix build utils)
+ (guix build emacs-utils))
+ #:imported-modules (,@%gnu-build-system-modules
+ (guix build emacs-utils))
+ #:configure-flags
+ (list (string-append "EMACS=" (assoc-ref %build-inputs "emacs")
+ "/bin/emacs")
+ (string-append "--with-lispdir=" %output ,elisp-dir))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'generate-autoloads
+ (lambda* (#:key outputs #:allow-other-keys)
+ (emacs-generate-autoloads
+ "gnuplot"
+ (string-append (assoc-ref outputs "out") ,elisp-dir))
+ #t))))))
+ (home-page "https://github.com/bruceravel/gnuplot-mode")
+ (synopsis "Emacs major mode for interacting with gnuplot")
+ (description "@code{emacs-gnuplot} is an emacs major mode for interacting
+with gnuplot.")
+ (license license:gpl2+)))
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode.
2017-04-29 14:10 ` Alex Kost
@ 2017-05-01 14:13 ` Arun Isaac
2017-05-02 9:17 ` Alex Kost
0 siblings, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-05-01 14:13 UTC (permalink / raw)
To: 26678
I have made all suggested changes. WDYT?
Sorry for the rather late reply. I was travelling over the weekend.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode.
2017-05-01 14:13 ` Arun Isaac
@ 2017-05-02 9:17 ` Alex Kost
2017-05-03 19:26 ` Arun Isaac
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2017-05-02 9:17 UTC (permalink / raw)
To: Arun Isaac; +Cc: 26678
Arun Isaac (2017-05-01 19:43 +0530) wrote:
> I have made all suggested changes. WDYT?
I think this patch is ready now, thank you!
> Sorry for the rather late reply. I was travelling over the weekend.
No problem, my replies are always late :-)
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode.
2017-05-02 9:17 ` Alex Kost
@ 2017-05-03 19:26 ` Arun Isaac
0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-05-03 19:26 UTC (permalink / raw)
To: 26678-done
Pushed!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-03 19:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 10:25 bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode Arun Isaac
2017-04-29 14:10 ` Alex Kost
2017-05-01 14:13 ` Arun Isaac
2017-05-02 9:17 ` Alex Kost
2017-05-03 19:26 ` Arun Isaac
2017-05-01 14:08 ` bug#26678: [PATCH] gnu: Add emacs-gnuplot Arun Isaac
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.