From: nee <nee@cock.li>
To: Christopher Baines <mail@cbaines.net>
Cc: 28769@debbugs.gnu.org
Subject: [bug#28769] [PATCH] gnu: services: Add php-fpm.
Date: Mon, 11 Dec 2017 19:19:10 +0100 [thread overview]
Message-ID: <0c7cab39-a15e-c8cf-36f5-f6d60d2ba59e@cock.li> (raw)
In-Reply-To: <874loz7dw7.fsf@cbaines.net>
Am 09.12.2017 um 23:08 schrieb Christopher Baines:
> I've attached some changes that I thought would be good when I was
> looking through this. To give a rough summary:
>
> - Minor improvements to the docs, either content, markup or formatting.
> - Removing trailing whitespace.
> - Removing the changes to the nginx-service, in favour of changing the
> default socket group.
> - Change some indentation to avoid long lines.
>
> By changing the default socket group, the system test passes, even
> without the changes to the nginx service. I think this is a bit better,
> and while it's definately not perfect, I think it would be ok to merge
> with this change.
>
Looks all good to me. Thanks for all these style fixes.
> To also try and move the first patch forward, I've submitted that within
> #29629, with an additional patch to get other services using
> version-major.
>
Thanks, good to see it used at some other spots already.
> It would be good to get your thoughts on the changes in the attached
> patch, and then if you could send an updated set of patches, that would
> be great. As far as I remember, the changes to the nginx service were
> the only thing I felt needed addressing before merging this.
The changes look good to me.
I have no edits to add, imo the patches can be squashed merged.
next prev parent reply other threads:[~2017-12-11 18:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 21:54 [bug#28769] [PATCH] gnu: services: Add php-fpm nee
2017-10-13 20:06 ` Christopher Baines
2017-10-13 20:09 ` Christopher Baines
2017-10-13 21:37 ` Christopher Baines
2017-10-16 21:38 ` nee
2017-10-23 22:26 ` nee
2017-11-02 8:16 ` Christopher Baines
2017-11-02 19:17 ` Christopher Baines
2017-11-23 20:11 ` nee
2017-12-09 22:08 ` Christopher Baines
2017-12-11 18:19 ` nee [this message]
2017-12-12 21:41 ` bug#28769: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7cab39-a15e-c8cf-36f5-f6d60d2ba59e@cock.li \
--to=nee@cock.li \
--cc=28769@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.