From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOSgP-0000NL-K7 for guix-patches@gnu.org; Mon, 11 Dec 2017 13:20:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOSgM-0005d4-Cp for guix-patches@gnu.org; Mon, 11 Dec 2017 13:20:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48513) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOSgM-0005cH-4m for guix-patches@gnu.org; Mon, 11 Dec 2017 13:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOSgL-0001h4-Nr for guix-patches@gnu.org; Mon, 11 Dec 2017 13:20:01 -0500 Subject: [bug#28769] [PATCH] gnu: services: Add php-fpm. Resent-Message-ID: References: <9fe1701f-d78f-ba3a-37eb-64417337a55b@cock.li> <20171013223729.2605f33c@cbaines.net> <7462cec0-7d33-f2a3-1bd7-92454d690b0b@cock.li> <20171102191708.0cf85810@cbaines.net> <145a6af6-bf20-c6e3-f314-009a17239f89@cock.li> <874loz7dw7.fsf@cbaines.net> From: nee Message-ID: <0c7cab39-a15e-c8cf-36f5-f6d60d2ba59e@cock.li> Date: Mon, 11 Dec 2017 19:19:10 +0100 MIME-Version: 1.0 In-Reply-To: <874loz7dw7.fsf@cbaines.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 28769@debbugs.gnu.org Am 09.12.2017 um 23:08 schrieb Christopher Baines: > I've attached some changes that I thought would be good when I was > looking through this. To give a rough summary: > > - Minor improvements to the docs, either content, markup or formatting. > - Removing trailing whitespace. > - Removing the changes to the nginx-service, in favour of changing the > default socket group. > - Change some indentation to avoid long lines. > > By changing the default socket group, the system test passes, even > without the changes to the nginx service. I think this is a bit better, > and while it's definately not perfect, I think it would be ok to merge > with this change. > Looks all good to me. Thanks for all these style fixes. > To also try and move the first patch forward, I've submitted that within > #29629, with an additional patch to get other services using > version-major. > Thanks, good to see it used at some other spots already. > It would be good to get your thoughts on the changes in the attached > patch, and then if you could send an updated set of patches, that would > be great. As far as I remember, the changes to the nginx service were > the only thing I felt needed addressing before merging this. The changes look good to me. I have no edits to add, imo the patches can be squashed merged.