From: Vinicius Monego <monego@posteo.net>
To: Foo Chuan Wei <chuanwei.foo@hotmail.com>, 51623@debbugs.gnu.org
Subject: [bug#51623] [PATCH] gnu: Add python-ta-lib.
Date: Thu, 11 Nov 2021 06:07:37 +0000 [thread overview]
Message-ID: <0ae59f6cb16c18b95b376f6932612e6340488273.camel@posteo.net> (raw)
In-Reply-To: <PU1PR01MB21556915809A1BB4BA12ED128D8F9@PU1PR01MB2155.apcprd01.prod.exchangelabs.com>
Hi,
Em sáb, 2021-11-06 às 04:30 +0000, Foo Chuan Wei escreveu:
> * gnu/packages/python-xyz.scm (python-ta-lib): New variable.
Thanks for your contribution. Patch looks good overall, I have only a
few nitpicks.
> ---
> gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
IMO this package would make more sense in finance.scm.
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> xyz.scm
> index 8ba72170c0..e2e51db25f 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -111,6 +111,7 @@
> ;;; Copyright © 2021 Felix Gruber <felgru@posteo.net>
> ;;; Copyright © 2021 Sébastien Lerique <sl@eauchat.org>
> ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
> +;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo@hotmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -146,6 +147,7 @@
> #:use-module (gnu packages docker)
> #:use-module (gnu packages enchant)
> #:use-module (gnu packages file)
> + #:use-module (gnu packages finance)
> #:use-module (gnu packages fontutils)
> #:use-module (gnu packages gcc)
> #:use-module (gnu packages geo)
> @@ -27684,3 +27686,29 @@ simple mock/record and a complete
> capture/replay framework.")
> "Ijson is an iterative JSON parser with standard Python
> iterator
> interfaces.")
> (license license:bsd-3)))
> +
> +(define-public python-ta-lib
> + (package
> + (name "python-ta-lib")
> + (version "0.4.21")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "TA-Lib" version))
> + (sha256
> + (base32
> "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
> + (build-system python-build-system)
> + (inputs
> + `(("ta-lib" ,ta-lib)))
> + (propagated-inputs
> + `(("python-numpy" ,python-numpy)))
Description says it's based on Cython, so python-cython should be a
native input.
> + (native-inputs
> + `(("python-nose" ,python-nose)
> + ("python-pandas" ,python-pandas)))
> + (home-page "https://github.com/mrjbq7/ta-lib")
> + (synopsis "Python wrapper for TA-Lib")
There's one extra space in the description. The double quote should be
aligned with the "d" in description.
The description must also be a full sentence. It can be "This package
provides a [...]" or something along these lines.
> + (description
> + "Python wrapper for TA-Lib based on Cython. TA-Lib is a
> library
> +providing common functions for the technical analysis of financial
> market
> +data.")
> + (license license:bsd-2)))
It is also recommended to declare packages somewhere in the middle, not
at the end of the file, to avoid merge conflicts.
>
> base-commit: c55a64cb7e82e88e26c26995f983fc9675b6276e
Vinicius
next prev parent reply other threads:[~2021-11-11 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 4:30 [bug#51623] [PATCH] gnu: Add python-ta-lib Foo Chuan Wei
2021-11-11 6:07 ` Vinicius Monego [this message]
2021-11-15 5:25 ` [bug#51623] [PATCH v2] " Foo Chuan Wei
2021-11-15 16:54 ` bug#51623: " Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ae59f6cb16c18b95b376f6932612e6340488273.camel@posteo.net \
--to=monego@posteo.net \
--cc=51623@debbugs.gnu.org \
--cc=chuanwei.foo@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.