From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id niHqKIK2jGGPPAEAgWs5BA (envelope-from ) for ; Thu, 11 Nov 2021 07:21:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oAoOJIK2jGEhSgAA1q6Kng (envelope-from ) for ; Thu, 11 Nov 2021 06:21:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23B212F56B for ; Thu, 11 Nov 2021 07:21:54 +0100 (CET) Received: from localhost ([::1]:54184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml3T6-00071A-UT for larch@yhetil.org; Thu, 11 Nov 2021 01:21:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml3Fj-0002QD-SD for guix-patches@gnu.org; Thu, 11 Nov 2021 01:08:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml3Fi-0004MU-Qw for guix-patches@gnu.org; Thu, 11 Nov 2021 01:08:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ml3Fi-0001Gr-FT for guix-patches@gnu.org; Thu, 11 Nov 2021 01:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51623] [PATCH] gnu: Add python-ta-lib. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Nov 2021 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51623 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Foo Chuan Wei , 51623@debbugs.gnu.org Received: via spool by 51623-submit@debbugs.gnu.org id=B51623.16366108784873 (code B ref 51623); Thu, 11 Nov 2021 06:08:02 +0000 Received: (at 51623) by debbugs.gnu.org; 11 Nov 2021 06:07:58 +0000 Received: from localhost ([127.0.0.1]:39927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml3Fd-0001GX-Id for submit@debbugs.gnu.org; Thu, 11 Nov 2021 01:07:57 -0500 Received: from mout01.posteo.de ([185.67.36.65]:42409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml3Fb-0001GG-6N for 51623@debbugs.gnu.org; Thu, 11 Nov 2021 01:07:56 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id D89E4240027 for <51623@debbugs.gnu.org>; Thu, 11 Nov 2021 07:07:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1636610868; bh=FHWLzhWrKbfT8b5nSOt3VaC4jjbFAnhTkJCT7FPmwrw=; h=Subject:From:To:Date:From; b=idH4EbBTciUKknpMcbGwgf/v579thaNSDMI3NyWoCAksoNf+OYBFH0xJBjxlnefuK XT1dSItG6bDoK1Z99PILX/A/kbHdm19NGUozrlGAXlenVcDB3lvKuiPXeNSmnu6qEY Yoe+HE91nj7c8Vgek7Cnl82hFWJyuUZTJEiObMd6PFS/iLLKXWba3My7XGF8tuK2ob brWhThYMeYthcnyU7Jy0C0YfeCvGw+/rEYusHl138AyC2xgSzVjlgfSjZeOmPcPN6c HpbnxDkXFswhMI8RDsHXD4iRIJuSgQyPYW3KMf2qVURi7wZsyLPuTYnY+rlZIIezzU RvDnTHB24pfTw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HqWTv146Cz9rxK; Thu, 11 Nov 2021 07:07:46 +0100 (CET) Message-ID: <0ae59f6cb16c18b95b376f6932612e6340488273.camel@posteo.net> From: Vinicius Monego Date: Thu, 11 Nov 2021 06:07:37 +0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636611714; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=48epRwH6mSAE2u9GeK/zCc6fYz4wi3m7Dj3Kn80Y0nY=; b=W5v0VaqUo3WRZHNTCaQAfTMr2OTe2PdSFUr8NcUA11XZZSZxN16W5e1+LES6feIBKq7l8L Z0eDou5D17lTIPxg5dMpjPcMbgGvU9XilvzZXDg7APP9KH36zPCb9mcHU8L/q9OjDzmLf8 i5/kkOoct5Sie1v9CLeW6hmvrJ8sG1siMgwvRytAaNKTknZi6htiT9HM/saqm5l4Rjiy9I iuh81RojXakKdc+OgGF8V2T0naXGOa3GcYtakOupqj14iXoMjde1D0zJG7D3RuvzyqLEKn srSehY/qNFzgdquL6kM7qUh1esn2fVMA9i44uamjrSBbSzEjkfrEp1gixZPVxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636611714; a=rsa-sha256; cv=none; b=N/rNfu6euhJnPTmVHdp4DZEekNwXjnqE/djYQwrTHMUkhDFBQMBq591wRJfxRl4OmfSAyM qrNBiC3vbOYX5SNEuIZ6/Ob0qlfXk1KTN+BcPjec63QQeXE4kfYDEHheSenZbQoQCv6H5K x2CDR+LXi1CuIdr+b/z15bwo0rR4UX2KAo4l/qVLH3YxkLLeK5zS+O87zqfBSV66X4adr/ oXXWIT9HAOYH66xcsBj7Z4uJbfKD9pZkElDTfJZad7/kI92jIEnmQKjTkoy8Hmxf/YAKhU ULrFUSCWpfgvhQ5Vhjt7N9Lkqcib3axfZgMVPx5WhA4QGD7ZaTJdvyTtmwOpQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=idH4EbBT; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=idH4EbBT; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 23B212F56B X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6Fm2IBgi+axz Hi, Em sáb, 2021-11-06 às 04:30 +0000, Foo Chuan Wei escreveu: > * gnu/packages/python-xyz.scm (python-ta-lib): New variable. Thanks for your contribution. Patch looks good overall, I have only a few nitpicks. > --- >  gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++ >  1 file changed, 28 insertions(+) > IMO this package would make more sense in finance.scm. > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python- > xyz.scm > index 8ba72170c0..e2e51db25f 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -111,6 +111,7 @@ >  ;;; Copyright © 2021 Felix Gruber >  ;;; Copyright © 2021 Sébastien Lerique >  ;;; Copyright © 2021 Raphaël Mélotte > +;;; Copyright © 2021 Foo Chuan Wei >  ;;; >  ;;; This file is part of GNU Guix. >  ;;; > @@ -146,6 +147,7 @@ >    #:use-module (gnu packages docker) >    #:use-module (gnu packages enchant) >    #:use-module (gnu packages file) > +  #:use-module (gnu packages finance) >    #:use-module (gnu packages fontutils) >    #:use-module (gnu packages gcc) >    #:use-module (gnu packages geo) > @@ -27684,3 +27686,29 @@ simple mock/record and a complete > capture/replay framework.") >       "Ijson is an iterative JSON parser with standard Python > iterator >  interfaces.") >      (license license:bsd-3))) > + > +(define-public python-ta-lib > +  (package > +    (name "python-ta-lib") > +    (version "0.4.21") > +    (source > +     (origin > +       (method url-fetch) > +       (uri (pypi-uri "TA-Lib" version)) > +       (sha256 > +        (base32 > "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl")))) > +    (build-system python-build-system) > +    (inputs > +     `(("ta-lib" ,ta-lib))) > +    (propagated-inputs > +     `(("python-numpy" ,python-numpy))) Description says it's based on Cython, so python-cython should be a native input. > +    (native-inputs > +     `(("python-nose" ,python-nose) > +       ("python-pandas" ,python-pandas))) > +    (home-page "https://github.com/mrjbq7/ta-lib") > +    (synopsis "Python wrapper for TA-Lib") There's one extra space in the description. The double quote should be aligned with the "d" in description. The description must also be a full sentence. It can be "This package provides a [...]" or something along these lines. > +    (description > +      "Python wrapper for TA-Lib based on Cython.  TA-Lib is a > library > +providing common functions for the technical analysis of financial > market > +data.") > +    (license license:bsd-2))) It is also recommended to declare packages somewhere in the middle, not at the end of the file, to avoid merge conflicts. > > base-commit: c55a64cb7e82e88e26c26995f983fc9675b6276e Vinicius