From: Maxime Devos <maximedevos@telenet.be>
To: "Dr. Arne Babenhauserheide" <arne_bab@web.de>, 58299@debbugs.gnu.org
Subject: bug#58299: [patch] add gst-plugins-base-gl (gst-plugins with opengl support)
Date: Thu, 6 Oct 2022 10:05:10 +0200 [thread overview]
Message-ID: <084d5707-c0c5-7ba2-c350-ebd2eb290ba0@telenet.be> (raw)
In-Reply-To: <87fsg2ad5y.fsf@web.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 1587 bytes --]
On 05-10-2022 10:25, Dr. Arne Babenhauserheide wrote:
> Hi,
>
> the following patch adds a base gstreamer plugins package with opengl support:
Not sure how I received this, as I unsubscribed from guix-patches, but a
note:
IIUC, you are enabling extra plugins -- so gst-plugins-base-gl also
contains the non-gl plugins.
Take some non-gl plugin 'foo', of which there is a copy in both
gst-plugins-base-gl and gst-plugins-base.
This can potentially lead to a situation where an application loads two
copies of foo into the same process (of gst-plugins-base and
gst-plugins-base-gl). This can lead to bugs, see e.g.
<https://issues.guix.gnu.org/47115#22>.
I don't know if gst stuff cares (and maybe gst refuses to load plugins
it already has loaded), but it is potentially risky.
To avoid this, I propose to let gst-plugins-base-gl _only_ contain
plugins that use gl.
> + `(("mesa" ,mesa) ;; required for libgstgl
Maybe my local Guix is out-of-date, but mesa is already in
gst-plugin-base's inputs. If it's actually unused by gst-plugin-base, I
suppose it could be removed on core-updates, to avoid the large mesa.
> + (inputs
> + (modify-inputs (package-inputs gst-plugins-base)
> + (append mesa))) ;; required for libgstgl
I recommend 'prepend' instead of 'append' for being a tiny bit faster
(prepend doesn't need to iterate through the old input list).
Also, a modified description and synopsis, to help users deciding
between gst-plugins-base, gst-plugins-base-gl or both.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2022-10-06 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 8:25 bug#58299: [patch] add gst-plugins-base-gl (gst-plugins with opengl support) Dr. Arne Babenhauserheide
2022-10-05 9:58 ` Liliana Marie Prikler
2022-10-05 16:04 ` Dr. Arne Babenhauserheide
2022-10-06 8:05 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084d5707-c0c5-7ba2-c350-ebd2eb290ba0@telenet.be \
--to=maximedevos@telenet.be \
--cc=58299@debbugs.gnu.org \
--cc=arne_bab@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.