From: Maxime Devos <maximedevos@telenet.be>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: 49933@debbugs.gnu.org
Subject: [bug#49933] [PATCH core-updates-frozen] gnu: util-linux: Disable unreliable ioctl_ns test
Date: Sun, 08 Aug 2021 11:06:42 +0200 [thread overview]
Message-ID: <073f4c2a0ec6bae374e65dd3abb8fdba2e94d749.camel@telenet.be> (raw)
In-Reply-To: <74088102.xUv88IJzmX@popigai>
[-- Attachment #1.1: Type: text/plain, Size: 594 bytes --]
Hi,
> Thanks! I can confirm this behavior also happens on my machine, running
> Guix on a foreign distro (Ubuntu, with kernel 5.11.0-25-generic). I ran
> into the problem while trying to build ‘bootstrap-tarballs’, and with
> your patch it works.
>
> Just one suggestion: what about only deleting the problematic test if
> ‘%current-system’ is "i686-linux"?
Maybe it's required on other arches as well (32-bit arches that have a
64-bit counterpart maybe?), but that seems reasonable (more arches
can be added later). A revised patch is attached.
Greetings,
Maxime.
[-- Attachment #1.2: 0001-gnu-util-linux-Disable-unreliable-ioctl_ns-test-on-I.patch --]
[-- Type: text/x-patch, Size: 2088 bytes --]
From ba4be4629773633ea873db824ff0743a5d0dda8a Mon Sep 17 00:00:00 2001
From: Maxime Devos <maximedevos@telenet.be>
Date: Sat, 7 Aug 2021 23:41:10 +0200
Subject: [PATCH core-updates-frozen v2] gnu: util-linux: Disable unreliable
ioctl_ns test on IA-32.
* gnu/packages/linux.scm
(util-linux)[arguments]<#:phases>{delete-lsns-test}: New phase.
---
gnu/packages/linux.scm | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index a5fd8ddaee..5690b81bf1 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -53,6 +53,7 @@
;;; Copyright © 2020 pukkamustard <pukkamustard@posteo.net>
;;; Copyright © 2021 B. Wilson <elaexuotee@wilsonb.com>
;;; Copyright © 2021 Ivan Gankevich <i.gankevich@spbu.ru>
+;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1804,6 +1805,16 @@ providing the system administrator with some help in common tasks.")
(string-append
all "\n"
"ts_skip \"setarch tests are unreliable under QEMU\"")))))
+ ,@(if (target-x86-32?)
+ `((add-before 'check 'disable-lsns-test
+ (lambda _
+ ;; The lsns tests can fail due to ioctl(_, NS_GET_USERNS)
+ ;; returning ENOTTY, indicating this kernel does not
+ ;; support user namespaces. Curiously, this test can fail
+ ;; on i686 even if the same test passes on x86_64 on the
+ ;; same machine. See <https://issues.guix.gnu.org/49933>.
+ (delete-file "tests/ts/lsns/ioctl_ns"))))
+ '())
(add-after 'install 'move-static-libraries
(lambda* (#:key outputs #:allow-other-keys)
(let ((lib (assoc-ref outputs "lib"))
base-commit: 944ba4237f4c0ccab1bc62a23a31f577ce1878e5
--
2.32.0
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-08-08 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 21:54 [bug#49933] [PATCH core-updates-frozen] gnu: util-linux: Disable unreliable ioctl_ns test Maxime Devos
2021-08-08 6:27 ` Thiago Jung Bauermann via Guix-patches via
2021-08-08 9:06 ` Maxime Devos [this message]
2021-08-08 10:56 ` Maxime Devos
2021-08-09 16:09 ` Thiago Jung Bauermann via Guix-patches via
2021-08-15 10:16 ` bug#49933: " Mathieu Othacehe
2021-11-09 9:07 ` [bug#49933] " Brendan Tildesley
2021-11-12 0:29 ` Thiago Jung Bauermann via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073f4c2a0ec6bae374e65dd3abb8fdba2e94d749.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=49933@debbugs.gnu.org \
--cc=bauermann@kolabnow.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.