From: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
To: 51548@debbugs.gnu.org
Subject: [bug#51548] [PATCH] services: Create /run and /var/run on activation.
Date: Thu, 4 Nov 2021 18:00:18 +1100 [thread overview]
Message-ID: <02ac6d0b-6229-0b52-6e97-bc5adee0ff37@tom-fitzhenry.me.uk> (raw)
In-Reply-To: <9da03290-b031-fec0-11fe-a3f591b38f61@tom-fitzhenry.me.uk>
Having thought about this patch some more, I think it can be better done.
On 1/11/21 22:39, Tom Fitzhenry wrote:
> ;; thus there is no accounting at all.
> + (mkdir-p "/var/run")
This line will create /var/run if it doesn't exist during activation.
This is safe, but there is already code that creates /var/run :
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/install.scm?id=63c356fe13f0c7cc560a1f9aeec4926422c22137#n120
. This runs on installation.
By adding this line, this responsibility is split across two parts of
the code base: installation and activation. This could cause confusion.
If, as this patch intends, we want to be able to boot from just /boot,
/gnu and /var/guix, perhaps we should move
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/install.scm?id=63c356fe13f0c7cc560a1f9aeec4926422c22137#n120
(and surrounding code) from running at install-time to running at
activation-time.
prev parent reply other threads:[~2021-11-04 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 11:39 [bug#51548] [PATCH] services: Create /run and /var/run on activation Tom Fitzhenry
2021-11-04 7:00 ` Tom Fitzhenry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ac6d0b-6229-0b52-6e97-bc5adee0ff37@tom-fitzhenry.me.uk \
--to=tom@tom-fitzhenry.me.uk \
--cc=51548@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.