From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AB/BGjWFg2HSBgEAgWs5BA (envelope-from ) for ; Thu, 04 Nov 2021 08:01:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WPhmFjWFg2GSUgAAB5/wlQ (envelope-from ) for ; Thu, 04 Nov 2021 07:01:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D0D631293 for ; Thu, 4 Nov 2021 08:01:08 +0100 (CET) Received: from localhost ([::1]:39404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miWkF-00034i-RN for larch@yhetil.org; Thu, 04 Nov 2021 03:01:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miWkA-000332-PP for guix-patches@gnu.org; Thu, 04 Nov 2021 03:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miWkA-0001RM-FJ for guix-patches@gnu.org; Thu, 04 Nov 2021 03:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miWkA-0004gE-DX for guix-patches@gnu.org; Thu, 04 Nov 2021 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51548] [PATCH] services: Create /run and /var/run on activation. Resent-From: Tom Fitzhenry Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Nov 2021 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51548 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51548@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163600924517953 (code B ref -1); Thu, 04 Nov 2021 07:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Nov 2021 07:00:45 +0000 Received: from localhost ([127.0.0.1]:41894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miWjs-0004fU-Rb for submit@debbugs.gnu.org; Thu, 04 Nov 2021 03:00:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:40816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miWjr-0004fN-7C for submit@debbugs.gnu.org; Thu, 04 Nov 2021 03:00:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miWjq-0002pB-Pn for guix-patches@gnu.org; Thu, 04 Nov 2021 03:00:42 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:51397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miWjd-0001IK-H9 for guix-patches@gnu.org; Thu, 04 Nov 2021 03:00:42 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E4DD83200F6F for ; Thu, 4 Nov 2021 03:00:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 04 Nov 2021 03:00:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= tom-fitzhenry.me.uk; h=message-id:date:mime-version:from:to :references:subject:in-reply-to:content-type :content-transfer-encoding; s=fm3; bh=MkgRRp/1jSyADdrVz6M9tSmbHn 4K2qBIgdwOWdUUrig=; b=rZUv3XImthn5Arc+xwiSXt0wIHE2k6yC/Llcyiwp5z /gEMn7hPUwS6NNjbqZFNAW38nEDynC0mEfxGOmxSwYW2JsZHoimEIjsoOL62scLu tcfRo0q44FzWaPb+CVX9Vyz+zeMieul3D2Yp0TXI/saQHlGyhjdcAR2kV8S2QfSp AaoKHMnZD9i9EEtihQiI3bS1gX5+EoI/qtqJL7At/jNPzWwuz677LGkLW8bXcVWv tLeSoTDSDb6e9C4VyrLgnbZwq+scWyicSSwr1Im4txPH9JGUy3M3LCVkJGWMGZnf 3e2sM+Pk/Zv39bw/vaiv3nD8sVAdeIwVLNvHk6uhT2Tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MkgRRp/1jSyADdrVz6M9tSmbHn4K2qBIgdwOWdUUr ig=; b=iNi020Ck++DGM/W0w9WAkfQ72oSTVUJPfqoyKA2JCME1GpPoPivxp/sh8 mvdWsttODQRnC08nd2A+ilCiITWKj3f3oPLudBZLx9hfSDs2IZqgSvtPdKA6cs3n 8NBJUlARO4TiBFTJEY+5AZTJD5cccezcGnMuYxlklTkHozEVo3j6RspeeutQbpn3 UN/lDw4yiWy9njUHFRF6/Qh/uRb8Krj3D2dKHWVRfUp8iQF7BuzKPR7NhtZeN8YZ geH3LsOZqnKUAJMbVtShHBexmSgAUqJMBYMQK4zJWf75EGVbLWTsX6zsRKWUFn9G aGUXcN6r/Y82ouGfcw4A9r48AmylA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdefgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfhffvfhfujggtgfesthekre dttdefjeenucfhrhhomhepvfhomhcuhfhithiihhgvnhhrhicuoehtohhmsehtohhmqdhf ihhtiihhvghnrhihrdhmvgdruhhkqeenucggtffrrghtthgvrhhnpeettdejfeekieehhf egkeeludejieehheethffgudehleevteefheekuedtieffgfenucffohhmrghinhepghhn uhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehtohhmsehtohhmqdhfihhtiihhvghnrhihrdhmvgdruhhk X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 4 Nov 2021 03:00:24 -0400 (EDT) Message-ID: <02ac6d0b-6229-0b52-6e97-bc5adee0ff37@tom-fitzhenry.me.uk> Date: Thu, 4 Nov 2021 18:00:18 +1100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Content-Language: en-US From: Tom Fitzhenry References: <9da03290-b031-fec0-11fe-a3f591b38f61@tom-fitzhenry.me.uk> In-Reply-To: <9da03290-b031-fec0-11fe-a3f591b38f61@tom-fitzhenry.me.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.25; envelope-from=tom@tom-fitzhenry.me.uk; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -55 X-Spam_score: -5.6 X-Spam_bar: ----- X-Spam_report: (-5.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.528, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636009269; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MkgRRp/1jSyADdrVz6M9tSmbHn4K2qBIgdwOWdUUrig=; b=gDHQX0VVfkbSEbsHoB/rfbOAo23gAGFJz/xZX8E+cKZtznms6PaGTZr8hWvtO5bI+6k/ky GOWfbIAG6E6cPXQRQltuVRmaQaoM45jCrf/ltyjqPqEXlVKxRwOs4mCnwcH6i4kekVp6hg QVqRI8KNqWKznuBtysY+NlXMsjkpwzp+myNbPwiyTHjkKaQt39/wrs+Ky+4mp7Sa6235J6 PuWIoLPWO5Jg37nCBwi6A66tLFdJMmXf0HVuWm/Mi0864iIXMPGeDSLVXO39yU1Vp+Atf8 TbHdvexbtTsZdI30KMI6BTPCU8oqexYqQBcJcb5mslXvRsO7tDCHYt3fASyRbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636009269; a=rsa-sha256; cv=none; b=GHjJRszt72s95fsJ16ieEQM9uOIIBsZEHJHXq/5S1pFDOZrADMSAVBzP0EWxlYdqiUwN7y 2j/cmwNeL7+enkvsVOnM86JYnklA4z1e+ZDctGhnH30IkiYC01le0BG7upk8QOh3Th26kf kEtsSByX/+N3C+0cHQQk3MEFLyhr8wUIjxaL/VI5AoJjIR3HH93PQw6xt6yW2wLkpRZ5B/ w2anR6oLu0URexxhItlMQKymXjuvg04/g5fztc/ICxjR+rl+L/Lmw+LRhjcOhPyLO7ribc fjMp8PVRlTURcOP82eWTCgku2IvOcSvAlmzWW2CyTCPh2yfIusabxX+fqzFfmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tom-fitzhenry.me.uk header.s=fm3 header.b=rZUv3XIm; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=iNi020Ck; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tom-fitzhenry.me.uk (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tom-fitzhenry.me.uk header.s=fm3 header.b=rZUv3XIm; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=iNi020Ck; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tom-fitzhenry.me.uk (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1D0D631293 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: URZrYnvkfH+2 Having thought about this patch some more, I think it can be better done. On 1/11/21 22:39, Tom Fitzhenry wrote: >                        ;; thus there is no accounting at all. > +                      (mkdir-p "/var/run") This line will create /var/run if it doesn't exist during activation. This is safe, but there is already code that creates /var/run : https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/install.scm?id=63c356fe13f0c7cc560a1f9aeec4926422c22137#n120 . This runs on installation. By adding this line, this responsibility is split across two parts of the code base: installation and activation. This could cause confusion. If, as this patch intends, we want to be able to boot from just /boot, /gnu and /var/guix, perhaps we should move https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/install.scm?id=63c356fe13f0c7cc560a1f9aeec4926422c22137#n120 (and surrounding code) from running at install-time to running at activation-time.