From: Adam Faiz via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 60153@debbugs.gnu.org
Subject: [bug#60153] [PATCH v2 1/3] gnu: python-pygame: Update to 2.1.2.
Date: Sat, 24 Dec 2022 21:19:34 +0800 [thread overview]
Message-ID: <00a7606b-9247-c118-8196-2216bc5444b9@disroot.org> (raw)
In-Reply-To: <52d8cb8ba9792d712964f5c6d0a75d4d0d86e250.camel@gmail.com>
On 12/24/22 13:51, Liliana Marie Prikler wrote:
> Am Samstag, dem 24.12.2022 um 07:43 +0800 schrieb Adam Faiz:
>> On 12/24/22 07:20, Adam Faiz wrote:
>>> + (("incdirs = \\[\\]") "incdirs = origincdirs")
>>> + (("libdirs = \\[\\]") "libdirs = origlibdirs"))))
>> I didn't do this kind of thing, because I didn't want to hardcode
>> these.
>> Most systems that pygame supports want to stay with the defaults.
> Here, "using the defaults" equates to having both origincdirs and
> origlibdirs being empty, i.e. expanded from non-existing or empty
> environment variables, right? In that case, the build config will
> still add the default /usr stuff – it just won't start out empty.
Yes, I hadn't considered that when sending the patch.
> I feel as though we could do without this patch by supplying
> PYGAME_EXTRA_BASE as a configure flag. Wouldn't that be better than
> patching?
Indeed, it's better than patching and should be done if it works for
you. I feel it's suboptimal though because the include path doesn't
deserve to be called "extra".
> Cheers
next prev parent reply other threads:[~2022-12-24 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 10:01 [bug#60153] [PATCH] gnu: python-pygame: Update to 2.1.2 Adam Faiz via Guix-patches via
[not found] ` <93aa8b09-cc29-4030-3c76-458158ea0c0f@disroot.org>
2022-12-17 10:52 ` [bug#60153] Fwd: " Liliana Marie Prikler
2022-12-18 14:15 ` Adam Faiz via Guix-patches via
2022-12-18 15:02 ` Liliana Marie Prikler
2022-12-18 15:51 ` [bug#60153] [PATCH v1 1/3] " Adam Faiz via Guix-patches via
2022-12-18 15:54 ` [bug#60153] [PATCH v1 2/3] gnu: python-pygame: Use gexps and new style inputs Adam Faiz via Guix-patches via
2022-12-18 15:57 ` [bug#60153] [PATCH v1 3/3] gnu: python-pygame: Fix description Adam Faiz via Guix-patches via
2022-12-18 15:51 ` [bug#60153] [PATCH v2 1/3] gnu: python-pygame: Update to 2.1.2 Adam Faiz
2022-12-23 23:20 ` Adam Faiz via Guix-patches via
2022-12-23 23:43 ` Adam Faiz via Guix-patches via
2022-12-23 23:54 ` Adam Faiz via Guix-patches via
2022-12-24 5:51 ` Liliana Marie Prikler
2022-12-24 13:19 ` Adam Faiz via Guix-patches via [this message]
2022-12-24 5:39 ` Liliana Marie Prikler
2022-12-18 15:54 ` [bug#60153] [PATCH v2 2/3] gnu: python-pygame: Use G-Expressions and new-style inputs Adam Faiz
2022-12-22 20:45 ` [bug#60153] [PATCH v2 3/3] gnu: python-pygame: Reword description Liliana Marie Prikler
2022-12-22 21:09 ` [bug#60153] [PATCH v2 0/3] Update python-pygame to 2.1.2 Liliana Marie Prikler
2022-12-31 7:34 ` bug#60153: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a7606b-9247-c118-8196-2216bc5444b9@disroot.org \
--to=guix-patches@gnu.org \
--cc=60153@debbugs.gnu.org \
--cc=adam.faiz@disroot.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.