From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4HayCp38pmM9XAAAbAwnHQ (envelope-from ) for ; Sat, 24 Dec 2022 14:20:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mGyMCp38pmMLcgEA9RJhRA (envelope-from ) for ; Sat, 24 Dec 2022 14:20:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8C413F1FF for ; Sat, 24 Dec 2022 14:20:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p94RY-0003oB-NR; Sat, 24 Dec 2022 08:20:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p94RX-0003nw-1C for guix-patches@gnu.org; Sat, 24 Dec 2022 08:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p94RW-0002c3-PX for guix-patches@gnu.org; Sat, 24 Dec 2022 08:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p94RW-00016T-B1 for guix-patches@gnu.org; Sat, 24 Dec 2022 08:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60153] [PATCH v2 1/3] gnu: python-pygame: Update to 2.1.2. Resent-From: Adam Faiz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Dec 2022 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60153 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 60153@debbugs.gnu.org Received: via spool by 60153-submit@debbugs.gnu.org id=B60153.16718879834230 (code B ref 60153); Sat, 24 Dec 2022 13:20:02 +0000 Received: (at 60153) by debbugs.gnu.org; 24 Dec 2022 13:19:43 +0000 Received: from localhost ([127.0.0.1]:42944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p94RC-00016A-OE for submit@debbugs.gnu.org; Sat, 24 Dec 2022 08:19:42 -0500 Received: from knopi.disroot.org ([178.21.23.139]:41330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p94RA-000164-Hg for 60153@debbugs.gnu.org; Sat, 24 Dec 2022 08:19:41 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 20C2B403BC; Sat, 24 Dec 2022 14:19:39 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iNlX3js3YESO; Sat, 24 Dec 2022 14:19:38 +0100 (CET) Message-ID: <00a7606b-9247-c118-8196-2216bc5444b9@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1671887978; bh=MEqQfteOxNWrkyh5GQWejV4JYx0GhWY1VA6uPsfYQwc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=guiRz3J0j1qUU1BvThgUuw7Le+TdGTuukMtcBBsUsyX+J4LVK5ONhijsJbLKW90ma HJ8nSAIZWIkrNPlULjlsG6Q3DaBVftmNVb2Gy0aaavLtODIjZMMbDaVwSFvyU/RZWU nSuosSfuKq1D6hkblf8tf5NFVJRYI5C9BfwAErg8HxiPUdjoJnnGy73rWGlfgI4Rwl SVpIdVvI5JlSLfcu5X72K/FPZKmguuf7lzl8S2tBeJ1fNOTysO0VfC6zZsU2UKATcK qu7jwzjjp/bkysnHPS+BbntdT4r1MtkXkISvxAWUW7cWIzMqjQwh0C3qQoTVxaoBJ7 1PiIpKzL4VO2A== Date: Sat, 24 Dec 2022 21:19:34 +0800 MIME-Version: 1.0 References: <8c518a46ea2d8332ccbb55cb00574b75db982558.camel@disroot.org> <61b652bc-7769-4cc7-43e2-fd08e73313ed@disroot.org> <52d8cb8ba9792d712964f5c6d0a75d4d0d86e250.camel@gmail.com> Content-Language: en-US In-Reply-To: <52d8cb8ba9792d712964f5c6d0a75d4d0d86e250.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adam Faiz X-ACL-Warn: , Adam Faiz via Guix-patches From: Adam Faiz via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671888029; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=44+urTXEBEiLLS5MZExSV20j0aU6rdnbHIR6Gv8VXaM=; b=Thc34JT4zNCXScuRhq+d5GER/nlMzFElhXoL98ebsMC6UhoF/8p0mdyX50j9GHWEJcqQKZ HLGgfXlFJrJjTeknSQS+3XKrfyxf5Xgre7NLLF8RnzUfxsVg/X0iHymk2uJq5PEphpO9OI keMLZY3uf5uc+Lf6gjlaTQhWNohgfnubV3YFD7B+s3hpD2VKmMlU10Nwsh0gwwbkAkiOAp Mr1V23/5vNyoRsquZgrJkd9MP/mFNhHrqt5yFqF7x4NOGBLZzs7cJmyRDmRkvAdJ7cSJJO UD8FXE12vfj2QVHqlMBMCbBjvY/HBfIK4dOz9kWvurpZ97Gb4MmDEUXRdOhVuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=guiRz3J0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671888029; a=rsa-sha256; cv=none; b=WbZMXo/RrgCLzqPk/jno9bACwLyhow+GMrFU4uXxvEoBLGsXDmqMEe/jWCkw8vZaWqJzAl ojeW/3DtA4YbO0QBvsGZuSAkwzbFw1ZTj5lub3ljzqFPPkyN0FFkWvtTeyDGG6AnHjfYfH xHWEqaHrPBqeFUIVzPh9uYodiLZ/0CgG7z0d36T9IHPxZcARxxLnANRIO7jGmgYZYzqvlW mvo/WwcM+auiw6bk2tMNa9lwsg4lhb3jKGkwIDOtDOmC7qGFyMa+/V8D0iJUN3C0ocO1tV 4uPPnk+u9Vdc0Yc0/p7RU3jAihqZC0oYybnz+Pa1N4nvhl/Ms9VvEKJ5yW3YXg== X-Spam-Score: -2.01 X-Migadu-Queue-Id: D8C413F1FF Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=guiRz3J0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.01 X-TUID: VKH4bMIXqyT6 On 12/24/22 13:51, Liliana Marie Prikler wrote: > Am Samstag, dem 24.12.2022 um 07:43 +0800 schrieb Adam Faiz: >> On 12/24/22 07:20, Adam Faiz wrote: >>> +               (("incdirs = \\[\\]") "incdirs = origincdirs") >>> +               (("libdirs = \\[\\]") "libdirs = origlibdirs")))) >> I didn't do this kind of thing, because I didn't want to hardcode >> these. >> Most systems that pygame supports want to stay with the defaults. > Here, "using the defaults" equates to having both origincdirs and > origlibdirs being empty, i.e. expanded from non-existing or empty > environment variables, right? In that case, the build config will > still add the default /usr stuff – it just won't start out empty. Yes, I hadn't considered that when sending the patch. > I feel as though we could do without this patch by supplying > PYGAME_EXTRA_BASE as a configure flag. Wouldn't that be better than > patching? Indeed, it's better than patching and should be done if it works for you. I feel it's suboptimal though because the include path doesn't deserve to be called "extra". > Cheers