unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maya via Guix-patches via <guix-patches@gnu.org>
To: "54953@debbugs.gnu.org" <54953@debbugs.gnu.org>
Subject: [bug#54953] (No Subject)
Date: Mon, 18 Apr 2022 16:28:51 +0000	[thread overview]
Message-ID: <uxnwJ8HF46fjBr59V68T-4EdEVWG3K9VPflRRKOdgLhN-OJNRf7yvDI2t60g7mBZfp6Jaik4tnGTYQ3riLfG7DoV3YgCawur0DAOC4DOMIE=@protonmail.com> (raw)
In-Reply-To: <eOjW4-qn1Zv6eHF0qV0YA8UnOd3rnQqJcuim3jpooWykVlSTjMWtrrtKhMc0ZZ-o1y8J2FMQriORYSN_eGnHN7254U5aQZGXjvRT-VuSppg=@protonmail.com>

> > > Here too I would suggest @code{nano-theme} or this-theme.
> > It sounds better. However does it matter that it now will not match
> > guix package name but match the emacs package name?
> That's fine imo.  IIUC nano-theme would be a feature that you can
> (require), no?
Yes it is a emacs package of that name. You also then load-theme it, so I guess it's fine.

> > > "It is recommended to use a font with programming ligatures, such
> > > as @code{font-google-roboto}".  On that note, does Roboto have
> > > programming ligatures?
> > It sadly does not. But Roboto Mono Nerd is not packaged for guix and
> > I haven't checked the license on their assets yet. I believe that
> > Roboto Mono is recommended as a aesthetic matching font.
> Last time I checked, Nerd fonts were a special kind of mess that's
> difficult to disentangle and more difficult to check licenses on.  I
> wouldn't bother too hard.
It looks like it. I didn't felt comfortable packaging it as it looked like they automatically download copyrighted content.

> Is the recommendation important in your opinion?
There is kind of a problem with that. The nano-theme package also provides a method of setting other not theme-related functionality under the nano-mode function. But that function prints an error if Roboto Mono Nerd isn't present on the system. (but does not fail)

As for the recommendation of the Roboto Mono itself, I don't know. The nano packages are all about aesthetics. And the theme optionally sets faces to Roboto (or Fira Code as a fallback font). Weirdly enough, the code also sets some faces to Victor Mono, but there is no mention of that in the package description.

The longer I'm looking at the code, the weirder it gets. It seems like it's not only a them per-se. But rather a visual style that kind-of breaks the borders of normal emacs theme.

Best,
Maya




      parent reply	other threads:[~2022-04-18 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  9:50 [bug#54953] [PATCH] gnu: Add emacs-nano-theme Maya via Guix-patches via
2022-04-17  8:31 ` Maxime Devos
2022-04-17 18:45 ` Maya via Guix-patches via
2022-04-18  7:37   ` Maxime Devos
2022-04-18  9:36   ` Liliana Marie Prikler
2022-04-18 13:52 ` Maya via Guix-patches via
2022-04-18 16:03   ` Liliana Marie Prikler
2022-04-18 16:28 ` Maya via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='uxnwJ8HF46fjBr59V68T-4EdEVWG3K9VPflRRKOdgLhN-OJNRf7yvDI2t60g7mBZfp6Jaik4tnGTYQ3riLfG7DoV3YgCawur0DAOC4DOMIE=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=54953@debbugs.gnu.org \
    --cc=maya.omase@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).