From: Maya via Guix-patches via <guix-patches@gnu.org>
To: "54953@debbugs.gnu.org" <54953@debbugs.gnu.org>
Subject: [bug#54953] [PATCH] gnu: Add emacs-nano-theme
Date: Mon, 18 Apr 2022 13:52:47 +0000 [thread overview]
Message-ID: <cuaa8n5SXvhDIcAp-l_CMpYCyIeT8yQIq0HdQ1kQNbcgXZ-pmOqUXJ2sn736Jn-we6TdndvERPT7CQMQTlqXKvmPES_uYBKhdP7mjYVoC8I=@protonmail.com> (raw)
In-Reply-To: <eOjW4-qn1Zv6eHF0qV0YA8UnOd3rnQqJcuim3jpooWykVlSTjMWtrrtKhMc0ZZ-o1y8J2FMQriORYSN_eGnHN7254U5aQZGXjvRT-VuSppg=@protonmail.com>
> For the record, this space is for the commit message, which should be
> an explanation if needed (not needed for the addition of a package),
> and a ChangeLog.
Oh I am sorry, I didn't know that.
>You might want to simply write "Emacs theme defined by 7 faces"
I agree. If it is fine that the package now will not agree with upstream.
> I agree with Maxime. Use "Nano Theme", "@code{nano-theme}" or simply
> "This package provides a theme that comes in two flavours". I'm not
> sure whether we should add "consistent" -- it would suggest that other
> themes are inconsistent, which sure some of them might be but most
> don't strive to be.
I wouldn't call it that ("consistent") myself and I do agree that it sounds a bit weird, if it is, again, fine, that it will not agree with upstream, I will change it.
> Here too I would suggest @code{nano-theme} or this-theme.
It sounds better. However does it matter that it now will not match guix package name but match the emacs package name?
> "It is recommended to use a font with programming ligatures, such as
> @code{font-google-roboto}". On that note, does Roboto have programming
> ligatures?
It sadly does not. But Roboto Mono Nerd is not packaged for guix and I haven't checked the license on their assets yet. I believe that Roboto Mono is recommended as a aesthetic matching font.
Best,
Maya.
next prev parent reply other threads:[~2022-04-18 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 9:50 [bug#54953] [PATCH] gnu: Add emacs-nano-theme Maya via Guix-patches via
2022-04-17 8:31 ` Maxime Devos
2022-04-17 18:45 ` Maya via Guix-patches via
2022-04-18 7:37 ` Maxime Devos
2022-04-18 9:36 ` Liliana Marie Prikler
2022-04-18 13:52 ` Maya via Guix-patches via [this message]
2022-04-18 16:03 ` Liliana Marie Prikler
2022-04-18 16:28 ` [bug#54953] (No Subject) Maya via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='cuaa8n5SXvhDIcAp-l_CMpYCyIeT8yQIq0HdQ1kQNbcgXZ-pmOqUXJ2sn736Jn-we6TdndvERPT7CQMQTlqXKvmPES_uYBKhdP7mjYVoC8I=@protonmail.com' \
--to=guix-patches@gnu.org \
--cc=54953@debbugs.gnu.org \
--cc=maya.omase@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).