From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: Leo Famulari <leo@famulari.name>,
"56200@debbugs.gnu.org" <56200@debbugs.gnu.org>
Subject: [bug#56200] [PATCH v2] gnu: linux-libre: Enable the AMD HSA driver.
Date: Wed, 29 Jun 2022 00:38:56 +0000 [thread overview]
Message-ID: <e87igmgsRjri0FJY_3I3lojHFkfLLDjmCR2jUTCX6E384kgr_QAUY0JjK2bxBbg6nOKC6SDXjowggvlL-LTK3a9Crli_fVW5t6XrjLSM930=@protonmail.com> (raw)
In-Reply-To: <YrX2oIKSr5yH9eiL@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]
Hi Leo,
------- Original Message -------
On Tuesday, June 28th, 2022 at 4:30 PM, Leo Famulari wrote:
>
> Don't worry too much about the commit message. The only thing to change
> is that the commit title should begin with 'gnu', which is how we denote
> that the change touches the software distribution portion of guix.git,
> as compared to 'guix', 'doc', 'build', etc. But I would normally handle
> that without mentioning it to the patch submitter.
>
I'm decent with package patch notes now, but wasn't sure how the kernel config fit in. I did look for examples but must have found one that missed the convention.
> > * gnu/packages/aux-files/linux-libre/5.18-x86_64.conf: Enable the AMD
> > Heterogeneous System Architecture (HSA) driver.
>
>
> Grepping for 'HSA_AMD' in guix.git:
>
> ------
> $ git grep HSA_AMD
> gnu/packages/aux-files/linux-libre/4.14-x86_64.conf:CONFIG_HSA_AMD=m
> gnu/packages/aux-files/linux-libre/4.19-x86_64.conf:CONFIG_HSA_AMD=m
> gnu/packages/aux-files/linux-libre/4.9-x86_64.conf:CONFIG_HSA_AMD=m
> gnu/packages/aux-files/linux-libre/5.10-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.10-x86_64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.15-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.15-x86_64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.18-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.18-x86_64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.4-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.4-x86_64.conf:# CONFIG_HSA_AMD is not set
> ------
>
> Yes, there is actually some 64-bit ARM hardware by AMD.
>
> Anyways, I recommend enabling it in all the configs where it is
> currently not set. What do you think? If that's a good idea, can you
> send a revised patch?
>
> Don't worry about building all the kernels if that's a burden; I'll
> check that they build before pushing.
>
I've attached a v2 of the patch that sets it for all the configurations where the option was listed. Note that a few had it "enabled" with setting it to "m", but I don't think that does anything, per my testing. And looking at the documentation, seems like it should be "y": https://www.kernelconfig.io/config_hsa_amd
I did not build any of the other kernels, but how does that look now?
Thanks again!
John
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-linux-libre-Enable-the-AMD-HSA-driver.patch --]
[-- Type: text/x-patch; name=0001-gnu-linux-libre-Enable-the-AMD-HSA-driver.patch, Size: 7288 bytes --]
From 3adb2143ba54b3c0751bda7c8b06ad9f02681b65 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Mon, 27 Jun 2022 00:33:54 -0400
Subject: [PATCH] gnu: linux-libre: Enable the AMD HSA driver.
* gnu/packages/aux-files/linux-libre/4.14-x86_64.conf
gnu/packages/aux-files/linux-libre/4.19-x86_64.conf,
gnu/packages/aux-files/linux-libre/4.9-x86_64.conf,
gnu/packages/aux-files/linux-libre/5.10-arm64.conf,
gnu/packages/aux-files/linux-libre/5.10-x86_64.conf,
gnu/packages/aux-files/linux-libre/5.15-arm64.conf,
gnu/packages/aux-files/linux-libre/5.15-x86_64.conf,
gnu/packages/aux-files/linux-libre/5.18-arm64.conf,
gnu/packages/aux-files/linux-libre/5.18-x86_64.conf,
gnu/packages/aux-files/linux-libre/5.4-arm64.conf,
gnu/packages/aux-files/linux-libre/5.4-x86_64.conf: Enable the AMD
Heterogeneous System Architecture (HSA) driver.
---
gnu/packages/aux-files/linux-libre/4.14-x86_64.conf | 2 +-
gnu/packages/aux-files/linux-libre/4.19-x86_64.conf | 2 +-
gnu/packages/aux-files/linux-libre/4.9-x86_64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.10-arm64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.10-x86_64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.15-arm64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.15-x86_64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.18-arm64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.18-x86_64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.4-arm64.conf | 2 +-
gnu/packages/aux-files/linux-libre/5.4-x86_64.conf | 2 +-
11 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf
index 3953ee9104..86445b40ba 100644
--- a/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/4.14-x86_64.conf
@@ -5683,7 +5683,7 @@ CONFIG_DRM_PANEL_BRIDGE=y
# Display Interface Bridges
#
CONFIG_DRM_ANALOGIX_ANX78XX=m
-CONFIG_HSA_AMD=m
+CONFIG_HSA_AMD=y
CONFIG_DRM_HISI_HIBMC=m
# CONFIG_DRM_TINYDRM is not set
# CONFIG_DRM_LEGACY is not set
diff --git a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
index 24148dcf6f..4ae1aa33f0 100644
--- a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
@@ -5894,7 +5894,7 @@ CONFIG_DRM_PANEL_BRIDGE=y
# Display Interface Bridges
#
CONFIG_DRM_ANALOGIX_ANX78XX=m
-CONFIG_HSA_AMD=m
+CONFIG_HSA_AMD=y
CONFIG_DRM_HISI_HIBMC=m
# CONFIG_DRM_TINYDRM is not set
CONFIG_DRM_XEN=y
diff --git a/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf
index 8d47127ece..afc7973373 100644
--- a/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/4.9-x86_64.conf
@@ -5465,7 +5465,7 @@ CONFIG_DRM_BRIDGE=y
# Display Interface Bridges
#
CONFIG_DRM_ANALOGIX_ANX78XX=m
-CONFIG_HSA_AMD=m
+CONFIG_HSA_AMD=y
# CONFIG_DRM_LEGACY is not set
#
diff --git a/gnu/packages/aux-files/linux-libre/5.10-arm64.conf b/gnu/packages/aux-files/linux-libre/5.10-arm64.conf
index a612819ee9..046c310d85 100644
--- a/gnu/packages/aux-files/linux-libre/5.10-arm64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.10-arm64.conf
@@ -5848,7 +5848,7 @@ CONFIG_DRM_AMD_DC=y
CONFIG_DRM_AMD_DC_SI=y
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_PLATFORM_DRIVER=y
diff --git a/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf
index 4dfb742813..2760c71f62 100644
--- a/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf
@@ -6304,7 +6304,7 @@ CONFIG_DRM_AMD_DC_SI=y
# CONFIG_DEBUG_KERNEL_DC is not set
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_DEBUG=5
diff --git a/gnu/packages/aux-files/linux-libre/5.15-arm64.conf b/gnu/packages/aux-files/linux-libre/5.15-arm64.conf
index d67461d051..3a3d144330 100644
--- a/gnu/packages/aux-files/linux-libre/5.15-arm64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.15-arm64.conf
@@ -6100,7 +6100,7 @@ CONFIG_DRM_AMD_DC=y
CONFIG_DRM_AMD_DC_SI=y
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_PLATFORM_DRIVER=y
diff --git a/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf
index abb1c98fcb..8fbb48bcb6 100644
--- a/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf
@@ -6482,7 +6482,7 @@ CONFIG_DRM_AMD_DC_DCN=y
CONFIG_DRM_AMD_SECURE_DISPLAY=y
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_DEBUG=5
diff --git a/gnu/packages/aux-files/linux-libre/5.18-arm64.conf b/gnu/packages/aux-files/linux-libre/5.18-arm64.conf
index 0175565bf3..929b0a128c 100644
--- a/gnu/packages/aux-files/linux-libre/5.18-arm64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.18-arm64.conf
@@ -6265,7 +6265,7 @@ CONFIG_DRM_AMD_DC=y
CONFIG_DRM_AMD_DC_SI=y
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_PLATFORM_DRIVER=y
diff --git a/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf
index 658e01187b..c8502e42c8 100644
--- a/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.18-x86_64.conf
@@ -6687,7 +6687,7 @@ CONFIG_DRM_AMD_DC_DCN=y
CONFIG_DRM_AMD_SECURE_DISPLAY=y
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_DEBUG=5
diff --git a/gnu/packages/aux-files/linux-libre/5.4-arm64.conf b/gnu/packages/aux-files/linux-libre/5.4-arm64.conf
index d2ba5871e0..3b05083301 100644
--- a/gnu/packages/aux-files/linux-libre/5.4-arm64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.4-arm64.conf
@@ -5523,7 +5523,7 @@ CONFIG_DRM_AMD_DC=y
# CONFIG_DEBUG_KERNEL_DC is not set
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_PLATFORM_DRIVER=y
diff --git a/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf
index 7cf92478c1..7325ac21fc 100644
--- a/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf
+++ b/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf
@@ -6108,7 +6108,7 @@ CONFIG_DRM_AMD_DC_DSC_SUPPORT=y
# CONFIG_DEBUG_KERNEL_DC is not set
# end of Display Engine Configuration
-# CONFIG_HSA_AMD is not set
+CONFIG_HSA_AMD=y
CONFIG_DRM_NOUVEAU=m
# CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is not set
CONFIG_NOUVEAU_DEBUG=5
--
2.36.1
next prev parent reply other threads:[~2022-06-29 0:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 17:38 [bug#56200] Kernel 5.18 update Leo Famulari
2022-06-24 17:41 ` [bug#56200] [PATCH 1/3] gnu: Add linux-libre 5.18 Leo Famulari
2022-06-24 17:41 ` [bug#56200] [PATCH 2/3] gnu: linux-libre: Update to 5.18.6 Leo Famulari
2022-06-24 17:41 ` [bug#56200] [PATCH 3/3] gnu: Remove linux-libre 5.17 Leo Famulari
2022-06-24 18:25 ` [bug#56200] Kernel 5.18 update John Kehayias via Guix-patches via
2022-06-24 18:49 ` Leo Famulari
2022-06-26 14:57 ` John Kehayias via Guix-patches via
2022-06-26 20:02 ` Leo Famulari
2022-06-26 20:30 ` Tobias Geerinckx-Rice via Guix-patches via
2022-06-27 4:43 ` [bug#56200] [PATCH 4/4] linux-libre: Enable the AMD HSA driver John Kehayias via Guix-patches via
2022-06-28 20:30 ` Leo Famulari
2022-06-29 0:38 ` John Kehayias via Guix-patches via [this message]
2022-06-29 1:05 ` [bug#56200] [PATCH v2] gnu: " Leo Famulari
2022-06-29 12:55 ` bug#56200: " Leo Famulari
2022-06-29 16:17 ` [bug#56200] " John Kehayias via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e87igmgsRjri0FJY_3I3lojHFkfLLDjmCR2jUTCX6E384kgr_QAUY0JjK2bxBbg6nOKC6SDXjowggvlL-LTK3a9Crli_fVW5t6XrjLSM930=@protonmail.com' \
--to=guix-patches@gnu.org \
--cc=56200@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).