unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: 56200@debbugs.gnu.org
Subject: [bug#56200] [PATCH 4/4] linux-libre: Enable the AMD HSA driver.
Date: Tue, 28 Jun 2022 16:30:21 -0400	[thread overview]
Message-ID: <Yrtk3dfYAbVjzOg6@jasmine.lan> (raw)
In-Reply-To: <Zk4X-Uty7XKc79kHgMhSvQicWEzVfdjfPVFwhWFgmgX-R4vingpid6KhAC08kp-A9qhOBXE5mE3mVkA3SYQ2ey-AI9a_rWW1N7axL0OqreQ=@protonmail.com>

On Mon, Jun 27, 2022 at 04:43:24AM +0000, John Kehayias via Guix-patches via wrote:
> I've attached a patch that should apply after the original patch series, enabling CONFIG_HSA_AMD for the x86_64 5.18 config. I checked only that linux-libre builds, but haven't tried a kernel I would normally used (modified from linux-libre). I could give that a shot later. I'm not entirely sure if I got the commit message format for this type of change correct, but hopefully is close.

Thanks!

> Subject: [PATCH] linux-libre: Enable the AMD HSA driver.

Don't worry too much about the commit message. The only thing to change
is that the commit title should begin with 'gnu', which is how we denote
that the change touches the software distribution portion of guix.git,
as compared to 'guix', 'doc', 'build', etc. But I would normally handle
that without mentioning it to the patch submitter.

> * gnu/packages/aux-files/linux-libre/5.18-x86_64.conf: Enable the AMD
> Heterogeneous System Architecture (HSA) driver.

Grepping for 'HSA_AMD' in guix.git:

------
$ git grep HSA_AMD
gnu/packages/aux-files/linux-libre/4.14-x86_64.conf:CONFIG_HSA_AMD=m
gnu/packages/aux-files/linux-libre/4.19-x86_64.conf:CONFIG_HSA_AMD=m
gnu/packages/aux-files/linux-libre/4.9-x86_64.conf:CONFIG_HSA_AMD=m
gnu/packages/aux-files/linux-libre/5.10-arm64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.10-x86_64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.15-arm64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.15-x86_64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.18-arm64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.18-x86_64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.4-arm64.conf:# CONFIG_HSA_AMD is not set
gnu/packages/aux-files/linux-libre/5.4-x86_64.conf:# CONFIG_HSA_AMD is not set
------

Yes, there is actually some 64-bit ARM hardware by AMD.

Anyways, I recommend enabling it in all the configs where it is
currently not set. What do you think? If that's a good idea, can you
send a revised patch?

Don't worry about building all the kernels if that's a burden; I'll
check that they build before pushing.




  reply	other threads:[~2022-06-28 20:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 17:38 [bug#56200] Kernel 5.18 update Leo Famulari
2022-06-24 17:41 ` [bug#56200] [PATCH 1/3] gnu: Add linux-libre 5.18 Leo Famulari
2022-06-24 17:41   ` [bug#56200] [PATCH 2/3] gnu: linux-libre: Update to 5.18.6 Leo Famulari
2022-06-24 17:41   ` [bug#56200] [PATCH 3/3] gnu: Remove linux-libre 5.17 Leo Famulari
2022-06-24 18:25 ` [bug#56200] Kernel 5.18 update John Kehayias via Guix-patches via
2022-06-24 18:49   ` Leo Famulari
2022-06-26 14:57   ` John Kehayias via Guix-patches via
2022-06-26 20:02     ` Leo Famulari
2022-06-26 20:30       ` Tobias Geerinckx-Rice via Guix-patches via
2022-06-27  4:43 ` [bug#56200] [PATCH 4/4] linux-libre: Enable the AMD HSA driver John Kehayias via Guix-patches via
2022-06-28 20:30   ` Leo Famulari [this message]
2022-06-29  0:38 ` [bug#56200] [PATCH v2] gnu: " John Kehayias via Guix-patches via
2022-06-29  1:05   ` Leo Famulari
2022-06-29 12:55     ` bug#56200: " Leo Famulari
2022-06-29 16:17       ` [bug#56200] " John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrtk3dfYAbVjzOg6@jasmine.lan \
    --to=leo@famulari.name \
    --cc=56200@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).