Hi Leo,

------- Original Message -------
On Tuesday, June 28th, 2022 at 4:30 PM, Leo Famulari wrote:
>
> Don't worry too much about the commit message. The only thing to change
> is that the commit title should begin with 'gnu', which is how we denote
> that the change touches the software distribution portion of guix.git,
> as compared to 'guix', 'doc', 'build', etc. But I would normally handle
> that without mentioning it to the patch submitter.
>

I'm decent with package patch notes now, but wasn't sure how the kernel config fit in. I did look for examples but must have found one that missed the convention.

> > * gnu/packages/aux-files/linux-libre/5.18-x86_64.conf: Enable the AMD
> > Heterogeneous System Architecture (HSA) driver.
>
>
> Grepping for 'HSA_AMD' in guix.git:
>
> ------
> $ git grep HSA_AMD
> gnu/packages/aux-files/linux-libre/4.14-x86_64.conf:CONFIG_HSA_AMD=m
> gnu/packages/aux-files/linux-libre/4.19-x86_64.conf:CONFIG_HSA_AMD=m
> gnu/packages/aux-files/linux-libre/4.9-x86_64.conf:CONFIG_HSA_AMD=m
> gnu/packages/aux-files/linux-libre/5.10-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.10-x86_64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.15-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.15-x86_64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.18-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.18-x86_64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.4-arm64.conf:# CONFIG_HSA_AMD is not set
> gnu/packages/aux-files/linux-libre/5.4-x86_64.conf:# CONFIG_HSA_AMD is not set
> ------
>
> Yes, there is actually some 64-bit ARM hardware by AMD.
>
> Anyways, I recommend enabling it in all the configs where it is
> currently not set. What do you think? If that's a good idea, can you
> send a revised patch?
>
> Don't worry about building all the kernels if that's a burden; I'll
> check that they build before pushing.
>

I've attached a v2 of the patch that sets it for all the configurations where the option was listed. Note that a few had it "enabled" with setting it to "m", but I don't think that does anything, per my testing. And looking at the documentation, seems like it should be "y": https://www.kernelconfig.io/config_hsa_amd

I did not build any of the other kernels, but how does that look now?

Thanks again!
John