* [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus
@ 2023-04-21 13:14 kyle
2023-04-21 14:05 ` Nicolas Goaziou
2023-04-21 22:00 ` [bug#62993] [PATCH v2] " kyle
0 siblings, 2 replies; 5+ messages in thread
From: kyle @ 2023-04-21 13:14 UTC (permalink / raw)
To: 62993; +Cc: Kyle Andrews
From: Kyle Andrews <kyle@posteo.net>
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6618aac332..6522012cdd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -349,6 +349,29 @@ (define-public emacs-ace-jump-helm-line
"This package allows using Ace jump to a candidate in Helm window.")
(license license:gpl3+))))
+(define-public emacs-bookmark-plus
+ (package
+ (name "emacs-bookmark-plus")
+ (version "2022.11.05")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacsmirror/bookmark-plus")
+ (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
+ (sha256
+ (base32
+ "0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/emacsmirror/bookmark-plus")
+ (synopsis "Extensions to the bookmark.el library in Emacs")
+ (description
+ "Bookmarks are a powerful Emacs feature. This package makes them even more
+versatile. You can bookmark many more kinds of data. You can add tags. There
+are many more ways to organize and display your bookmarks. I recommend reading
+the extensive documentation about BookmarkPlus on the Emacs Wiki.")
+ (license license:gpl3)))
+
(define-public emacs-cfrs
(package
(name "emacs-cfrs")
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus
2023-04-21 13:14 [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus kyle
@ 2023-04-21 14:05 ` Nicolas Goaziou
2023-04-21 14:09 ` Nicolas Goaziou
2023-04-21 22:00 ` [bug#62993] [PATCH v2] " kyle
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2023-04-21 14:05 UTC (permalink / raw)
To: kyle; +Cc: 62993
Hello,
kyle <kyle@posteo.net> writes:
> +(define-public emacs-bookmark-plus
> + (package
> + (name "emacs-bookmark-plus")
> + (version "2022.11.05")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/emacsmirror/bookmark-plus")
> + (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
> + (sha256
> + (base32
> + "0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))
Nitpick: indentation is a bit off here.
> + (build-system emacs-build-system)
> + (home-page "https://github.com/emacsmirror/bookmark-plus")
> + (synopsis "Extensions to the bookmark.el library in Emacs")
Nitpick: Bookmark (the library) instead of "bookmark.el" (the file).
> + (description
> + "Bookmarks are a powerful Emacs feature. This package makes them even more
> +versatile. You can bookmark many more kinds of data. You can add tags. There
> +are many more ways to organize and display your bookmarks. I recommend reading
> +the extensive documentation about BookmarkPlus on the Emacs Wiki.")
Guix usually puts two spaces between sentences.
> + (license license:gpl3)))
License is actually GPL3+.
Otherwise, LGTM.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus
2023-04-21 14:05 ` Nicolas Goaziou
@ 2023-04-21 14:09 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2023-04-21 14:09 UTC (permalink / raw)
To: kyle; +Cc: 62993
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Otherwise, LGTM.
And thanks for the patch, of course!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#62993] [PATCH v2] gnu: Add emacs-bookmark-plus
2023-04-21 13:14 [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus kyle
2023-04-21 14:05 ` Nicolas Goaziou
@ 2023-04-21 22:00 ` kyle
2023-04-22 10:09 ` bug#62993: " Nicolas Goaziou
1 sibling, 1 reply; 5+ messages in thread
From: kyle @ 2023-04-21 22:00 UTC (permalink / raw)
To: 62993; +Cc: Kyle Andrews
From: Kyle Andrews <kyle@posteo.net>
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6618aac332..ff2bbf0bd7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -349,6 +349,29 @@ (define-public emacs-ace-jump-helm-line
"This package allows using Ace jump to a candidate in Helm window.")
(license license:gpl3+))))
+(define-public emacs-bookmark-plus
+ (package
+ (name "emacs-bookmark-plus")
+ (version "2022.11.05")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacsmirror/bookmark-plus")
+ (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
+ (sha256
+ (base32
+ "0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/emacsmirror/bookmark-plus")
+ (synopsis "Extensions to the Bookmark library in Emacs")
+ (description
+ "Bookmarks are a powerful Emacs feature. This package makes them even
+more versatile. You can bookmark many more kinds of data. You can add tags.
+There are many more ways to organize and display your bookmarks. I recommend
+reading the extensive documentation about BookmarkPlus on the Emacs Wiki.")
+ (license license:gpl3+)))
+
(define-public emacs-cfrs
(package
(name "emacs-cfrs")
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#62993: [PATCH v2] gnu: Add emacs-bookmark-plus
2023-04-21 22:00 ` [bug#62993] [PATCH v2] " kyle
@ 2023-04-22 10:09 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2023-04-22 10:09 UTC (permalink / raw)
To: kyle; +Cc: 62993-done
Hello,
kyle <kyle@posteo.net> writes:
> +(define-public emacs-bookmark-plus
I normalized the commit message and applied your patch. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-22 10:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-21 13:14 [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus kyle
2023-04-21 14:05 ` Nicolas Goaziou
2023-04-21 14:09 ` Nicolas Goaziou
2023-04-21 22:00 ` [bug#62993] [PATCH v2] " kyle
2023-04-22 10:09 ` bug#62993: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).