unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: kyle <kyle@posteo.net>
Cc: 62993@debbugs.gnu.org
Subject: [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus
Date: Fri, 21 Apr 2023 16:05:44 +0200	[thread overview]
Message-ID: <87mt312uvb.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <e62afb73b971f2b41cb7395e623088f12003420d.1682082880.git.kyle@posteo.net> (kyle@posteo.net's message of "Fri, 21 Apr 2023 13:14:40 +0000")

Hello,

kyle <kyle@posteo.net> writes:

> +(define-public emacs-bookmark-plus
> +  (package
> +   (name "emacs-bookmark-plus")
> +   (version "2022.11.05")
> +   (source
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +	    (url "https://github.com/emacsmirror/bookmark-plus")
> +	    (commit "3db369056a722c42b3eafd10a91831f87d056dfa")))
> +      (sha256
> +       (base32
> +	"0fnq24f597zfr8jj5h3vr87kdil5lhy11m81q6ayqc03qm0jymrf"))))

Nitpick: indentation is a bit off here.

> +   (build-system emacs-build-system)
> +   (home-page "https://github.com/emacsmirror/bookmark-plus")
> +   (synopsis "Extensions to the bookmark.el library in Emacs")

Nitpick: Bookmark (the library) instead of "bookmark.el" (the file).

> +   (description
> +    "Bookmarks are a powerful Emacs feature. This package makes them even more
> +versatile. You can bookmark many more kinds of data. You can add tags. There
> +are many more ways to organize and display your bookmarks. I recommend reading
> +the extensive documentation about BookmarkPlus on the Emacs Wiki.")

Guix usually puts two spaces between sentences.

> +   (license license:gpl3)))

License is actually GPL3+.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2023-04-21 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 13:14 [bug#62993] [PATCH] gnu: Add emacs-bookmark-plus kyle
2023-04-21 14:05 ` Nicolas Goaziou [this message]
2023-04-21 14:09   ` Nicolas Goaziou
2023-04-21 22:00 ` [bug#62993] [PATCH v2] " kyle
2023-04-22 10:09   ` bug#62993: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt312uvb.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=62993@debbugs.gnu.org \
    --cc=kyle@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).