From: Maxime Devos <maximedevos@telenet.be>
To: Gabriel Wicki <gabriel@erlikon.ch>, 48630@debbugs.gnu.org
Subject: [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next
Date: Mon, 24 May 2021 23:01:09 +0200 [thread overview]
Message-ID: <b8dbcd484944232e2da0a9e9d9e32317ff487dbc.camel@telenet.be> (raw)
In-Reply-To: <20210524191054.7wtb4wopstgx2c77@silver>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
Gabriel Wicki schreef op ma 24-05-2021 om 21:10 [+0200]:
> [...]
> +(define-public ack
> + (package
> + (name "ack")
> + (version "3.5.0")
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/beyondgrep/ack3")
> + (commit (format #nil "v~a" version))))
#f is an elisp compatibility hack in Guile.
Use (format #f "v~a" version) instead, or simpler
(string-append "v" version).
Looking at the patch only and (I didn't test it, didn't do
licensing checks, etc.) I only see one other problem:
> + (arguments '(#:tests? #f))
Why are the tests disabled? (Are there none, do they need
additional packages not in Guix, ...) Maybe add a line like
> + ;; There is no test suite.
> + (arguments '(#:tests? #f))
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-05-24 21:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 19:10 [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next Gabriel Wicki
2021-05-24 21:01 ` Maxime Devos [this message]
2021-05-24 21:26 ` Xinglu Chen
2021-05-25 22:13 ` Gabriel Wicki
2021-05-27 6:45 ` Xinglu Chen
2021-05-27 16:45 ` Gabriel Wicki
2021-05-28 20:13 ` Xinglu Chen
2021-07-06 18:52 ` Gabriel Wicki
[not found] ` <handler.48630.B.162188348523111.ack@debbugs.gnu.org>
2021-05-25 19:12 ` [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next) Gabriel Wicki
2021-05-25 21:34 ` Xinglu Chen
2021-05-25 22:03 ` [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next Gabriel Wicki
2021-07-26 14:33 ` [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next) Gabriel Wicki
2022-07-08 16:44 ` bug#48630: [PATCH] adds `ack' package and it's perl module dependency File::Next Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8dbcd484944232e2da0a9e9d9e32317ff487dbc.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=48630@debbugs.gnu.org \
--cc=gabriel@erlikon.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).