unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Gabriel Wicki <gabriel@erlikon.ch>
To: 48630@debbugs.gnu.org
Subject: [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next)
Date: Tue, 25 May 2021 21:12:59 +0200	[thread overview]
Message-ID: <20210525191259.23awunfcwdr6p3cg@silver> (raw)
In-Reply-To: <handler.48630.B.162188348523111.ack@debbugs.gnu.org>

thanks for the advice, i'll update and split the patch into a small
series soon!


the tests are deactivated because 3 of 841 fail. they seem to check
some kind of shebang #! paths. see this excerpt from the build log:

#   Failed test 'Util::sets_match( TEST_TYPE with -t perl )'
#   at t/ack-type.t line 43.

	# actual[
	#   't/swamp/0:1:#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl -w',
...
	# ]
	# expected[
	#   't/swamp/0:1:#!/usr/bin/perl -w',
...
	# ]

these lines are being ignored by the patch-generated-file-shebangs
phase, maybe because the #! aren't at the beginning of the line?

i'm a total novice in Perl, so i'm not sure what exactly is happening
there or why this is even tested.

should i try and add my own version of a patch-shebang after the
patch-generated-file-shebangs phase?




  parent reply	other threads:[~2021-05-25 20:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 19:10 [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next Gabriel Wicki
2021-05-24 21:01 ` Maxime Devos
2021-05-24 21:26 ` Xinglu Chen
2021-05-25 22:13 ` Gabriel Wicki
2021-05-27  6:45   ` Xinglu Chen
2021-05-27 16:45     ` Gabriel Wicki
2021-05-28 20:13       ` Xinglu Chen
2021-07-06 18:52         ` Gabriel Wicki
     [not found] ` <handler.48630.B.162188348523111.ack@debbugs.gnu.org>
2021-05-25 19:12   ` Gabriel Wicki [this message]
2021-05-25 21:34     ` [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next) Xinglu Chen
2021-05-25 22:03       ` [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next Gabriel Wicki
2021-07-26 14:33   ` [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next) Gabriel Wicki
2022-07-08 16:44 ` bug#48630: [PATCH] adds `ack' package and it's perl module dependency File::Next Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525191259.23awunfcwdr6p3cg@silver \
    --to=gabriel@erlikon.ch \
    --cc=48630@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).