From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ELdvKFEUrGDqqQAAgWs5BA (envelope-from ) for ; Mon, 24 May 2021 23:02:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wCcrJFEUrGCgSwAAB5/wlQ (envelope-from ) for ; Mon, 24 May 2021 21:02:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1DB72551B for ; Mon, 24 May 2021 23:02:08 +0200 (CEST) Received: from localhost ([::1]:58086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llHiB-0006gD-8q for larch@yhetil.org; Mon, 24 May 2021 17:02:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llHi6-0006fh-GQ for guix-patches@gnu.org; Mon, 24 May 2021 17:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llHi6-0000gb-8a for guix-patches@gnu.org; Mon, 24 May 2021 17:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llHi6-0000IG-6K for guix-patches@gnu.org; Mon, 24 May 2021 17:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 May 2021 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48630 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki , 48630@debbugs.gnu.org Received: via spool by 48630-submit@debbugs.gnu.org id=B48630.16218900851082 (code B ref 48630); Mon, 24 May 2021 21:02:02 +0000 Received: (at 48630) by debbugs.gnu.org; 24 May 2021 21:01:25 +0000 Received: from localhost ([127.0.0.1]:44020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llHhV-0000HN-F4 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:01:25 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:49682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llHhU-0000HF-1T for 48630@debbugs.gnu.org; Mon, 24 May 2021 17:01:24 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by andre.telenet-ops.be with bizsmtp id 8l1M2500T0mfAB401l1Nli; Mon, 24 May 2021 23:01:22 +0200 Message-ID: From: Maxime Devos Date: Mon, 24 May 2021 23:01:09 +0200 In-Reply-To: <20210524191054.7wtb4wopstgx2c77@silver> References: <20210524191054.7wtb4wopstgx2c77@silver> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-oqUmi9nuvCo+8bggsUiK" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1621890082; bh=IvsgGFmMp8KwYGPDPvHWfOe2Kv4ay8GJ42vIqw0pLqo=; h=Subject:From:To:Date:In-Reply-To:References; b=vCKHOjA/f/ZsHB2JjkFO6xBcJsqaUhT3n5QC4F/vVDcqwEUdGuQ+zmALr4tgtfoeU Dn4Vy+m97Vim5fdLdAlWUkx6rKwbqT5kjnMaHZ5WuW2xhoaSgy0HijB6s+Np8aTAWX aB++85Ytoo12r0KTOG0mvs1GQasJKZO7yN7HL+XzumBjdHi//xWR97ExnfyBe/O2CC iIYmXrp5wiQBunqFzFRmR1PeK0TYxCRqMBGuAMKPC/iFqGOC/f14rmg+gGRBX+idnG AG1RkTacTF8cgtEgPQOVcm9ZEPEzRogdxwNUuHpJdIytb/AzpZVs0odayoU2bK/FD/ 5OHLDHSdUlD6g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621890129; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IvsgGFmMp8KwYGPDPvHWfOe2Kv4ay8GJ42vIqw0pLqo=; b=od0zDGGq+z8OQZ/KqnAibot4FjT2tBtrTosCCTiZvJx328exUsRas37lZFD/nwPWw/T0Ty TOFwYODSFO9Ofnn43nlLw/PkpXtjk+nwjhhxn+ytf4l7qLBr0g8y15L9qRxNXzDe9WzBsN KuJUWnI8305U+NBJr/fOKe0gB8Wop3SYKwFbRZqV8ji7gG4rqgQUZf8DnHQdHvHdOYEQfh vIwYaZA1a0iCov6vmK7Yvan7ohoEeoK8+a7dnwMQMC33cgAijsK5/Ihy4TN3TjBqYBPOZE UWtPwTFycIAFpyxBSRIEO8or/lZAkNIgORxhnqNH1CAhgFeqUIPt9kCUbpP+ew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621890129; a=rsa-sha256; cv=none; b=J0JvrM1vIZlQuYAF+bXqV+yTsMzeT7a0R9+oVRDkQ3XLyhcDRXh3Tcx9YqsWI1/gizKSgQ L9v/Z4Gs7KuPFacy1gbPOXT4IRspI4MZrocW2G1s+1iCkkV+jYSHjZhZtdIipCWmc7m9n5 grXTrxcXnv3AR7A4AQIs9zzqQ24A5ESppe7Xg0faaj6R1HsDKL8QLVMLXKsiZpIpdFQcwp 6ZzfUMmWNZ2Kw4idaoF31CG4nfJmH4EgwBoFQmdQtHwezNddZ9cricXcNickUNlspXnNA4 6oQbT0h7eVdfOjIW7sAjXWah9mHMovGOj86le3CttwR83kaL8+GQRsdL2Xssqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="vCKHOjA/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="vCKHOjA/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A1DB72551B X-Spam-Score: -3.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: nLW6G8xVUIrT --=-oqUmi9nuvCo+8bggsUiK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gabriel Wicki schreef op ma 24-05-2021 om 21:10 [+0200]: > [...] > +(define-public ack > + (package > + (name "ack") > + (version "3.5.0") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/beyondgrep/ack3") > + (commit (format #nil "v~a" version)))) #f is an elisp compatibility hack in Guile. Use (format #f "v~a" version) instead, or simpler (string-append "v" version). Looking at the patch only and (I didn't test it, didn't do licensing checks, etc.) I only see one other problem: > + (arguments '(#:tests? #f)) Why are the tests disabled? (Are there none, do they need additional packages not in Guix, ...) Maybe add a line like > + ;; There is no test suite. > + (arguments '(#:tests? #f)) Greetings, Maxime. --=-oqUmi9nuvCo+8bggsUiK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYKwUHxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iWXAQDWOpjbcIknk/MN8PUtmO28a2Ab mJoir5bh4D53h0eW9wD+NrdV2T56fCmuDKo3OskSi6CUxHokvlWeO+LkDyXoBg8= =Lo63 -----END PGP SIGNATURE----- --=-oqUmi9nuvCo+8bggsUiK--