From: Jack Hill <jackhill@jackhill.us>
To: Adam Kandur <rndd@tuta.io>
Cc: 47506@debbugs.gnu.org
Subject: [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program.
Date: Wed, 31 Mar 2021 02:28:55 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2103310223520.8138@marsh.hcoop.net> (raw)
In-Reply-To: <MX4K52s--3-2@tuta.io>
[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]
Hi,
Thanks for your interest in fiano-fmap!
On Wed, 31 Mar 2021, Adam Kandur via Guix-patches via wrote:
>
> From b5a149a0ae68eb2692463f0d77f3da686ff23864 Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd@tuta.io>
> Date: Wed, 31 Mar 2021 01:46:49 +0300
> Subject: [PATCH] gnu: fiano-fmap: turn off tests to build program.
>
> * gnu/packages/admin.scm (fiano-fmap): turn off tests to build program.
> ---
> gnu/packages/admin.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 292a4bc..14f7864 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4431,7 +4431,9 @@ disk utilization, priority, username, state, and exit code.")
> (name "fiano-fmap")
> (arguments
> `(#:import-path "github.com/linuxboot/fiano/cmds/fmap"
> - #:unpack-path "github.com/linuxboot/fiano"))))
> + #:unpack-path "github.com/linuxboot/fiano"
> + ;; tests dont work
> + #:tests? #f))))
>
> (define-public novena-eeprom
> (package
>
When I first noticed the test failure in #45172 [0] it wasn't clear to me
that the test failure was harmless rather than exhibiting an actual problem
in our fiano-fmap package. Can you confirm that the package works as
expected? I also wonder if we could make a smaller change and just disable
the problematic test rather than the whole suite.
I've also noticed that fiano-fmap has a release candidate for version
6.0.0. I wonder if that version fixes the problem (I may have to give it a
try, although this one may come back to needing improvements in the
go-build-system).
[0] https://issues.guix.gnu.org/45172
Best,
Jack
prev parent reply other threads:[~2021-03-31 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 22:50 [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program Adam Kandur via Guix-patches via
2021-03-31 6:28 ` Jack Hill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2103310223520.8138@marsh.hcoop.net \
--to=jackhill@jackhill.us \
--cc=47506@debbugs.gnu.org \
--cc=rndd@tuta.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).