From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6HFcOi4XZGB6ZgAAgWs5BA (envelope-from ) for ; Wed, 31 Mar 2021 08:31:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sOk2NC4XZGAvfgAAB5/wlQ (envelope-from ) for ; Wed, 31 Mar 2021 06:31:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5732411FEE for ; Wed, 31 Mar 2021 08:31:10 +0200 (CEST) Received: from localhost ([::1]:48222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRUNh-0000UC-9h for larch@yhetil.org; Wed, 31 Mar 2021 02:31:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRUMf-0000Sy-SB for guix-patches@gnu.org; Wed, 31 Mar 2021 02:30:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRUMc-0003O2-8v for guix-patches@gnu.org; Wed, 31 Mar 2021 02:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRUMc-0004mL-3h for guix-patches@gnu.org; Wed, 31 Mar 2021 02:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 31 Mar 2021 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47506 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Kandur Cc: 47506@debbugs.gnu.org Received: via spool by 47506-submit@debbugs.gnu.org id=B47506.161717214318268 (code B ref 47506); Wed, 31 Mar 2021 06:30:02 +0000 Received: (at 47506) by debbugs.gnu.org; 31 Mar 2021 06:29:03 +0000 Received: from localhost ([127.0.0.1]:53320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRULe-0004kZ-V0 for submit@debbugs.gnu.org; Wed, 31 Mar 2021 02:29:03 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:50574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRULd-0004k1-55 for 47506@debbugs.gnu.org; Wed, 31 Mar 2021 02:29:01 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRULX-0006Gu-Cv; Wed, 31 Mar 2021 02:28:55 -0400 Date: Wed, 31 Mar 2021 02:28:55 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-1363479628-1617172135=:8138" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617172270; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=lS0xK8Kju3wlBpTHbXef4rnPStDWkG0kQWxi3KizCmg=; b=f5wZEtVhFc/upZXai1Fj4mbkmUspAHHlINzBnF5WkaUAzNyEPHKxAZDtxVGxiEcXTlXGDu Z2Pl1luMJaGpgFORFFTArDi8Gqjpona1QHJZ9iin/BAwzFJpbmhwVAW+9URJ5a64cZNJL9 2W/dE7eKx3rEaASLG4AXNtkSL/yBJFu/sdldr3tth7V7U2upupUp+RlCg7PiC47lKtt/DH cMWmzmdm9GIruzOaQbYTNMqaYW8lS0DzpqeQyR7USAL6jbM2Bs29CEa0A5F00CTdmQXTbq W8qrGdwaUkgjFL3H2PSfRgcwxuf6GJIPIU5xCovPRkhji70j6PLf2YvpTXLZ0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617172270; a=rsa-sha256; cv=none; b=RGFRZU2+SGDBJ2j0jNHFXntYPGIwFKdWbPADw/ub52Isoj2rKevm5GWFAZba5/3jDWp0EN iE5V0DVZRIg4ZgFLwmI0QT8p5XM/wsG+67erw9ppNZftE3fMB386nAuhrt/ZSCsoD+n8u5 YzDBgZKZnOS1NH7gHwFhmZGIUxwL2yqsacrrSTYLFFq8gmvl/XvQW17IfI6qr5awbl1kuL z546FO/tJ1g9FfIShtDjF1ixNVqlldZVw8SiXzuBFXxrLUswIZaucsMPFZTr8Kv2sXlXCN bXs5vVuwoWYaE1ixr+l2lMeEQVXUh/XqLVpo56RhyVRAY85JWthU9SBzZ21+rg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.08 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5732411FEE X-Spam-Score: 0.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: Hx3/OevodZSS This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1363479628-1617172135=:8138 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Hi, Thanks for your interest in fiano-fmap! On Wed, 31 Mar 2021, Adam Kandur via Guix-patches via wrote: > > From b5a149a0ae68eb2692463f0d77f3da686ff23864 Mon Sep 17 00:00:00 2001 > From: Adam Kandur > Date: Wed, 31 Mar 2021 01:46:49 +0300 > Subject: [PATCH] gnu: fiano-fmap: turn off tests to build program. > > * gnu/packages/admin.scm (fiano-fmap): turn off tests to build program. > --- >  gnu/packages/admin.scm | 4 +++- >  1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 292a4bc..14f7864 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -4431,7 +4431,9 @@ disk utilization, priority, username, state, and exit code.") >      (name "fiano-fmap") >      (arguments >       `(#:import-path "github.com/linuxboot/fiano/cmds/fmap" > -       #:unpack-path "github.com/linuxboot/fiano")))) > +       #:unpack-path "github.com/linuxboot/fiano" > +       ;; tests dont work > +       #:tests? #f)))) >   >  (define-public novena-eeprom >    (package > When I first noticed the test failure in #45172 [0] it wasn't clear to me that the test failure was harmless rather than exhibiting an actual problem in our fiano-fmap package. Can you confirm that the package works as expected? I also wonder if we could make a smaller change and just disable the problematic test rather than the whole suite. I've also noticed that fiano-fmap has a release candidate for version 6.0.0. I wonder if that version fixes the problem (I may have to give it a try, although this one may come back to needing improvements in the go-build-system). [0] https://issues.guix.gnu.org/45172 Best, Jack --925712948-1363479628-1617172135=:8138--