* [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program.
@ 2021-03-30 22:50 Adam Kandur via Guix-patches via
2021-03-31 6:28 ` Jack Hill
0 siblings, 1 reply; 2+ messages in thread
From: Adam Kandur via Guix-patches via @ 2021-03-30 22:50 UTC (permalink / raw)
To: 47506
From b5a149a0ae68eb2692463f0d77f3da686ff23864 Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd@tuta.io>
Date: Wed, 31 Mar 2021 01:46:49 +0300
Subject: [PATCH] gnu: fiano-fmap: turn off tests to build program.
* gnu/packages/admin.scm (fiano-fmap): turn off tests to build program.
---
gnu/packages/admin.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 292a4bc..14f7864 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -4431,7 +4431,9 @@ disk utilization, priority, username, state, and exit code.")
(name "fiano-fmap")
(arguments
`(#:import-path "github.com/linuxboot/fiano/cmds/fmap"
- #:unpack-path "github.com/linuxboot/fiano"))))
+ #:unpack-path "github.com/linuxboot/fiano"
+ ;; tests dont work
+ #:tests? #f))))
(define-public novena-eeprom
(package
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program.
2021-03-30 22:50 [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program Adam Kandur via Guix-patches via
@ 2021-03-31 6:28 ` Jack Hill
0 siblings, 0 replies; 2+ messages in thread
From: Jack Hill @ 2021-03-31 6:28 UTC (permalink / raw)
To: Adam Kandur; +Cc: 47506
[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]
Hi,
Thanks for your interest in fiano-fmap!
On Wed, 31 Mar 2021, Adam Kandur via Guix-patches via wrote:
>
> From b5a149a0ae68eb2692463f0d77f3da686ff23864 Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd@tuta.io>
> Date: Wed, 31 Mar 2021 01:46:49 +0300
> Subject: [PATCH] gnu: fiano-fmap: turn off tests to build program.
>
> * gnu/packages/admin.scm (fiano-fmap): turn off tests to build program.
> ---
> gnu/packages/admin.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 292a4bc..14f7864 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4431,7 +4431,9 @@ disk utilization, priority, username, state, and exit code.")
> (name "fiano-fmap")
> (arguments
> `(#:import-path "github.com/linuxboot/fiano/cmds/fmap"
> - #:unpack-path "github.com/linuxboot/fiano"))))
> + #:unpack-path "github.com/linuxboot/fiano"
> + ;; tests dont work
> + #:tests? #f))))
>
> (define-public novena-eeprom
> (package
>
When I first noticed the test failure in #45172 [0] it wasn't clear to me
that the test failure was harmless rather than exhibiting an actual problem
in our fiano-fmap package. Can you confirm that the package works as
expected? I also wonder if we could make a smaller change and just disable
the problematic test rather than the whole suite.
I've also noticed that fiano-fmap has a release candidate for version
6.0.0. I wonder if that version fixes the problem (I may have to give it a
try, although this one may come back to needing improvements in the
go-build-system).
[0] https://issues.guix.gnu.org/45172
Best,
Jack
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 6:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 22:50 [bug#47506] [PATCH] gnu: fiano-fmap: turn off tests to build program Adam Kandur via Guix-patches via
2021-03-31 6:28 ` Jack Hill
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).