[bug#43317] [PATCH] gnu: Add surge-synth.

[bug#43317] [PATCH] gnu: Add surge-synth.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 60 bytes --]

Hi,

This patch adds surge synthesizer.

Thanks,
Alex

[-- Attachment #1.2: 0001-gnu-Add-surge-synth.patch --]
[-- Type: text/x-patch, Size: 3634 bytes --]

From 613f46926fdf0453ec5ad5f5883130ed86bf6d9c Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Thu, 10 Sep 2020 20:07:32 +0100
Subject: [PATCH] gnu: Add surge-synth.

* gnu/packages/music.scm (surge-synth): New variable.
---
 gnu/packages/music.scm | 69 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 28c889019e..4cfefc472e 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -775,6 +775,75 @@ are helpful when working in problem spaces where timing is important (such as
 audio and video).")
     (license license:bsd-2)))
 
+(define-public surge-synth
+  (package
+   (name "surge-synth")
+   (version "1.7.1")
+   (source
+     (origin
+       (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/surge-synthesizer/surge")
+               (commit (string-append "release_" version))
+               (recursive? #t))) ; build system expects modules to be there
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "1jhk8iaqh89dnci4446b47315v2lc8gclraygk8m9jl20zpjxl0l"))))
+   (build-system cmake-build-system)
+   (arguments
+    `(#:tests? #f ; no tests included
+      #:phases
+      (modify-phases %standard-phases
+        (add-after 'unpack 'replace-python
+          (lambda* (#:key inputs outputs #:allow-other-keys)
+            (begin
+              (substitute* "CMakeLists.txt"
+                           ((" python ") (string-append " " (assoc-ref inputs "python") "/bin/python3 ")))
+              #t)))
+        (add-after 'unpack 'fix-data-path
+          (lambda* (#:key inputs outputs #:allow-other-keys)
+            (begin
+              (substitute* "src/common/SurgeStorage.cpp"
+                           (("/usr") (assoc-ref outputs "out")))
+              #t)))
+        (replace 'install ; no install target
+          (lambda* (#:key inputs outputs #:allow-other-keys)
+            (let* ((src (assoc-ref inputs "source"))
+                   (out (assoc-ref outputs "out"))
+                   (share (string-append out "/share"))
+                   (lib (string-append out "/lib"))
+                   (lv2 (string-append lib "/lv2"))
+                   (vst3 (string-append lib "/vst3")))
+              (mkdir-p lv2)
+              (mkdir-p vst3)
+              ;; Install LV2 plugin.
+              (copy-recursively "surge_products/Surge.lv2"
+                                (string-append lv2 "/Surge.lv2"))
+              ;; Install VST3 plugin.
+              (copy-recursively "surge_products/Surge.vst3"
+                                (string-append vst3 "/Surge.vst3"))
+              ;; Install data.
+              (copy-recursively (string-append src "/resources/data")
+                                (string-append share "/Surge"))
+              #t))))))
+   (inputs
+    `(("cairo" ,cairo)
+      ("libxkbcommon" ,libxkbcommon)
+      ("python" ,python)
+      ("xcb-util" ,xcb-util)
+      ("xcb-util-cursor" ,xcb-util-cursor)
+      ("xcb-util-keysyms" ,xcb-util-keysyms)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (home-page "https://surge-synthesizer.github.io/")
+   (synopsis "Synthesizer plugin")
+   (description
+    "Surge is a subtractive hybrid digital synthesizer.  Each patch contains
+two 'scenes' which are separate instances of the entire synthesis engine
+(except effects) that can be used for layering or split patches.")
+   (license license:gpl3+)))
+
 (define-public klick
   (package
     (name "klick")
-- 
2.27.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#43317: [PATCH] gnu: Add surge-synth.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi Alex,

Alexandros Theodotou <alex@zrythm.org> skribis:

> From 613f46926fdf0453ec5ad5f5883130ed86bf6d9c Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Thu, 10 Sep 2020 20:07:32 +0100
> Subject: [PATCH] gnu: Add surge-synth.
>
> * gnu/packages/music.scm (surge-synth): New variable.

Applied with the changes below: added missing import, removed unneeded
‘begin’, followed ‘guix lint’ suggestion for the description.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2159 bytes --]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 305a0023b7..899cc6a0e0 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -147,6 +147,7 @@
   #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages xiph)
@@ -799,16 +800,16 @@ audio and video).")
       (modify-phases %standard-phases
         (add-after 'unpack 'replace-python
           (lambda* (#:key inputs outputs #:allow-other-keys)
-            (begin
-              (substitute* "CMakeLists.txt"
-                           ((" python ") (string-append " " (assoc-ref inputs "python") "/bin/python3 ")))
-              #t)))
-        (add-after 'unpack 'fix-data-path
+            (substitute* "CMakeLists.txt"
+              ((" python ")
+               (string-append " " (assoc-ref inputs "python")
+                              "/bin/python3 ")))
+            #t))
+        (add-after 'unpack 'fix-data-directory-name
           (lambda* (#:key inputs outputs #:allow-other-keys)
-            (begin
-              (substitute* "src/common/SurgeStorage.cpp"
-                           (("/usr") (assoc-ref outputs "out")))
-              #t)))
+            (substitute* "src/common/SurgeStorage.cpp"
+              (("/usr") (assoc-ref outputs "out")))
+            #t))
         (replace 'install ; no install target
           (lambda* (#:key inputs outputs #:allow-other-keys)
             (let* ((src (assoc-ref inputs "source"))
@@ -842,8 +843,8 @@ audio and video).")
    (synopsis "Synthesizer plugin")
    (description
     "Surge is a subtractive hybrid digital synthesizer.  Each patch contains
-two 'scenes' which are separate instances of the entire synthesis engine
-(except effects) that can be used for layering or split patches.")
+two @dfn{scenes} which are separate instances of the entire synthesis
+engine (except effects) that can be used for layering or split patches.")
    (license license:gpl3+)))
 
 (define-public klick