unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 43317-done@debbugs.gnu.org
Subject: bug#43317: [PATCH] gnu: Add surge-synth.
Date: Sat, 19 Sep 2020 22:51:42 +0200	[thread overview]
Message-ID: <877dsppk0x.fsf@gnu.org> (raw)
In-Reply-To: <aef2872b46d451ffe1790a99d6036a902f32be0e.camel@zrythm.org> (Alexandros Theodotou's message of "Thu, 10 Sep 2020 20:08:56 +0100")

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi Alex,

Alexandros Theodotou <alex@zrythm.org> skribis:

> From 613f46926fdf0453ec5ad5f5883130ed86bf6d9c Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Thu, 10 Sep 2020 20:07:32 +0100
> Subject: [PATCH] gnu: Add surge-synth.
>
> * gnu/packages/music.scm (surge-synth): New variable.

Applied with the changes below: added missing import, removed unneeded
‘begin’, followed ‘guix lint’ suggestion for the description.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2159 bytes --]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 305a0023b7..899cc6a0e0 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -147,6 +147,7 @@
   #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages xiph)
@@ -799,16 +800,16 @@ audio and video).")
       (modify-phases %standard-phases
         (add-after 'unpack 'replace-python
           (lambda* (#:key inputs outputs #:allow-other-keys)
-            (begin
-              (substitute* "CMakeLists.txt"
-                           ((" python ") (string-append " " (assoc-ref inputs "python") "/bin/python3 ")))
-              #t)))
-        (add-after 'unpack 'fix-data-path
+            (substitute* "CMakeLists.txt"
+              ((" python ")
+               (string-append " " (assoc-ref inputs "python")
+                              "/bin/python3 ")))
+            #t))
+        (add-after 'unpack 'fix-data-directory-name
           (lambda* (#:key inputs outputs #:allow-other-keys)
-            (begin
-              (substitute* "src/common/SurgeStorage.cpp"
-                           (("/usr") (assoc-ref outputs "out")))
-              #t)))
+            (substitute* "src/common/SurgeStorage.cpp"
+              (("/usr") (assoc-ref outputs "out")))
+            #t))
         (replace 'install ; no install target
           (lambda* (#:key inputs outputs #:allow-other-keys)
             (let* ((src (assoc-ref inputs "source"))
@@ -842,8 +843,8 @@ audio and video).")
    (synopsis "Synthesizer plugin")
    (description
     "Surge is a subtractive hybrid digital synthesizer.  Each patch contains
-two 'scenes' which are separate instances of the entire synthesis engine
-(except effects) that can be used for layering or split patches.")
+two @dfn{scenes} which are separate instances of the entire synthesis
+engine (except effects) that can be used for layering or split patches.")
    (license license:gpl3+)))
 
 (define-public klick

      reply	other threads:[~2020-09-19 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 19:08 [bug#43317] [PATCH] gnu: Add surge-synth Alexandros Theodotou
2020-09-19 20:51 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dsppk0x.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43317-done@debbugs.gnu.org \
    --cc=alex@zrythm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).