* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
@ 2021-12-22 3:34 Jack Hill
2021-12-24 0:44 ` Liliana Marie Prikler
0 siblings, 1 reply; 7+ messages in thread
From: Jack Hill @ 2021-12-22 3:34 UTC (permalink / raw)
To: 52730
* gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the empyt list
as a default value for #:configure-flags.
---
gnu/packages/gstreamer.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 87adb7c92a..1f6a56e30d 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -1034,7 +1034,7 @@ (define-public gst-editing-services
(license license:gpl2+)))
(define-public gst-plugins/selection
- (lambda* (pkg #:key plugins configure-flags)
+ (lambda* (pkg #:key plugins (configure-flags '()))
"Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-FLAGS are
given, also pass them to the build system instead of the ones used by PKG."
(package/inherit pkg
--
2.34.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
2021-12-22 3:34 [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional Jack Hill
@ 2021-12-24 0:44 ` Liliana Marie Prikler
2021-12-24 5:17 ` Jack Hill
0 siblings, 1 reply; 7+ messages in thread
From: Liliana Marie Prikler @ 2021-12-24 0:44 UTC (permalink / raw)
To: Jack Hill, 52730
Hi,
Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill:
> * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the
> empyt list as a default value for #:configure-flags.
The current implementation ought to copy pre-existing configure-flags
as-is if you don't supply flags on your own. I personally believe
that's preferable over an empty value, that will probably be reset.
WDYT?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
2021-12-24 0:44 ` Liliana Marie Prikler
@ 2021-12-24 5:17 ` Jack Hill
2021-12-24 6:37 ` Jack Hill
2022-08-16 19:46 ` Liliana Marie Prikler
0 siblings, 2 replies; 7+ messages in thread
From: Jack Hill @ 2021-12-24 5:17 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 52730
On Fri, 24 Dec 2021, Liliana Marie Prikler wrote:
> Hi,
>
> Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill:
>> * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the
>> empyt list as a default value for #:configure-flags.
> The current implementation ought to copy pre-existing configure-flags
> as-is if you don't supply flags on your own. I personally believe
> that's preferable over an empty value, that will probably be reset.
> WDYT?
Yes, I agree that the current implementation ought to, but it doesn't.
Instead it complains:
"""
ice-9/psyntax.scm:2794:12: In procedure syntax-violation:
Syntax error:
unknown location: quote: bad syntax in form quote
"""
I'll see about a v2.
Thanks!
Jack
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
2021-12-24 5:17 ` Jack Hill
@ 2021-12-24 6:37 ` Jack Hill
2021-12-24 7:56 ` Liliana Marie Prikler
2022-08-16 19:46 ` Liliana Marie Prikler
1 sibling, 1 reply; 7+ messages in thread
From: Jack Hill @ 2021-12-24 6:37 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 52730
On Fri, 24 Dec 2021, Jack Hill wrote:
>
>
> On Fri, 24 Dec 2021, Liliana Marie Prikler wrote:
>
>> Hi,
>>
>> Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill:
>>> * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the
>>> empyt list as a default value for #:configure-flags.
>
>> The current implementation ought to copy pre-existing configure-flags
>> as-is if you don't supply flags on your own. I personally believe
>> that's preferable over an empty value, that will probably be reset.
>> WDYT?
>
> Yes, I agree that the current implementation ought to, but it doesn't.
> Instead it complains:
>
> """
> ice-9/psyntax.scm:2794:12: In procedure syntax-violation:
> Syntax error:
> unknown location: quote: bad syntax in form quote
> """
>
> I'll see about a v2.
I've looked at it for a little bit now, but I'm afraid that I'm stuck. I
tried setting the default to #f (which may have been happening implicitly
anyway):
```
(define-public gst-plugins/selection
(lambda* (pkg #:key plugins (configure-flags #f))
"Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-FLAGS are
given, also pass them to the build system instead of the ones used by PKG."
(package/inherit pkg
(arguments
(substitute-keyword-arguments (package-arguments pkg)
((#:configure-flags flags `(,@(or configure-flags '())))
`(append
(list
,@(map (lambda (plugin)
(string-append "-D" plugin "=enabled"))
plugins))
(list ,@(or configure-flags flags))))
((#:phases phases)
`(modify-phases ,phases
(add-after 'unpack 'disable-auto-plugins
(lambda _
(substitute* "meson_options.txt"
(("'auto'") "'disabled'")))))))))))
```
but that still gives me the "bad syntax in form quote" message. I can keep
thinking about it, but if someone else knows the solution, I'd be happy to
learn from you :)
Best,
Jack
^ permalink raw reply [flat|nested] 7+ messages in thread* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
2021-12-24 6:37 ` Jack Hill
@ 2021-12-24 7:56 ` Liliana Marie Prikler
0 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2021-12-24 7:56 UTC (permalink / raw)
To: Jack Hill; +Cc: 52730
Hi Jack,
Am Freitag, dem 24.12.2021 um 01:37 -0500 schrieb Jack Hill:
> On Fri, 24 Dec 2021, Jack Hill wrote:
>
> I've looked at it for a little bit now, but I'm afraid that I'm
> stuck. I tried setting the default to #f (which may have been
> happening implicitly anyway):
Yes, if you don't supply an optional argument in Guile (or I guess in
Scheme generally), that argument gets #f as value.
> ```
> (define-public gst-plugins/selection
> (lambda* (pkg #:key plugins (configure-flags #f))
> "Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-
> FLAGS are
> given, also pass them to the build system instead of the ones used by
> PKG."
> (package/inherit pkg
> (arguments
> (substitute-keyword-arguments (package-arguments pkg)
> ((#:configure-flags flags `(,@(or configure-flags '())))
> `(append
> (list
> ,@(map (lambda (plugin)
> (string-append "-D" plugin "=enabled"))
> plugins))
> (list ,@(or configure-flags flags))))
> ((#:phases phases)
> `(modify-phases ,phases
> (add-after 'unpack 'disable-auto-plugins
> (lambda _
> (substitute* "meson_options.txt"
> (("'auto'") "'disabled'")))))))))))
> ```
>
> but that still gives me the "bad syntax in form quote" message. I can
> keep thinking about it, but if someone else knows the solution, I'd
> be happy to learn from you :)
I swear this used to work before the c-u-f merge. There might be a
problem mixing this with gexps or something I didn't account for back
then.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
2021-12-24 5:17 ` Jack Hill
2021-12-24 6:37 ` Jack Hill
@ 2022-08-16 19:46 ` Liliana Marie Prikler
2024-01-22 16:36 ` Maxim Cournoyer
1 sibling, 1 reply; 7+ messages in thread
From: Liliana Marie Prikler @ 2022-08-16 19:46 UTC (permalink / raw)
To: Jack Hill; +Cc: 52730
Hi Jack,
Am Freitag, dem 24.12.2021 um 00:17 -0500 schrieb Jack Hill:
> On Fri, 24 Dec 2021, Liliana Marie Prikler wrote:
>
> > Hi,
> >
> > Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill:
> > > * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the
> > > empyt list as a default value for #:configure-flags.
>
> > The current implementation ought to copy pre-existing configure-
> > flags
> > as-is if you don't supply flags on your own. I personally believe
> > that's preferable over an empty value, that will probably be reset.
> > WDYT?
>
> Yes, I agree that the current implementation ought to, but it
> doesn't.
> Instead it complains:
>
> """
> ice-9/psyntax.scm:2794:12: In procedure syntax-violation:
> Syntax error:
> unknown location: quote: bad syntax in form quote
> """
Is this still an issue? Also try staging, which has gstreamer 1.20 and
some gexp-improvements for gst-plugins/selection.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional.
2022-08-16 19:46 ` Liliana Marie Prikler
@ 2024-01-22 16:36 ` Maxim Cournoyer
0 siblings, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2024-01-22 16:36 UTC (permalink / raw)
To: Jack Hill; +Cc: Liliana Marie Prikler, 52730
Hello Jack,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Hi Jack,
>
> Am Freitag, dem 24.12.2021 um 00:17 -0500 schrieb Jack Hill:
>> On Fri, 24 Dec 2021, Liliana Marie Prikler wrote:
>>
>> > Hi,
>> >
>> > Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill:
>> > > * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the
>> > > empyt list as a default value for #:configure-flags.
>>
>> > The current implementation ought to copy pre-existing configure-
>> > flags
>> > as-is if you don't supply flags on your own. I personally believe
>> > that's preferable over an empty value, that will probably be reset.
>> > WDYT?
>>
>> Yes, I agree that the current implementation ought to, but it
>> doesn't.
>> Instead it complains:
>>
>> """
>> ice-9/psyntax.scm:2794:12: In procedure syntax-violation:
>> Syntax error:
>> unknown location: quote: bad syntax in form quote
>> """
> Is this still an issue? Also try staging, which has gstreamer 1.20 and
> some gexp-improvements for gst-plugins/selection.
Ping :-)
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-22 16:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 3:34 [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional Jack Hill
2021-12-24 0:44 ` Liliana Marie Prikler
2021-12-24 5:17 ` Jack Hill
2021-12-24 6:37 ` Jack Hill
2021-12-24 7:56 ` Liliana Marie Prikler
2022-08-16 19:46 ` Liliana Marie Prikler
2024-01-22 16:36 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).