From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MIS9KdRrxWGWMgAAgWs5BA (envelope-from ) for ; Fri, 24 Dec 2021 07:42:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4FpoJdRrxWHSHgAAbx9fmQ (envelope-from ) for ; Fri, 24 Dec 2021 06:42:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C8493B0CF for ; Fri, 24 Dec 2021 07:42:28 +0100 (CET) Received: from localhost ([::1]:35114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0eHZ-0006Tu-7F for larch@yhetil.org; Fri, 24 Dec 2021 01:42:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eDN-0006RV-VG for guix-patches@gnu.org; Fri, 24 Dec 2021 01:38:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0eDK-00031x-ON for guix-patches@gnu.org; Fri, 24 Dec 2021 01:38:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n0eDK-00006i-H8 for guix-patches@gnu.org; Fri, 24 Dec 2021 01:38:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 52730@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 52730@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1640327860380 (code B ref -1); Fri, 24 Dec 2021 06:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Dec 2021 06:37:40 +0000 Received: from localhost ([127.0.0.1]:35507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0eCs-00005z-Uv for submit@debbugs.gnu.org; Fri, 24 Dec 2021 01:37:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:36542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0eCq-00005q-08 for submit@debbugs.gnu.org; Fri, 24 Dec 2021 01:37:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eCp-0006HR-Ji for guix-patches@gnu.org; Fri, 24 Dec 2021 01:37:31 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:59494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eCe-0002yu-KB for guix-patches@gnu.org; Fri, 24 Dec 2021 01:37:30 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0eCb-0000dF-OH; Fri, 24 Dec 2021 01:37:17 -0500 Date: Fri, 24 Dec 2021 01:37:17 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: <20211222033442.14793-1-jackhill@jackhill.us> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640328148; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=o6B205zckppCxCzhUIt9hD2OM3T4iSBwu8K9rSS60EA=; b=A7ac3YZ6waZO3v3eQSfpumn0xsZdxDXnIWCbaJ2QIGHo7PzfK3o9iP3dJQpt1leJ9dbx+K Nhms95gwo/RdioppiZmQv8klDi8+FPK5XSjEQjJOxmeY+O+vaoi7S/XDXkQA6n31XzKmgI dHv+QhkFI330PzfmFYrmKOu8cT0UeVozyH/1CRZv3qTP9axIAI4uEMJsiPTRyR3atV0nJM +aDuvixRYmczOpPaSsDsmA89S0mYAwnrZZtowhByQAzDLGrV9pkuYgqQTJ4ITJFozwsArN ROiUUMRqFrcsKkJp+m0+b4XdQPeoi5BztwxjkjsubwrQv2Y0Ux+yOyb49yLsJA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640328148; a=rsa-sha256; cv=none; b=TrhWoYhgHZplFnKPltE2z5cwgAVPAnzZkfhdDeCLt3XZbrdbuIptSoKi3dsGIStlP1HeWc fT1vbtqBPmrTXZdO5v2pr6slIskbY9dytyXYAycAOeXkL0dlHLwodw0sBtQvw0l1g/RyqM /bsN6/VKOLR1dvgJ4fBQfjW8/heJkAwu+H6WyCb9hXySvbECgDqWaGoHNCpo5vRqViYT43 UdEjUAPYvNlH+W4tETE0NMDX/kQrRbZ5kM98mn+cYC3G2ubnu/0VyhvS5+FODUpoqYzwGv IWt7o1qNI9pMN32v8pNHGRq6NkXs31SYfJYZYzP4u05thzwb4hv57vsg3z89fA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.76 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2C8493B0CF X-Spam-Score: -3.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: kpzoQhJ0q2ce On Fri, 24 Dec 2021, Jack Hill wrote: > > > On Fri, 24 Dec 2021, Liliana Marie Prikler wrote: > >> Hi, >> >> Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill: >>> * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the >>> empyt list as a default value for #:configure-flags. > >> The current implementation ought to copy pre-existing configure-flags >> as-is if you don't supply flags on your own. I personally believe >> that's preferable over an empty value, that will probably be reset. >> WDYT? > > Yes, I agree that the current implementation ought to, but it doesn't. > Instead it complains: > > """ > ice-9/psyntax.scm:2794:12: In procedure syntax-violation: > Syntax error: > unknown location: quote: bad syntax in form quote > """ > > I'll see about a v2. I've looked at it for a little bit now, but I'm afraid that I'm stuck. I tried setting the default to #f (which may have been happening implicitly anyway): ``` (define-public gst-plugins/selection (lambda* (pkg #:key plugins (configure-flags #f)) "Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-FLAGS are given, also pass them to the build system instead of the ones used by PKG." (package/inherit pkg (arguments (substitute-keyword-arguments (package-arguments pkg) ((#:configure-flags flags `(,@(or configure-flags '()))) `(append (list ,@(map (lambda (plugin) (string-append "-D" plugin "=enabled")) plugins)) (list ,@(or configure-flags flags)))) ((#:phases phases) `(modify-phases ,phases (add-after 'unpack 'disable-auto-plugins (lambda _ (substitute* "meson_options.txt" (("'auto'") "'disabled'"))))))))))) ``` but that still gives me the "bad syntax in form quote" message. I can keep thinking about it, but if someone else knows the solution, I'd be happy to learn from you :) Best, Jack