From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UBa6DC9lu2KQHAAAbAwnHQ (envelope-from ) for ; Tue, 28 Jun 2022 22:31:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SPPMCy9lu2LJ7QAAG6o9tA (envelope-from ) for ; Tue, 28 Jun 2022 22:31:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 488F717A8A for ; Tue, 28 Jun 2022 22:31:42 +0200 (CEST) Received: from localhost ([::1]:46060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6Hs5-0007QW-5Y for larch@yhetil.org; Tue, 28 Jun 2022 16:31:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6HrT-0007QC-RX for guix-patches@gnu.org; Tue, 28 Jun 2022 16:31:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6HrS-0002Wy-89 for guix-patches@gnu.org; Tue, 28 Jun 2022 16:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6HrS-0002lB-5x for guix-patches@gnu.org; Tue, 28 Jun 2022 16:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56200] [PATCH 4/4] linux-libre: Enable the AMD HSA driver. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Jun 2022 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56200 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56200@debbugs.gnu.org X-Debbugs-Original-To: John Kehayias via Guix-patches via X-Debbugs-Original-Cc: "56200@debbugs.gnu.org" <56200@debbugs.gnu.org> Received: via spool by 56200-submit@debbugs.gnu.org id=B56200.165644823210556 (code B ref 56200); Tue, 28 Jun 2022 20:31:02 +0000 Received: (at 56200) by debbugs.gnu.org; 28 Jun 2022 20:30:32 +0000 Received: from localhost ([127.0.0.1]:56403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Hqx-0002kC-TZ for submit@debbugs.gnu.org; Tue, 28 Jun 2022 16:30:32 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6Hqv-0002jr-An for 56200@debbugs.gnu.org; Tue, 28 Jun 2022 16:30:30 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3413A5C0242; Tue, 28 Jun 2022 16:30:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 28 Jun 2022 16:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; t=1656448224; x=1656534624; bh=a8r/dFMewoIvSvDK66UxwrGsvhDDfslKLR7iiLzgX/Y=; b=mxW+sxfEUD1w oDOJNCciYmZpeWfVZAb7yuda+uOlEoDAHdKQfltrxpV/yaqc7anLh4Ob2ibAAM0w S9QxQ7te2ayER/HsPJSYJgZC+gG1SWLV2M0KgPghWdvmmU7oCjqnw+Cx843+KTNL v7uPQEbjnPRXRS+dM+1iEZy7MuLA2sI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656448224; x=1656534624; bh=a8r/dFMewoIvSvDK66UxwrGsvhDD fslKLR7iiLzgX/Y=; b=M9coUdGrMCS67qh39naouOFiqEX6N5LI8FQS/6waHCKz ZDRxye8upcBie5T1F2HtKZzYo2LKxeKmtSV72p9htnScxPA3/fqM+jvQ6XdjccZD /dAurP3Y8hJf+xanUw5dcrXFVTaLMWzKZb+tagiwiiCmojK2gcnV1flhHHofcebt MFx78IXkfWNpYU4wXQsYAGiCA8fVRia1UK6UHabdm7pp64KpEL9d7ZJOyGNMyz51 5Ywek4p863h/YLxvmGukTAsNRTVIapsrKdYbMOz+IMWUGMNedpC6wLmrrEnzwPVW ZdVDA6+b5Q/wcUuWdphaqYnTJkZvn9zoED+0bPKvnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegjedgudehudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdej leeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Jun 2022 16:30:23 -0400 (EDT) Date: Tue, 28 Jun 2022 16:30:21 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656448303; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=a8r/dFMewoIvSvDK66UxwrGsvhDDfslKLR7iiLzgX/Y=; b=bUVlXyGjV/9wLPbQeAE98PwdkTVXnAhDYham+tYtFV6dPlkXwtbueR1jTR6tEhAQG42gEh 4uYBg709PjStdCbUVfqV3/AWfKqNZAYiTrQUUkOI6fMl1DuX5lrEomDRFg1ccemaGozIJk tQfSecDXVtpnVFemZT/7crEaVJCmtwHj5MgaHuKF6t+uBuB5xGSC5yPm4JOKO7FUYLOJW/ SkvQaT/WbYua2RohIs7k2dXBZ+mNtxuUBfwO1Suo5RON4s3YxV6sLcWRnSZUAgdCwxOGaC tB7hdD8SEQq6GTfdv56D7O5udbpTS5GKFnymT+QbTd9DwfEe9IJWBwoHTSyvMQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656448303; a=rsa-sha256; cv=none; b=c21z7fbWVSpws8AqD8msmeaLK2kZhXBoL4Zqi9EAVV/pxryEBHs3reqyprGJ66SEwBmXQi upg6d5XoLl72FUlaZIxokUIMVK7414ZKJGuDVAgf4iRV6+wPtMJXucPwmjvz7D7dfAA5OQ hFNyeFZyq2LXbHNnCKHCCXdQ9Cb6Q5U9ngUJGQ2aO5T6+bfkgXCM+/VJFBERuphmyGL57U zm2SMblMsNdZWvkOjzoZvruXE/o74kcmMyV19ATD5E3eLI45o3kk29V3EjO9KZkHqRhmav a9qbuYs2x+an7RTqMi4TV2l/Hd6IyhzQbnEdn1P6Js7ALXhd63kwaYV/ipbpNg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=mxW+sxfE; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=M9coUdGr; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=mxW+sxfE; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=M9coUdGr; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 488F717A8A X-Spam-Score: 0.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: MMZXv2iBojhn On Mon, Jun 27, 2022 at 04:43:24AM +0000, John Kehayias via Guix-patches via wrote: > I've attached a patch that should apply after the original patch series, enabling CONFIG_HSA_AMD for the x86_64 5.18 config. I checked only that linux-libre builds, but haven't tried a kernel I would normally used (modified from linux-libre). I could give that a shot later. I'm not entirely sure if I got the commit message format for this type of change correct, but hopefully is close. Thanks! > Subject: [PATCH] linux-libre: Enable the AMD HSA driver. Don't worry too much about the commit message. The only thing to change is that the commit title should begin with 'gnu', which is how we denote that the change touches the software distribution portion of guix.git, as compared to 'guix', 'doc', 'build', etc. But I would normally handle that without mentioning it to the patch submitter. > * gnu/packages/aux-files/linux-libre/5.18-x86_64.conf: Enable the AMD > Heterogeneous System Architecture (HSA) driver. Grepping for 'HSA_AMD' in guix.git: ------ $ git grep HSA_AMD gnu/packages/aux-files/linux-libre/4.14-x86_64.conf:CONFIG_HSA_AMD=m gnu/packages/aux-files/linux-libre/4.19-x86_64.conf:CONFIG_HSA_AMD=m gnu/packages/aux-files/linux-libre/4.9-x86_64.conf:CONFIG_HSA_AMD=m gnu/packages/aux-files/linux-libre/5.10-arm64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.10-x86_64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.15-arm64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.15-x86_64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.18-arm64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.18-x86_64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.4-arm64.conf:# CONFIG_HSA_AMD is not set gnu/packages/aux-files/linux-libre/5.4-x86_64.conf:# CONFIG_HSA_AMD is not set ------ Yes, there is actually some 64-bit ARM hardware by AMD. Anyways, I recommend enabling it in all the configs where it is currently not set. What do you think? If that's a good idea, can you send a revised patch? Don't worry about building all the kernels if that's a burden; I'll check that they build before pushing.