unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: 47433@debbugs.gnu.org
Cc: lle-bout@zaclys.net
Subject: [bug#47433] [PATCH 2/2] gnu: Add lagrange.
Date: Sat, 27 Mar 2021 14:18:16 -0400	[thread overview]
Message-ID: <YF926LxhoInxQK3O@jasmine.lan> (raw)
In-Reply-To: <20210327134629.31646-2-lle-bout@zaclys.net>

On Sat, Mar 27, 2021 at 02:46:29PM +0100, Léo Le Bouter via Guix-patches via wrote:
> * gnu/packages/web.scm (lagrange): New variable.

Thanks!

> +;; When upgrading, also upgrade the "the-foundation" package just above.
> +;; Lagrange pins specific commits of it and "the-foundation" does not make
> +;; releases (yet?).

Can you add a note about how to figure out which commit is pinned?

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(begin
> +                  (delete-file-recursively "lib/the_Foundation")
> +                  #t))))

Please add a comment explaining why we have this snippet. In general,
snippets are only used to transform "non-free" source code into
something that conforms with the Free System Distribution Guidelines
[0], or to correct grave bugs in the source code.


> +    (synopsis "Beautiful desktop GUI client for browsing Geminispace")

The manual section Synopses and Descriptions asks us to avoid so-called
"marketing language". Beauty is in the eye of the beholder... :)

Otherwise, LGTM!

[0] https://www.gnu.org/distros/free-system-distribution-guidelines.en.html




  reply	other threads:[~2021-03-27 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 13:45 [bug#47433] [PATCH 0/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2021-03-27 13:46 ` [bug#47433] [PATCH 1/2] gnu: Add the-foundation Léo Le Bouter via Guix-patches via
2021-03-27 13:46   ` [bug#47433] [PATCH 2/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2021-03-27 18:18     ` Leo Famulari [this message]
2021-03-27 18:12   ` [bug#47433] [PATCH 1/2] gnu: Add the-foundation Leo Famulari
2021-03-28 15:49 ` [bug#47433] [PATCH v2 0/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2021-03-28 15:49   ` [bug#47433] [PATCH v2 1/2] gnu: Add the-foundation Léo Le Bouter via Guix-patches via
2021-03-28 15:49   ` [bug#47433] [PATCH v2 2/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2022-04-07 12:08 ` bug#47433: [PATCH 0/2] " Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF926LxhoInxQK3O@jasmine.lan \
    --to=leo@famulari.name \
    --cc=47433@debbugs.gnu.org \
    --cc=lle-bout@zaclys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).