From: Leo Famulari <leo@famulari.name>
To: 47433@debbugs.gnu.org
Cc: lle-bout@zaclys.net
Subject: [bug#47433] [PATCH 1/2] gnu: Add the-foundation.
Date: Sat, 27 Mar 2021 14:12:55 -0400 [thread overview]
Message-ID: <YF91p1h4jBSC116H@jasmine.lan> (raw)
In-Reply-To: <20210327134629.31646-1-lle-bout@zaclys.net>
On Sat, Mar 27, 2021 at 02:46:28PM +0100, Léo Le Bouter via Guix-patches via wrote:
> * gnu/packages/web.scm (the-foundation): New variable.
Thanks!
> +(define-public the-foundation
> + (let ((commit "8172d35cad24ec392bfd27e1f4de3a2205f988d2"))
Please add a "revision" variable ...
> + (package
> + (name "the-foundation")
> + (version (string-take commit 7))
... and use the git-version procedure, as described in the manual
section Version Numbers:
https://guix.gnu.org/manual/en/html_node/Version-Numbers.html
> + (native-inputs
> + `(("git" ,git-minimal)
Does it only use Git at build-time, and not keep a reference to the Git
package? You can check like this:
$ guix gc --references $(guix build --no-grafts thefoundation) | grep git
If it keeps a reference, then Git should be a regular input. I ask
because it's unusual for Guix packages to need to Git as a
native-inputs, because the .git directory is deleted before building,
and there is no network access at build time.
Otherwise, looks good to me.
next prev parent reply other threads:[~2021-03-27 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 13:45 [bug#47433] [PATCH 0/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2021-03-27 13:46 ` [bug#47433] [PATCH 1/2] gnu: Add the-foundation Léo Le Bouter via Guix-patches via
2021-03-27 13:46 ` [bug#47433] [PATCH 2/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2021-03-27 18:18 ` Leo Famulari
2021-03-27 18:12 ` Leo Famulari [this message]
2021-03-28 15:49 ` [bug#47433] [PATCH v2 0/2] " Léo Le Bouter via Guix-patches via
2021-03-28 15:49 ` [bug#47433] [PATCH v2 1/2] gnu: Add the-foundation Léo Le Bouter via Guix-patches via
2021-03-28 15:49 ` [bug#47433] [PATCH v2 2/2] gnu: Add lagrange Léo Le Bouter via Guix-patches via
2022-04-07 12:08 ` bug#47433: [PATCH 0/2] " Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF91p1h4jBSC116H@jasmine.lan \
--to=leo@famulari.name \
--cc=47433@debbugs.gnu.org \
--cc=lle-bout@zaclys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).