From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +A3KLyJ3X2Cv0wAAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 19:19:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GD52KSJ3X2AFAwAAbx9fmQ (envelope-from ) for ; Sat, 27 Mar 2021 18:19:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1715D2123F for ; Sat, 27 Mar 2021 19:19:14 +0100 (CET) Received: from localhost ([::1]:33434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQDWi-0000fA-E0 for larch@yhetil.org; Sat, 27 Mar 2021 14:19:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQDWZ-0000dc-67 for guix-patches@gnu.org; Sat, 27 Mar 2021 14:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQDWY-0005MJ-6c for guix-patches@gnu.org; Sat, 27 Mar 2021 14:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQDWY-0003Bf-2P for guix-patches@gnu.org; Sat, 27 Mar 2021 14:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47433] [PATCH 2/2] gnu: Add lagrange. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Mar 2021 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47433 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47433@debbugs.gnu.org Cc: lle-bout@zaclys.net X-Debbugs-Original-To: =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via X-Debbugs-Original-Cc: 47433@debbugs.gnu.org, =?UTF-8?Q?L=C3=A9o?= Le Bouter Received: via spool by 47433-submit@debbugs.gnu.org id=B47433.161686910612202 (code B ref 47433); Sat, 27 Mar 2021 18:19:02 +0000 Received: (at 47433) by debbugs.gnu.org; 27 Mar 2021 18:18:26 +0000 Received: from localhost ([127.0.0.1]:44919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQDVx-0003Af-W7 for submit@debbugs.gnu.org; Sat, 27 Mar 2021 14:18:26 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQDVw-0003AL-KD for 47433@debbugs.gnu.org; Sat, 27 Mar 2021 14:18:24 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 609D95C00C6; Sat, 27 Mar 2021 14:18:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 27 Mar 2021 14:18:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=MKcojEn8LdkfEqe3isFxjzlG7LhQLXlEa62BV5BDnag=; b=iE9MRMm4is65 mZfXHCEQMAhLEx7PA0lS1LvHJA/bVRw919h1ahtfOQW7lbwH8uzV/GxDnlMKY5jh MLqXFUs9TZVxcNVwwY+NTFqEPd6KzdtInwBPCQ6YDtwC0W6ZUhnQCyOUfnJywhW3 Sh3Wnf+4Bt+hfNbqKRn8B398NQ1Zzps= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=MKcojEn8LdkfEqe3isFxjzlG7LhQLXlEa62BV5BDn ag=; b=ODcVRRiRy6P3l9PiLLvYQxh1ouZ2eDln7C/TKy8aAUwxJqjKE/+hQlpVP MGn3IRYpzqT9LcDV54cyu3NQx1w+ywBaFaa/g/R6J++AqGpYw67Vf3xxFj7xuis0 tdKA9yjKcUAWW+VWxsR1yCU/uV2oBKNpBBntssaN1c4sd8KD50VkAmUMBoWI3oHB P4Z4x07ZEJEhQYj8iidRJ82oa+WRWxXWjMREpakZUJHb1lX2XPoDoaRSxU+qQajw mtTdQh9BTjduzcYOr+Z1EuyvYHvuqn9e2S3UxqtvHHXQ7T2horIrFcHPj+XwTdyD J0yYg7h83c1qzemgjfMza4jSUHVrA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehgedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeegieelteeuuedujeehfefhtddugfeffeehuedtueevfefhhffffffgveei leduhfenucffohhmrghinhepghhnuhdrohhrghenucfkphepuddttddruddurdduieelrd duudeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep lhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 895C8240054; Sat, 27 Mar 2021 14:18:18 -0400 (EDT) Date: Sat, 27 Mar 2021 14:18:16 -0400 From: Leo Famulari Message-ID: References: <20210327134629.31646-1-lle-bout@zaclys.net> <20210327134629.31646-2-lle-bout@zaclys.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210327134629.31646-2-lle-bout@zaclys.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616869154; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MKcojEn8LdkfEqe3isFxjzlG7LhQLXlEa62BV5BDnag=; b=PKtI7cgIl6otSQb68LKXERjMRLZmjlWD6uOORDqEYyZZ1aLdmqVh8kVNKjt0Ml3mLpYGmF glg9sWJUu3/yq376U4kR9oZnRu5wlHH3MBc9zVwqexoeOFV/6qVUyhGIWVkMmodkloBigH QZG0BagG62cJrgVYW+Wk1iAMdVPplpdKbKybOuPz2gZBGTZzyMRQn6QIO+itTf+/RwrDzl LBAF5kfFffwKG7F/t116HwRf1sjvpmAA98g0TVE++ra4/t3fo9UMYeM3z5L1Pn3sCtGyf/ TXSSw9Xn3Fyul2WvlhHIOnpmLFPDOCLcF6JjVRbQ7hYEh3PvxsN9xsuoOdwANA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616869154; a=rsa-sha256; cv=none; b=FzmQnDrK2YAiAVWV4d1bCqu6YpoZoenc5OPoR3SvHg9rFNeQK0cvcgupjTcrSZGHwwx1Bp fsgTPX7nbzUoqpNzed/y/2zsO9qPvvlhtwL+ToUBTJzMk+N5TV0Xbr9o5g/WXn8djoRQYd qgRbxV1gL7ugv0lvO1SeINCQdVH5zEa1awbBRNyxGftMZWngf00P5zfmwrU41ZCDjRusHM mFL5aSep3YCNBbK2Ue57GoIInmCkY2A8jF6qJZEp9zqrJjdpBQygNl2U+noKVW1mGy/Dqh 9jkkGvlbNy/3lSoJc8T7pt2rpcAmpYZCoaUCEsXAbbEKvhGR9qV07cdhF+2wJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=iE9MRMm4; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=ODcVRRiR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=iE9MRMm4; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=ODcVRRiR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1715D2123F X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: BFoc+QstfENb On Sat, Mar 27, 2021 at 02:46:29PM +0100, Léo Le Bouter via Guix-patches via wrote: > * gnu/packages/web.scm (lagrange): New variable. Thanks! > +;; When upgrading, also upgrade the "the-foundation" package just above. > +;; Lagrange pins specific commits of it and "the-foundation" does not make > +;; releases (yet?). Can you add a note about how to figure out which commit is pinned? > + (modules '((guix build utils))) > + (snippet > + '(begin > + (delete-file-recursively "lib/the_Foundation") > + #t)))) Please add a comment explaining why we have this snippet. In general, snippets are only used to transform "non-free" source code into something that conforms with the Free System Distribution Guidelines [0], or to correct grave bugs in the source code. > + (synopsis "Beautiful desktop GUI client for browsing Geminispace") The manual section Synopses and Descriptions asks us to avoid so-called "marketing language". Beauty is in the eye of the beholder... :) Otherwise, LGTM! [0] https://www.gnu.org/distros/free-system-distribution-guidelines.en.html