From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kOBEHfN1X2Bw1AAAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 19:14:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kLwpFvN1X2CIdwAA1q6Kng (envelope-from ) for ; Sat, 27 Mar 2021 18:14:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BDE592A3C4 for ; Sat, 27 Mar 2021 19:14:10 +0100 (CET) Received: from localhost ([::1]:57506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQDRp-0007C1-SL for larch@yhetil.org; Sat, 27 Mar 2021 14:14:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQDRi-0007BX-NG for guix-patches@gnu.org; Sat, 27 Mar 2021 14:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQDRi-0002RR-09 for guix-patches@gnu.org; Sat, 27 Mar 2021 14:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQDRh-00033m-SL for guix-patches@gnu.org; Sat, 27 Mar 2021 14:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47433] [PATCH 1/2] gnu: Add the-foundation. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Mar 2021 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47433 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47433@debbugs.gnu.org Cc: lle-bout@zaclys.net X-Debbugs-Original-To: =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via X-Debbugs-Original-Cc: 47433@debbugs.gnu.org, =?UTF-8?Q?L=C3=A9o?= Le Bouter Received: via spool by submit@debbugs.gnu.org id=B.161686878611693 (code B ref -1); Sat, 27 Mar 2021 18:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Mar 2021 18:13:06 +0000 Received: from localhost ([127.0.0.1]:44908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQDQn-00032S-W3 for submit@debbugs.gnu.org; Sat, 27 Mar 2021 14:13:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:58668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQDQl-00032D-8W for submit@debbugs.gnu.org; Sat, 27 Mar 2021 14:13:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQDQk-0006yZ-Br for guix-patches@gnu.org; Sat, 27 Mar 2021 14:13:02 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQDQh-0001nh-LP for guix-patches@gnu.org; Sat, 27 Mar 2021 14:13:02 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F12BF5C0047; Sat, 27 Mar 2021 14:12:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 27 Mar 2021 14:12:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=hnpKCYw0PylwEM4y9b3cKnG1APG8QuRYzfEzeBUNuRw=; b=mpbnyascrj5Z 9E5JAy/MEFP1c+6LPz13Fqnq575W/MUr9eTklvJLIDKOtTuNDMyfJzx/wortLwdc r5gbKJw8fd9ntpe7qZerTQ6isGib7oZHWX+xTn8Xwjqipl8rsg+yQ0uoEWTym8Fs 12zh0yMvwl5SOoheLlaBNX/T+Gyd0MY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=hnpKCYw0PylwEM4y9b3cKnG1APG8QuRYzfEzeBUNu Rw=; b=QNqshDhx7RD6SjfnJQBu/tYcuc5vIE+VheSc9OM+n03SuDEw9e029pfO+ y03DOxZ5dPwLIn9QiAXPn23gufvOgbWamSBxIvmn2gI2NDyQRsp+/ZS/ksZFxTAk QOltkIz7gbYBTM/1CkH/I2qculZufTgetVI/6VqkjrHlDVscP7EAbCWJazhjdCi9 eLox71A7U/awc/y15XeLrG4hJlnD+bZnXTtbTwBfpF900w8Mt/pLVfCcZ/vggQZf yAE9+1vU5X13ZuU9ctDZBr/4kcPhqDu/5YvfCCaLFw02XYahIAr45dO3sEEbFFhe uqyMqGWN47ioK9wazMs5NFviaBOkw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehgedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeegieelteeuuedujeehfefhtddugfeffeehuedtueevfefhhffffffgveei leduhfenucffohhmrghinhepghhnuhdrohhrghenucfkphepuddttddruddurdduieelrd duudeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep lhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 89AC3108005F; Sat, 27 Mar 2021 14:12:56 -0400 (EDT) Date: Sat, 27 Mar 2021 14:12:55 -0400 From: Leo Famulari Message-ID: References: <20210327134537.31188-1-lle-bout@zaclys.net> <20210327134629.31646-1-lle-bout@zaclys.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210327134629.31646-1-lle-bout@zaclys.net> Received-SPF: pass client-ip=66.111.4.26; envelope-from=leo@famulari.name; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616868850; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hnpKCYw0PylwEM4y9b3cKnG1APG8QuRYzfEzeBUNuRw=; b=gw1b8Yvge8wSzz853qZOi0mBB6NjgoDrm+hGz60ZyvUycwDgFIIDCV/ktg11z60SPQs+pN /AjErKRURezUTZ/eIoyRBtStJ7qK9WTmDIWV/Nps2rvnOSdSqfLj1XR4S9fBwz6dVBagHm BzCWnID647H+7USGv/c4t2W936fr6jNAv1K3PrUFIuuyoo6gBKue5Z+7/SkuGU1TyuKDjU YrxGnriJrRaQuDLVoRN6V/4pLI+SrTIs5SE+LYlsTAj7TlmpiOIytEzSTZbRiaybdcCrBe 8vdiM6Zye6rZrqpPSL4WicZZMW4lEc9RCESs7mlFqtBG0pKd4P0IonyO57aeHg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616868850; a=rsa-sha256; cv=none; b=oShdbW+XE/h1d9RC7WoJ0xWk8yK2/XvZILf8ORiuFmYkX32CqPGyDL09w9W72YzWRJlyh1 WZExYEGqprrH25lS66QL2SZRjCdXRqQ1tH6WDMVhVZx7gRtqquMvAo1OFypA0W4E2/7Bd0 hukmNHQVU4XxJ2ZBlWHtWD5gG5+67b0QQAbSeCR0tan3g1GYUI41m/WB4JiTp1nbnQzs1H GG9BhXPq6stZpkkYNag5yiipFgJbYJk7PEeUntB54jhbmSii/icFe87cXMFDtBYj/LxNRZ TCnz0GQWPMYXKOzLQByQspBGIY/xkx4r07PRz7Ta1bIfEjGke1zOh3VFNdH6Dw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=mpbnyasc; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=QNqshDhx; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=mpbnyasc; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=QNqshDhx; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BDE592A3C4 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: QfjNgiw0mGEN On Sat, Mar 27, 2021 at 02:46:28PM +0100, Léo Le Bouter via Guix-patches via wrote: > * gnu/packages/web.scm (the-foundation): New variable. Thanks! > +(define-public the-foundation > + (let ((commit "8172d35cad24ec392bfd27e1f4de3a2205f988d2")) Please add a "revision" variable ... > + (package > + (name "the-foundation") > + (version (string-take commit 7)) ... and use the git-version procedure, as described in the manual section Version Numbers: https://guix.gnu.org/manual/en/html_node/Version-Numbers.html > + (native-inputs > + `(("git" ,git-minimal) Does it only use Git at build-time, and not keep a reference to the Git package? You can check like this: $ guix gc --references $(guix build --no-grafts thefoundation) | grep git If it keeps a reference, then Git should be a regular input. I ask because it's unusual for Guix packages to need to Git as a native-inputs, because the .git directory is deleted before building, and there is no network access at build time. Otherwise, looks good to me.