[bug#44479] [PATCH] gnu: Add emacs-csharp-mode.

[bug#44479] [PATCH] gnu: Add emacs-csharp-mode.

[marco.au.grassi98--- via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 13 bytes --]

Empty Message

[-- Attachment #1.2: Type: text/html, Size: 24 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-csharp-mode.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-emacs-csharp-mode.patch, Size: 2151 bytes --]

From 8a0cd9c5ccbb70d15ba989c304367772f2662929 Mon Sep 17 00:00:00 2001
From: AuPath <marco.au.grassi98@protonmail.com>
Date: Fri, 6 Nov 2020 13:26:55 +0100
Subject: [PATCH] gnu: Add emacs-csharp-mode.

* gnu/packages/emacs-xyz.scm (emacs-csharp-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 41 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a145f6a378..4706e163e9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11343,6 +11343,47 @@ constructs.")
 configuration of Chinese fonts.")
     (license license:gpl2+)))
 
+(define-public emacs-csharp-mode
+  (package
+    (name "emacs-csharp-mode")
+    (version "0.10.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/josteink/csharp-mode")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0vwkbla2gkfa9dzxfvrvr7hd2z16769iwbycl7k6l701dnwli1fw"))))
+    (build-system emacs-build-system)
+    (home-page
+     "https://github.com/josteink/csharp-mode")
+    (synopsis "C# mode derived mode")
+    (description
+     "A C# editing mode for Emacs.  Based on cc-mode, v5.30.3 and above.
+ Features include:
+@itemize
+@item font-lock and indent of C# syntax including:
+@itemize
+@item all c# keywords and major syntax
+@item attributes that decorate methods, classes, fields, properties
+@item enum types
+@item #if/#endif #region/#endregion
+@item instance initializers
+@item anonymous functions and methods
+@item verbatim literal strings (those that begin with @@)
+@item generics
+@end itemize
+@item automagic code-doc generation when you type three slashes.
+@item intelligent insertion of matched pairs of curly braces.
+@item imenu indexing of C# source, for easy menu-based navigation.
+@item compilation-mode support for msbuild, devenv and xbuild.
+@end itemize\n")
+    (license license:gpl2+)))
+
+
 (define-public emacs-php-mode
   (package
     (name "emacs-php-mode")
-- 
2.29.2

[bug#44479] [PATCH] gnu: Add emacs-csharp-mode.

[Nicolas Goaziou]

Hello,

"marco.au.grassi98--- via Guix-patches" via <guix-patches@gnu.org>
writes:

> Subject: [PATCH] gnu: Add emacs-csharp-mode.

Thank you. Some comments follow.
>
> +       (sha256
> +        (base32
> +         "0vwkbla2gkfa9dzxfvrvr7hd2z16769iwbycl7k6l701dnwli1fw"))))

Nitpick: please move the string on the same line as `base32'.

> +    (build-system emacs-build-system)
> +    (home-page
> +     "https://github.com/josteink/csharp-mode")

Nitpick: please move the URL on the same line as `home-page'.

> +    (synopsis "C# mode derived mode")

This synopsis is a bit cryptic. Could you rephrase it somehow?

> +    (description
> +     "A C# editing mode for Emacs.  Based on cc-mode, v5.30.3 and
> above.

The description ought to consist of "full" sentences.

> + Features include:
> +@itemize
> +@item font-lock and indent of C# syntax including:
> +@itemize
> +@item all c# keywords and major syntax
> +@item attributes that decorate methods, classes, fields, properties
> +@item enum types
> +@item #if/#endif #region/#endregion
> +@item instance initializers
> +@item anonymous functions and methods
> +@item verbatim literal strings (those that begin with @@)
> +@item generics
> +@end itemize
> +@item automagic code-doc generation when you type three slashes.
> +@item intelligent insertion of matched pairs of curly braces.
> +@item imenu indexing of C# source, for easy menu-based navigation.
> +@item compilation-mode support for msbuild, devenv and xbuild.
> +@end itemize\n")

I think it is preferable to avoid nested lists in the description. Also,
according to the manual, "descriptions should take between five and ten
lines". In particular, they do not need to be exhaustive.

For example, it could be something like:

  This is a C# editing mode for Emacs, based on CC mode.  It handles
  syntax coloring, indentation, insertion of matched pairs of curly
  braces and documentation generation.  In addition, it provides
  menu-based navigation using Imenu, and Compilation mode support for
  MSBuild, devenv and xbuild.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

[bug#44479] [PATCH] gnu: Add emacs-csharp-mode

[marco.au.grassi98--- via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 77 bytes --]

Sorry, i updated the patch like you asked.
Thanks for the tips!

Grassi Marco

[-- Attachment #1.2: Type: text/html, Size: 134 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-csharp-mode.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-emacs-csharp-mode.patch, Size: 1653 bytes --]

From c7391fde3e5b86b758810b4132eb6c54fe3db588 Mon Sep 17 00:00:00 2001
From: AuPath <marco.au.grassi98@protonmail.com>
Date: Sat, 7 Nov 2020 11:46:39 +0100
Subject: [PATCH] gnu: Add emacs-csharp-mode.

* gnu/packages/emacs-xyz.scm (emacs-csharp-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a145f6a378..deab69e6d8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11343,6 +11343,29 @@ constructs.")
 configuration of Chinese fonts.")
     (license license:gpl2+)))
 
+(define-public emacs-csharp-mode
+  (package
+    (name "emacs-csharp-mode")
+    (version "0.10.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/josteink/csharp-mode")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0vwkbla2gkfa9dzxfvrvr7hd2z16769iwbycl7k6l701dnwli1fw"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/josteink/csharp-mode")
+    (synopsis "Major mode for C# code")
+    (description "This is a C# editing mode for Emacs, based on CC mode.  It
+handles syntax coloring, indentation, insertion of matched pairs of curly
+braces and documentation generation.  In addition, it provides menu-based
+navigation using Imenu, and Compilation mode support for MSBuild, devenv and
+xbuild.")
+    (license license:gpl2+)))
+
 (define-public emacs-php-mode
   (package
     (name "emacs-php-mode")
-- 
2.29.2

[bug#44479] [PATCH] gnu: Add emacs-csharp-mode

[Nicolas Goaziou]

"marco.au.grassi98--- via Guix-patches" via <guix-patches@gnu.org>
writes:

> Subject: [PATCH] gnu: Add emacs-csharp-mode.

Applied. Thank you!

Regards,