From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WG+XI1Jrpl8ZYwAA0tVLHw (envelope-from ) for ; Sat, 07 Nov 2020 09:39:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UN2PH1Jrpl8aEgAA1q6Kng (envelope-from ) for ; Sat, 07 Nov 2020 09:39:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 149CC94042E for ; Sat, 7 Nov 2020 09:39:30 +0000 (UTC) Received: from localhost ([::1]:37410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbKgy-0004ix-Oi for larch@yhetil.org; Sat, 07 Nov 2020 04:39:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbKgY-0004ih-RP for guix-patches@gnu.org; Sat, 07 Nov 2020 04:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbKgY-00034i-IU for guix-patches@gnu.org; Sat, 07 Nov 2020 04:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbKgY-0006Qb-Ey for guix-patches@gnu.org; Sat, 07 Nov 2020 04:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44479] [PATCH] gnu: Add emacs-csharp-mode. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 07 Nov 2020 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44479 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44479@debbugs.gnu.org Cc: marco.au.grassi98@protonmail.com X-Debbugs-Original-To: "marco.au.grassi98--- via Guix-patches" via X-Debbugs-Original-Cc: marco.au.grassi98@protonmail.com, 44479@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160474193924700 (code B ref -1); Sat, 07 Nov 2020 09:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Nov 2020 09:38:59 +0000 Received: from localhost ([127.0.0.1]:57960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbKgU-0006QK-R3 for submit@debbugs.gnu.org; Sat, 07 Nov 2020 04:38:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:54412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbKgS-0006QB-UO for submit@debbugs.gnu.org; Sat, 07 Nov 2020 04:38:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbKgS-0004iZ-Gp for guix-patches@gnu.org; Sat, 07 Nov 2020 04:38:56 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:61209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbKgQ-00030S-HY for guix-patches@gnu.org; Sat, 07 Nov 2020 04:38:56 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9839C240007; Sat, 7 Nov 2020 09:38:48 +0000 (UTC) From: Nicolas Goaziou References: Date: Sat, 07 Nov 2020 10:38:46 +0100 In-Reply-To: (marco au.grassi's message of "Fri, 06 Nov 2020 12:37:55 +0000") Message-ID: <87ft5ljyl5.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/07 04:38:49 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.6 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: B6yYiYTYBj5p Hello, "marco.au.grassi98--- via Guix-patches" via writes: > Subject: [PATCH] gnu: Add emacs-csharp-mode. Thank you. Some comments follow. > > + (sha256 > + (base32 > + "0vwkbla2gkfa9dzxfvrvr7hd2z16769iwbycl7k6l701dnwli1fw")))) Nitpick: please move the string on the same line as `base32'. > + (build-system emacs-build-system) > + (home-page > + "https://github.com/josteink/csharp-mode") Nitpick: please move the URL on the same line as `home-page'. > + (synopsis "C# mode derived mode") This synopsis is a bit cryptic. Could you rephrase it somehow? > + (description > + "A C# editing mode for Emacs. Based on cc-mode, v5.30.3 and > above. The description ought to consist of "full" sentences. > + Features include: > +@itemize > +@item font-lock and indent of C# syntax including: > +@itemize > +@item all c# keywords and major syntax > +@item attributes that decorate methods, classes, fields, properties > +@item enum types > +@item #if/#endif #region/#endregion > +@item instance initializers > +@item anonymous functions and methods > +@item verbatim literal strings (those that begin with @@) > +@item generics > +@end itemize > +@item automagic code-doc generation when you type three slashes. > +@item intelligent insertion of matched pairs of curly braces. > +@item imenu indexing of C# source, for easy menu-based navigation. > +@item compilation-mode support for msbuild, devenv and xbuild. > +@end itemize\n") I think it is preferable to avoid nested lists in the description. Also, according to the manual, "descriptions should take between five and ten lines". In particular, they do not need to be exhaustive. For example, it could be something like: This is a C# editing mode for Emacs, based on CC mode. It handles syntax coloring, indentation, insertion of matched pairs of curly braces and documentation generation. In addition, it provides menu-based navigation using Imenu, and Compilation mode support for MSBuild, devenv and xbuild. Could you send an updated patch? Regards, -- Nicolas Goaziou