[bug#57495] [PATCH] gnu: Add steam-devices-udev-rules.

[bug#57495] [PATCH] gnu: Add steam-devices-udev-rules.

[Morgan.J.Smith]

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/games.scm (steam-devices-udev-rules): New variable.
---
 gnu/packages/games.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index fe66343a4c..f8c6b86cf7 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -12591,3 +12591,26 @@ (define-public freerct
 Should they go unwise, a theme park plunge into chaos with vandalizing guests
 and unsafe rides.  Which path will you take?")
     (license license:gpl2)))
+
+(define-public steam-devices-udev-rules
+  (package
+    (name "steam-devices-udev-rules")
+    (version "1.0.0.61")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ValveSoftware/steam-devices")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))
+    (build-system copy-build-system)
+    (arguments
+     '(#:install-plan '(("./" "lib/udev/rules.d"
+                         #:include-regexp ("rules$")))))
+    (home-page "https://github.com/ValveSoftware/steam-devices")
+    (synopsis "udev rules for game controllers and virtual reality devices")
+    (description
+     "Provides a set of udev rules for game controllers and virtual reality devices.")
+    (license license:expat)))
-- 
2.37.2

[bug#57495] [PATCH] gnu: Add steam-devices-udev-rules.

[John Kehayias via Guix-patches via]

Hello,

Thanks for submitting this here! I've been grabbing these files directly
in my system configuration to use the udev rules and never got around to
making a proper package.

Overall LGTM (but did not try out this package), with one minor comment:

On Tue, Aug 30, 2022 at 03:01 PM, Morgan wrote:

> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
>  gnu/packages/games.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index fe66343a4c..f8c6b86cf7 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -12591,3 +12591,26 @@ (define-public freerct
>  Should they go unwise, a theme park plunge into chaos with vandalizing guests
>  and unsafe rides.  Which path will you take?")
>      (license license:gpl2)))
> +
> +(define-public steam-devices-udev-rules
> +  (package
> +    (name "steam-devices-udev-rules")
> +    (version "1.0.0.61")

This tag is from 3 years ago now. While this is the latest tag/release,
there have been commits more recently than that. Considering these will
mostly be for adding/tweaking hardware rule, personally I would like
this to reflect the most recent commit to be the most useful. This is
from a year ago now, so it seems the timeline for a release is probably
"Valve time" (aka I'm not holding my breath).

What do you think?

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ValveSoftware/steam-devices")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))
> +    (build-system copy-build-system)
> +    (arguments
> +     '(#:install-plan '(("./" "lib/udev/rules.d"
> +                         #:include-regexp ("rules$")))))
> +    (home-page "https://github.com/ValveSoftware/steam-devices")
> +    (synopsis "udev rules for game controllers and virtual reality devices")
> +    (description
> +     "Provides a set of udev rules for game controllers and virtual reality devices.")
> +    (license license:expat)))

Thanks!
John

[bug#57495] [PATCH] gnu: Add steam-devices-udev-rules.

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 1695 bytes --]


On 30-08-2022 21:01, Morgan.J.Smith@outlook.com wrote:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
>   gnu/packages/games.scm | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index fe66343a4c..f8c6b86cf7 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -12591,3 +12591,26 @@ (define-public freerct
>   Should they go unwise, a theme park plunge into chaos with vandalizing guests
>   and unsafe rides.  Which path will you take?")
>       (license license:gpl2)))
> +
> +(define-public steam-devices-udev-rules
> +  (package
> +    (name "steam-devices-udev-rules")
> +    (version "1.0.0.61")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ValveSoftware/steam-devices")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))

I have taken a look at the rules, and noticed:

https://github.com/ValveSoftware/steam-devices/blob/d87ef558408c5e7a1a793d738db4c9dc2cb5f8fa/60-steam-input.rules#L55

KERNEL=="input*", ATTRS{name}=="Lic Pro Controller", 
RUN{program}+="/bin/sh -c 'udevadm test-builtin uaccess 
/sys/%p/../../hidraw/hidraw*'"

/bin/sh and udevadm will need to patched (with substitute*) to guarantee 
that sh and udevadm will be found.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#57495] [PATCH v2] gnu: Add steam-devices-udev-rules.

[Morgan.J.Smith]

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/games.scm (steam-devices-udev-rules): New variable.
---

I've incorporated both of your suggestions into the following patch


 gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index fe66343a4c..98e5389903 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -12591,3 +12591,38 @@ (define-public freerct
 Should they go unwise, a theme park plunge into chaos with vandalizing guests
 and unsafe rides.  Which path will you take?")
     (license license:gpl2)))
+
+(define-public steam-devices-udev-rules
+  ;; Last release from 2019-04-10
+  (let ((commit "d87ef558408c5e7a1a793d738db4c9dc2cb5f8fa")
+        (revision "0"))
+    (package
+      (name "steam-devices-udev-rules")
+      (version (git-version "1.0.0.61" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/ValveSoftware/steam-devices")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1yqigraz9f19018ma5n2pbx7naadh9960lia3z8ayg7vz1fjdl54"))))
+      (build-system copy-build-system)
+      (arguments
+       '(#:install-plan '(("./" "lib/udev/rules.d"
+                           #:include-regexp ("rules$")))
+         #:phases (modify-phases %standard-phases
+                    (add-after 'unpack 'patch-paths
+                      (lambda* (#:key inputs #:allow-other-keys)
+                        (substitute* "60-steam-input.rules"
+                          (("/bin/sh")
+                           (search-input-file inputs "/bin/sh"))
+                          (("udevadm")
+                           (search-input-file inputs "/bin/udevadm"))))))))
+      (inputs (list eudev))
+      (home-page "https://github.com/ValveSoftware/steam-devices")
+      (synopsis "udev rules for game controllers and virtual reality devices")
+      (description
+       "Provides a set of udev rules for game controllers and virtual reality devices.")
+      (license license:expat))))
-- 
2.37.2

[bug#57495] [PATCH v2] gnu: Add steam-devices-udev-rules.

[John Kehayias via Guix-patches via]

On Wed, Aug 31, 2022 at 12:44 PM, Morgan.J.Smith@outlook.com wrote:

> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
>
> I've incorporated both of your suggestions into the following patch
>
>
[snip]

LGTM

I checked that it builds and the output looks correct (correct location, took a peek at the udev rules)

bug#57495: [PATCH] gnu: Add steam-devices-udev-rules.

[Mathieu Othacehe]

Applied, thanks to all reviewers :)

Mathieu