From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: Morgan.J.Smith@outlook.com
Cc: 57495@debbugs.gnu.org
Subject: [bug#57495] [PATCH] gnu: Add steam-devices-udev-rules.
Date: Wed, 31 Aug 2022 00:27:55 +0000 [thread overview]
Message-ID: <87tu5tntob.fsf@protonmail.com> (raw)
In-Reply-To: <DM5PR03MB3163E76815AFB6B7B6084160C5799@DM5PR03MB3163.namprd03.prod.outlook.com>
Hello,
Thanks for submitting this here! I've been grabbing these files directly
in my system configuration to use the udev rules and never got around to
making a proper package.
Overall LGTM (but did not try out this package), with one minor comment:
On Tue, Aug 30, 2022 at 03:01 PM, Morgan wrote:
> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
> gnu/packages/games.scm | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index fe66343a4c..f8c6b86cf7 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -12591,3 +12591,26 @@ (define-public freerct
> Should they go unwise, a theme park plunge into chaos with vandalizing guests
> and unsafe rides. Which path will you take?")
> (license license:gpl2)))
> +
> +(define-public steam-devices-udev-rules
> + (package
> + (name "steam-devices-udev-rules")
> + (version "1.0.0.61")
This tag is from 3 years ago now. While this is the latest tag/release,
there have been commits more recently than that. Considering these will
mostly be for adding/tweaking hardware rule, personally I would like
this to reflect the most recent commit to be the most useful. This is
from a year ago now, so it seems the timeline for a release is probably
"Valve time" (aka I'm not holding my breath).
What do you think?
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ValveSoftware/steam-devices")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))
> + (build-system copy-build-system)
> + (arguments
> + '(#:install-plan '(("./" "lib/udev/rules.d"
> + #:include-regexp ("rules$")))))
> + (home-page "https://github.com/ValveSoftware/steam-devices")
> + (synopsis "udev rules for game controllers and virtual reality devices")
> + (description
> + "Provides a set of udev rules for game controllers and virtual reality devices.")
> + (license license:expat)))
Thanks!
John
next prev parent reply other threads:[~2022-08-31 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:01 [bug#57495] [PATCH] gnu: Add steam-devices-udev-rules Morgan.J.Smith
2022-08-31 0:27 ` John Kehayias via Guix-patches via [this message]
2022-08-31 15:55 ` Maxime Devos
2022-08-31 16:44 ` [bug#57495] [PATCH v2] " Morgan.J.Smith
2022-09-09 20:15 ` John Kehayias via Guix-patches via
2022-09-11 14:38 ` bug#57495: [PATCH] " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu5tntob.fsf@protonmail.com \
--to=guix-patches@gnu.org \
--cc=57495@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).