unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#61659] [PATCH 0/6] gnu: Add texlive-minted.
@ 2023-02-20 17:24 Morgan.J.Smith
  2023-02-20 17:36 ` [bug#61659] [PATCH 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Morgan.J.Smith @ 2023-02-20 17:24 UTC (permalink / raw)
  To: 61659

[PATCH 1/6] gnu: Add texlive-catchfile.
[PATCH 2/6] gnu: texlive-latex-ifplatform: Add needed propagated-inputs.
[PATCH 3/6] gnu: texlive-mdframed: Add needed propagated-inputs.
[PATCH 4/6] gnu: texlive-latex-fancyvrb: Add needed propagated-inputs.
[PATCH 5/6] gnu: Add texlive-fvextra.
[PATCH 6/6] gnu: Add texlive-minted.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#61659] [PATCH 1/6] gnu: Add texlive-catchfile.
  2023-02-20 17:24 [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Morgan.J.Smith
@ 2023-02-20 17:36 ` Morgan.J.Smith
  2023-02-20 18:00 ` [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Nicolas Goaziou
  2023-02-20 21:04 ` [bug#61659] [PATCH v2 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
  2 siblings, 0 replies; 6+ messages in thread
From: Morgan.J.Smith @ 2023-02-20 17:36 UTC (permalink / raw)
  To: 61659; +Cc: Morgan Smith

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/tex.scm (texlive-catchfile): New variable.
---
 gnu/packages/tex.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index dafed9d3c3..96c07de51b 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -5304,6 +5304,23 @@ (define-public texlive-carlisle
 in LaTeX documents; a jiffy to create slashed characters for physicists.")
     (license license:lppl)))
 
+(define-public texlive-catchfile
+  (package
+    (inherit (simple-texlive-package
+              "texlive-catchfile"
+              (list "/doc/latex/catchfile/"
+                    "/source/latex/catchfile/"
+                    "/tex/generic/catchfile/")
+              (base32
+               "1dpxy64hs0bjp8d2dmikflc995vazf7fi6z92w51fnj2fidgl8gx")
+              #:trivial? #t))
+    (home-page "https://ctan.org/macros/latex/contrib/catchfile")
+    (synopsis "Catch an external file into a macro")
+    (description
+     "Catches the contents of a file and puts it in a macro.  It requires
+e-TeX.  Both LaTeX and plain TeX are supported.")
+    (license license:lppl1.3+)))
+
 (define-public texlive-doi
   (package
     (inherit (simple-texlive-package
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#61659] [PATCH 0/6] gnu: Add texlive-minted.
  2023-02-20 17:24 [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Morgan.J.Smith
  2023-02-20 17:36 ` [bug#61659] [PATCH 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
@ 2023-02-20 18:00 ` Nicolas Goaziou
  2023-02-20 21:10   ` Morgan Smith
  2023-02-20 21:04 ` [bug#61659] [PATCH v2 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
  2 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2023-02-20 18:00 UTC (permalink / raw)
  To: Morgan.J.Smith; +Cc: 61659

Hello,

Morgan.J.Smith@outlook.com writes:

> [PATCH 1/6] gnu: Add texlive-catchfile.
> [PATCH 2/6] gnu: texlive-latex-ifplatform: Add needed propagated-inputs.
> [PATCH 3/6] gnu: texlive-mdframed: Add needed propagated-inputs.
> [PATCH 4/6] gnu: texlive-latex-fancyvrb: Add needed propagated-inputs.
> [PATCH 5/6] gnu: Add texlive-fvextra.
> [PATCH 6/6] gnu: Add texlive-minted.

I gave a glance at these patches. Thanks for them.

texlive-catchfile, texlive-fvextra and texlive-minted are not trivial
packages (in the #:trivial? #t) since they contain ".dtx" or ".ins"
files. Could you try generating the run files from those source files
instead?

Also, descriptions need to start with a complete sentence. For example

  Catches the contents of a file and puts it in a macro.  It requires
  e-TeX.  Both LaTeX and plain TeX are supported.

could simply become :

  Catchfile catches the contents of a file and puts it in a macro.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#61659] [PATCH v2 1/6] gnu: Add texlive-catchfile.
  2023-02-20 17:24 [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Morgan.J.Smith
  2023-02-20 17:36 ` [bug#61659] [PATCH 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
  2023-02-20 18:00 ` [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Nicolas Goaziou
@ 2023-02-20 21:04 ` Morgan.J.Smith
  2 siblings, 0 replies; 6+ messages in thread
From: Morgan.J.Smith @ 2023-02-20 21:04 UTC (permalink / raw)
  To: 61659; +Cc: Morgan Smith

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/tex.scm (texlive-catchfile): New variable.
---
 gnu/packages/tex.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index dafed9d3c3..efccba17cc 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -5304,6 +5304,26 @@ (define-public texlive-carlisle
 in LaTeX documents; a jiffy to create slashed characters for physicists.")
     (license license:lppl)))
 
+(define-public texlive-catchfile
+  (let ((template (simple-texlive-package
+                   "texlive-catchfile"
+                   (list "/doc/latex/catchfile/"
+                         "/source/latex/catchfile/"
+                         "/tex/generic/catchfile/")
+                   (base32
+                    "1dpxy64hs0bjp8d2dmikflc995vazf7fi6z92w51fnj2fidgl8gx"))))
+    (package
+      (inherit template)
+      (arguments
+       (substitute-keyword-arguments (package-arguments template)
+         ((#:tex-directory _ #t)
+          "latex/catchfile")))
+      (home-page "https://ctan.org/macros/latex/contrib/catchfile")
+      (synopsis "Catch an external file into a macro")
+      (description
+       "Catchfile catches the contents of a file and puts it in a macro.")
+      (license license:lppl1.3+))))
+
 (define-public texlive-doi
   (package
     (inherit (simple-texlive-package
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#61659] [PATCH 0/6] gnu: Add texlive-minted.
  2023-02-20 18:00 ` [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Nicolas Goaziou
@ 2023-02-20 21:10   ` Morgan Smith
  2023-02-23 14:28     ` bug#61659: " Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Morgan Smith @ 2023-02-20 21:10 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 61659

Hello Nicolas,

I've made the changes you asked for (sent to debbugs as I don't want to
fill up your inbox).  I'm able to compile a latex document using minted
so I think everything is in order on the technical side.  I do seem to
struggle with the English side a little bit :P

I still have no clue how latex works under the hood or what ".dtx" or
".ins" files are but thankfully Guix seems to be shielding me from such
knowledge with thoughtful abstraction layers! :)

Thanks,

Morgan




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#61659: [PATCH 0/6] gnu: Add texlive-minted.
  2023-02-20 21:10   ` Morgan Smith
@ 2023-02-23 14:28     ` Nicolas Goaziou
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2023-02-23 14:28 UTC (permalink / raw)
  To: Morgan Smith; +Cc: 61659-done

Hello,
Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> Hello Nicolas,
>
> I've made the changes you asked for (sent to debbugs as I don't want to
> fill up your inbox).  I'm able to compile a latex document using minted
> so I think everything is in order on the technical side.

Applied. Thank you!

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-02-23 14:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-20 17:24 [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Morgan.J.Smith
2023-02-20 17:36 ` [bug#61659] [PATCH 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
2023-02-20 18:00 ` [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Nicolas Goaziou
2023-02-20 21:10   ` Morgan Smith
2023-02-23 14:28     ` bug#61659: " Nicolas Goaziou
2023-02-20 21:04 ` [bug#61659] [PATCH v2 1/6] gnu: Add texlive-catchfile Morgan.J.Smith

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).