unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Morgan.J.Smith@outlook.com
Cc: 61659@debbugs.gnu.org
Subject: [bug#61659] [PATCH 0/6] gnu: Add texlive-minted.
Date: Mon, 20 Feb 2023 19:00:38 +0100	[thread overview]
Message-ID: <87fsb0qks9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <DM5PR03MB31631AF924530D504B2C5512C5A49@DM5PR03MB3163.namprd03.prod.outlook.com> (Morgan J. Smith's message of "Mon, 20 Feb 2023 12:24:36 -0500")

Hello,

Morgan.J.Smith@outlook.com writes:

> [PATCH 1/6] gnu: Add texlive-catchfile.
> [PATCH 2/6] gnu: texlive-latex-ifplatform: Add needed propagated-inputs.
> [PATCH 3/6] gnu: texlive-mdframed: Add needed propagated-inputs.
> [PATCH 4/6] gnu: texlive-latex-fancyvrb: Add needed propagated-inputs.
> [PATCH 5/6] gnu: Add texlive-fvextra.
> [PATCH 6/6] gnu: Add texlive-minted.

I gave a glance at these patches. Thanks for them.

texlive-catchfile, texlive-fvextra and texlive-minted are not trivial
packages (in the #:trivial? #t) since they contain ".dtx" or ".ins"
files. Could you try generating the run files from those source files
instead?

Also, descriptions need to start with a complete sentence. For example

  Catches the contents of a file and puts it in a macro.  It requires
  e-TeX.  Both LaTeX and plain TeX are supported.

could simply become :

  Catchfile catches the contents of a file and puts it in a macro.

Regards,
-- 
Nicolas Goaziou




  parent reply	other threads:[~2023-02-20 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 17:24 [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Morgan.J.Smith
2023-02-20 17:36 ` [bug#61659] [PATCH 1/6] gnu: Add texlive-catchfile Morgan.J.Smith
2023-02-20 18:00 ` Nicolas Goaziou [this message]
2023-02-20 21:10   ` [bug#61659] [PATCH 0/6] gnu: Add texlive-minted Morgan Smith
2023-02-23 14:28     ` bug#61659: " Nicolas Goaziou
2023-02-20 21:04 ` [bug#61659] [PATCH v2 1/6] gnu: Add texlive-catchfile Morgan.J.Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsb0qks9.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=61659@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).