* [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
@ 2019-08-14 12:57 David Thompson
2019-08-23 21:31 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: David Thompson @ 2019-08-14 12:57 UTC (permalink / raw)
To: 37026
Fixes a bug where propagated inputs that should be cross-compiled are instead
compiled for the host system.
* guix/packages.scm (bag-transitive-host-inputs): Call transitive-inputs in
the context of the bag's target system triplet.
---
guix/packages.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guix/packages.scm b/guix/packages.scm
index c94a651f27..143417b861 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -796,7 +796,8 @@ dependencies are known to build on SYSTEM."
(define (bag-transitive-host-inputs bag)
"Same as 'package-transitive-target-inputs', but applied to a bag."
- (transitive-inputs (bag-host-inputs bag)))
+ (parameterize ((%current-target-system (bag-target bag)))
+ (transitive-inputs (bag-host-inputs bag))))
(define (bag-transitive-target-inputs bag)
"Return the \"target inputs\" of BAG, recursively."
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
2019-08-14 12:57 [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs David Thompson
@ 2019-08-23 21:31 ` Ludovic Courtès
2019-08-26 13:38 ` bug#37026: " Thompson, David
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2019-08-23 21:31 UTC (permalink / raw)
To: David Thompson; +Cc: 37026
Hello,
David Thompson <dthompson2@worcester.edu> skribis:
> Fixes a bug where propagated inputs that should be cross-compiled are instead
> compiled for the host system.
>
> * guix/packages.scm (bag-transitive-host-inputs): Call transitive-inputs in
> the context of the bag's target system triplet.
> ---
> guix/packages.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index c94a651f27..143417b861 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -796,7 +796,8 @@ dependencies are known to build on SYSTEM."
>
> (define (bag-transitive-host-inputs bag)
> "Same as 'package-transitive-target-inputs', but applied to a bag."
> - (transitive-inputs (bag-host-inputs bag)))
> + (parameterize ((%current-target-system (bag-target bag)))
> + (transitive-inputs (bag-host-inputs bag))))
Good catch, please push!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#37026: [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
2019-08-23 21:31 ` Ludovic Courtès
@ 2019-08-26 13:38 ` Thompson, David
0 siblings, 0 replies; 3+ messages in thread
From: Thompson, David @ 2019-08-26 13:38 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 37026-done
On Fri, Aug 23, 2019 at 5:31 PM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Good catch, please push!
Thanks. Done!
- Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-26 13:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14 12:57 [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs David Thompson
2019-08-23 21:31 ` Ludovic Courtès
2019-08-26 13:38 ` bug#37026: " Thompson, David
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).