unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: David Thompson <dthompson2@worcester.edu>
Cc: 37026@debbugs.gnu.org
Subject: [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
Date: Fri, 23 Aug 2019 23:31:08 +0200	[thread overview]
Message-ID: <87r25bzi03.fsf@gnu.org> (raw)
In-Reply-To: <20190814125755.18360-1-dthompson2@worcester.edu> (David Thompson's message of "Wed, 14 Aug 2019 08:57:55 -0400")

Hello,

David Thompson <dthompson2@worcester.edu> skribis:

> Fixes a bug where propagated inputs that should be cross-compiled are instead
> compiled for the host system.
>
> * guix/packages.scm (bag-transitive-host-inputs): Call transitive-inputs in
>   the context of the bag's target system triplet.
> ---
>  guix/packages.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index c94a651f27..143417b861 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -796,7 +796,8 @@ dependencies are known to build on SYSTEM."
>  
>  (define (bag-transitive-host-inputs bag)
>    "Same as 'package-transitive-target-inputs', but applied to a bag."
> -  (transitive-inputs (bag-host-inputs bag)))
> +  (parameterize ((%current-target-system (bag-target bag)))
> +    (transitive-inputs (bag-host-inputs bag))))

Good catch, please push!

Thanks,
Ludo’.

  reply	other threads:[~2019-08-23 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 12:57 [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs David Thompson
2019-08-23 21:31 ` Ludovic Courtès [this message]
2019-08-26 13:38   ` bug#37026: " Thompson, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r25bzi03.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37026@debbugs.gnu.org \
    --cc=dthompson2@worcester.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).